* [PATCH] usbip: tools: usbipd: fix duplicate option definition
@ 2021-10-13 14:57 Alyssa Ross
2021-10-13 15:57 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Alyssa Ross @ 2021-10-13 14:57 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan
Cc: Dominik Paulus, Alyssa Ross, open list:USB OVER IP DRIVER, open list
This seems to have been introduced by mistake in
f49ad35cd124 ("staging: usbip: Fix IPv6 support in usbipd").
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
tools/usb/usbip/src/usbipd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/usb/usbip/src/usbipd.c b/tools/usb/usbip/src/usbipd.c
index 48398a78e88a..33e8512de7c4 100644
--- a/tools/usb/usbip/src/usbipd.c
+++ b/tools/usb/usbip/src/usbipd.c
@@ -589,7 +589,6 @@ int main(int argc, char *argv[])
{ "ipv4", no_argument, NULL, '4' },
{ "ipv6", no_argument, NULL, '6' },
{ "daemon", no_argument, NULL, 'D' },
- { "daemon", no_argument, NULL, 'D' },
{ "debug", no_argument, NULL, 'd' },
{ "device", no_argument, NULL, 'e' },
{ "pid", optional_argument, NULL, 'P' },
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usbip: tools: usbipd: fix duplicate option definition
2021-10-13 14:57 [PATCH] usbip: tools: usbipd: fix duplicate option definition Alyssa Ross
@ 2021-10-13 15:57 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2021-10-13 15:57 UTC (permalink / raw)
To: Alyssa Ross, Valentina Manea, Shuah Khan
Cc: Dominik Paulus, open list:USB OVER IP DRIVER, open list, Shuah Khan
On 10/13/21 8:57 AM, Alyssa Ross wrote:
> This seems to have been introduced by mistake in
> f49ad35cd124 ("staging: usbip: Fix IPv6 support in usbipd").
>
Thanks for the patch.
Add a sentence or two to say what is being fixed and use Fixes tag
for the commit.
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
> tools/usb/usbip/src/usbipd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/usb/usbip/src/usbipd.c b/tools/usb/usbip/src/usbipd.c
> index 48398a78e88a..33e8512de7c4 100644
> --- a/tools/usb/usbip/src/usbipd.c
> +++ b/tools/usb/usbip/src/usbipd.c
> @@ -589,7 +589,6 @@ int main(int argc, char *argv[])
> { "ipv4", no_argument, NULL, '4' },
> { "ipv6", no_argument, NULL, '6' },
> { "daemon", no_argument, NULL, 'D' },
> - { "daemon", no_argument, NULL, 'D' },
> { "debug", no_argument, NULL, 'd' },
> { "device", no_argument, NULL, 'e' },
> { "pid", optional_argument, NULL, 'P' },
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-13 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 14:57 [PATCH] usbip: tools: usbipd: fix duplicate option definition Alyssa Ross
2021-10-13 15:57 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).