From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>,
gregkh@linuxfoundation.org, balbi@kernel.org
Cc: robh+dt@kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/8] usb: dwc3: of-simple: bail probe if no dwc3 child node
Date: Wed, 24 Mar 2021 17:41:22 +0100 [thread overview]
Message-ID: <1861638.PYKUYFuaPT@diego> (raw)
In-Reply-To: <20210209192350.7130-2-jbx6244@gmail.com>
Hi Greg, Felipe,
Am Dienstag, 9. Februar 2021, 20:23:44 CET schrieb Johan Jonker:
> For some of the dwc3-of-simple compatible SoCs we
> don't want to bind this driver to a dwc3 node,
> but bind that node to the 'snps,dwc3' driver instead.
> The kernel has no logic to decide which driver to bind
> to if there are 2 matching drivers, so bail probe if no
> dwc3 child node.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
It looks like this patch fell through the cracks?
I.e. I can see patches 1+6 adding the devicetree bindings
in 5.12-rc but haven't found this patch there.
And looking at
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/log/drivers/usb/dwc3/dwc3-of-simple.c?h=usb-next
I also didn't find it.
From what I gathered that was somehow mandated from the Devicetree side
as the dwc3-subnode system merely is some Linux-specific thingy
and should not be enforced if not explicitly needed.
I guess Johan can provide pointers to the previous discussion.
So could you look at applying this patch to some usb-tree?
Thanks
Heiko
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index e62ecd22b..347b4d384 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -38,6 +38,10 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
>
> int ret;
>
> + /* Bail probe if no dwc3 child node. */
> + if (!of_get_compatible_child(dev->of_node, "snps,dwc3"))
> + return -ENODEV;
> +
> simple = devm_kzalloc(dev, sizeof(*simple), GFP_KERNEL);
> if (!simple)
> return -ENOMEM;
>
next prev parent reply other threads:[~2021-03-24 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 19:23 [PATCH v5 1/8] dt-bindings: usb: convert rockchip,dwc3.txt to yaml Johan Jonker
2021-02-09 19:23 ` [PATCH v5 2/8] usb: dwc3: of-simple: bail probe if no dwc3 child node Johan Jonker
2021-03-24 16:41 ` Heiko Stübner [this message]
2021-03-24 17:21 ` Johan Jonker
2021-02-09 19:23 ` [PATCH v5 3/8] arm64: dts: rockchip: optimize clks for rk3399 dwc3 Johan Jonker
2021-02-09 19:23 ` [PATCH v5 4/8] arm64: dts: rockchip: restyle rk3399 usbdrd3_0 node Johan Jonker
2021-02-09 19:23 ` [PATCH v5 5/8] arm64: dts: rockchip: restyle rk3399 usbdrd3_1 node Johan Jonker
2021-02-09 19:23 ` [PATCH v5 6/8] dt-bindings: usb: dwc3: add description for rk3328 Johan Jonker
2021-02-10 18:43 ` Rob Herring
2021-02-09 19:23 ` [PATCH v5 7/8] arm64: dts: rockchip: add rk3328 dwc3 usb controller node Johan Jonker
2021-02-09 19:23 ` [PATCH v5 8/8] dts64: rockchip: enable dwc3 usb for A95X Z2 Johan Jonker
2021-02-10 18:43 ` [PATCH v5 1/8] dt-bindings: usb: convert rockchip,dwc3.txt to yaml Rob Herring
2021-03-25 0:50 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1861638.PYKUYFuaPT@diego \
--to=heiko@sntech.de \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).