* [PATCH] xhci: remove unused variable
@ 2021-04-01 10:17 Jiapeng Chong
2021-04-01 10:44 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2021-04-01 10:17 UTC (permalink / raw)
To: mathias.nyman; +Cc: gregkh, linux-usb, linux-kernel, Jiapeng Chong
Fix the following clang warning:
drivers/usb/host/xhci.c:1346:15: warning: variable ‘len’ set but not
used [-Wunused-but-set-variable].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/usb/host/xhci.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 1975016..0ead09c 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -1343,7 +1343,6 @@ static bool xhci_urb_temp_buffer_required(struct usb_hcd *hcd,
static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
{
- unsigned int len;
unsigned int buf_len;
enum dma_data_direction dir;
@@ -1359,10 +1358,9 @@ static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
dir);
if (usb_urb_dir_in(urb))
- len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
- urb->transfer_buffer,
- buf_len,
- 0);
+ sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
+ urb->transfer_buffer,
+ buf_len, 0);
urb->transfer_flags &= ~URB_DMA_MAP_SINGLE;
kfree(urb->transfer_buffer);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xhci: remove unused variable
2021-04-01 10:17 [PATCH] xhci: remove unused variable Jiapeng Chong
@ 2021-04-01 10:44 ` Greg KH
2021-04-21 10:39 ` Jiapeng Chong
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-04-01 10:44 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: mathias.nyman, linux-usb, linux-kernel
On Thu, Apr 01, 2021 at 06:17:15PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/usb/host/xhci.c:1346:15: warning: variable ‘len’ set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/usb/host/xhci.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 1975016..0ead09c 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1343,7 +1343,6 @@ static bool xhci_urb_temp_buffer_required(struct usb_hcd *hcd,
>
> static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
> {
> - unsigned int len;
> unsigned int buf_len;
> enum dma_data_direction dir;
>
> @@ -1359,10 +1358,9 @@ static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
> dir);
>
> if (usb_urb_dir_in(urb))
> - len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
> - urb->transfer_buffer,
> - buf_len,
> - 0);
> + sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
> + urb->transfer_buffer,
> + buf_len, 0);
>
> urb->transfer_flags &= ~URB_DMA_MAP_SINGLE;
> kfree(urb->transfer_buffer);
> --
> 1.8.3.1
>
Why resubmit this same change when I rejected it in the past?
{sigh}
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xhci: remove unused variable
2021-04-01 10:44 ` Greg KH
@ 2021-04-21 10:39 ` Jiapeng Chong
0 siblings, 0 replies; 3+ messages in thread
From: Jiapeng Chong @ 2021-04-21 10:39 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb, linux-kernel
On 2021/4/1 18:44, Greg KH wrote:
> On Thu, Apr 01, 2021 at 06:17:15PM +0800, Jiapeng Chong wrote:
>> Fix the following clang warning:
>>
>> drivers/usb/host/xhci.c:1346:15: warning: variable ‘len’ set but not
>> used [-Wunused-but-set-variable].
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> ---
>> drivers/usb/host/xhci.c | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> index 1975016..0ead09c 100644
>> --- a/drivers/usb/host/xhci.c
>> +++ b/drivers/usb/host/xhci.c
>> @@ -1343,7 +1343,6 @@ static bool xhci_urb_temp_buffer_required(struct usb_hcd *hcd,
>>
>> static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
>> {
>> - unsigned int len;
>> unsigned int buf_len;
>> enum dma_data_direction dir;
>>
>> @@ -1359,10 +1358,9 @@ static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
>> dir);
>>
>> if (usb_urb_dir_in(urb))
>> - len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
>> - urb->transfer_buffer,
>> - buf_len,
>> - 0);
>> + sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
>> + urb->transfer_buffer,
>> + buf_len, 0);
>>
>> urb->transfer_flags &= ~URB_DMA_MAP_SINGLE;
>> kfree(urb->transfer_buffer);
>> --
>> 1.8.3.1
>>
>
> Why resubmit this same change when I rejected it in the past?
>
> {sigh}
>
> greg k-h
>
Thanks for reminding us. We'll pay more attention next time.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-21 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 10:17 [PATCH] xhci: remove unused variable Jiapeng Chong
2021-04-01 10:44 ` Greg KH
2021-04-21 10:39 ` Jiapeng Chong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).