[PATCH] USB: serial: ch341: Add support for GW Instek USB2.0-Serial devices

[PATCH] USB: serial: ch341: Add support for GW Instek USB2.0-Serial devices

[Stephan Brunner]

Programmable lab power supplies made by GW Instek, such as the
GPP-2323, have a USB port exposing a serial port to control the device.

Stringing the supplied Windows driver, references to the ch341 chip are
found. Binding the existing ch341 driver to the VID/PID of the GPP-2323
("GW Instek USB2.0-Serial" as per the USB product name) works out of
the box, communication and control of the device is now possible.

This patch should work with any GPP series power supply due to
similarities in the product line.

Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
---
 drivers/usb/serial/ch341.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 29f4b87a9e74..c871fc905140 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -87,6 +87,7 @@ static const struct usb_device_id id_table[] = {
        { USB_DEVICE(0x1a86, 0x7523) },
        { USB_DEVICE(0x4348, 0x5523) },
        { USB_DEVICE(0x9986, 0x7523) },
+       { USB_DEVICE(0x2184, 0x0057) }, /* GW Instek USB2.0-Serial */
        { },
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.34.1

[PATCH v2 0/1] USB: serial: ch341: Add support for GW Instek USB2.0-Serial devices

[Stephan Brunner]

Patch resent as v2 because my MUA didn't like the tabs in the patches
making them unusable.


Stephan Brunner (1):
  USB: serial: ch341: Add support for GW Instek USB2.0-Serial devices

 drivers/usb/serial/ch341.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.34.1

[PATCH v2 1/1] USB: serial: ch341: Add support for GW Instek USB2.0-Serial devices

[Stephan Brunner]

Programmable lab power supplies made by GW Instek, such as the
GPP-2323, have a USB port exposing a serial port to control the device.

Stringing the supplied Windows driver, references to the ch341 chip are
found. Binding the existing ch341 driver to the VID/PID of the GPP-2323
("GW Instek USB2.0-Serial" as per the USB product name) works out of the
box, communication and control is now possible.

This patch should work with any GPP series power supply due to
similarities in the product line.

Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
---
 drivers/usb/serial/ch341.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 29f4b87a9e74..c871fc905140 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -87,6 +87,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x1a86, 0x7523) },
 	{ USB_DEVICE(0x4348, 0x5523) },
 	{ USB_DEVICE(0x9986, 0x7523) },
+	{ USB_DEVICE(0x2184, 0x0057) }, /* GW Instek USB2.0-Serial */
 	{ },
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.34.1

Re: [PATCH v2 1/1] USB: serial: ch341: Add support for GW Instek USB2.0-Serial devices

[Johan Hovold]

On Sat, Jan 08, 2022 at 01:00:20PM +0100, Stephan Brunner wrote:
> Programmable lab power supplies made by GW Instek, such as the
> GPP-2323, have a USB port exposing a serial port to control the device.
> 
> Stringing the supplied Windows driver, references to the ch341 chip are
> found. Binding the existing ch341 driver to the VID/PID of the GPP-2323
> ("GW Instek USB2.0-Serial" as per the USB product name) works out of the
> box, communication and control is now possible.
> 
> This patch should work with any GPP series power supply due to
> similarities in the product line.
> 
> Signed-off-by: Stephan Brunner <s.brunner@stephan-brunner.net>
> ---
>  drivers/usb/serial/ch341.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
> index 29f4b87a9e74..c871fc905140 100644
> --- a/drivers/usb/serial/ch341.c
> +++ b/drivers/usb/serial/ch341.c
> @@ -87,6 +87,7 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(0x1a86, 0x7523) },
>  	{ USB_DEVICE(0x4348, 0x5523) },
>  	{ USB_DEVICE(0x9986, 0x7523) },
> +	{ USB_DEVICE(0x2184, 0x0057) }, /* GW Instek USB2.0-Serial */

I dropped the comment (for consistency) and fixed up the sort order when
applying.

>  	{ },
>  };
>  MODULE_DEVICE_TABLE(usb, id_table);

Now applied, thanks.

Johan