* [RFC,v2,03/15] dt-bindings: add binding for USBSS-DRD controller.
@ 2018-12-04 22:41 Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-12-04 22:41 UTC (permalink / raw)
To: Pawel Laszczak
Cc: devicetree, gregkh, linux-usb, rogerq, linux-kernel, adouglas,
jbergsagel, nsekhar, nm, sureshp, peter.chen, pjez, kurahul
On Sun, Nov 18, 2018 at 10:08:59AM +0000, Pawel Laszczak wrote:
> Thsi patch aim at documenting USB related dt-bindings for the
typo
> Cadence USBSS-DRD controller.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
> .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> new file mode 100644
> index 000000000000..f9e953f32d47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> @@ -0,0 +1,17 @@
> +Binding for the Cadence USBSS-DRD controller
> +
> +Required properties:
> + - reg: Physical base address and size of the controller's register area.
1 or 3 regions? If 3, what is each one and the order?
> + - compatible: Should contain: "cdns,usb3"
Only one version and one set of bugs?
> + - interrupts: Interrupt specifier. Refer to interrupt bindings.
How many interrupts?
> +
> +
> +Example:
> + cdns3@f3000000 {
usb@...
> + compatible = "cdns,usb3";
> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers
> + 0xf3010000 0x10000 //memory area for HOST registers
> + 0xf3020000 0x10000>; //memory area for Device registers
> + };
> +
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC,v2,03/15] dt-bindings: add binding for USBSS-DRD controller.
@ 2018-12-06 10:26 Pawel Laszczak
0 siblings, 0 replies; 5+ messages in thread
From: Pawel Laszczak @ 2018-12-06 10:26 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, gregkh, linux-usb, rogerq, linux-kernel,
Alan Douglas, jbergsagel, nsekhar, nm, Suresh Punnoose,
peter.chen, Pawel Jez, Rahul Kumar
Hi,
>On Sun, Nov 18, 2018 at 10:08:59AM +0000, Pawel Laszczak wrote:
>> Thsi patch aim at documenting USB related dt-bindings for the
>
>typo
>
>> Cadence USBSS-DRD controller.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>> .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
>> new file mode 100644
>> index 000000000000..f9e953f32d47
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
>> @@ -0,0 +1,17 @@
>> +Binding for the Cadence USBSS-DRD controller
>> +
>> +Required properties:
>> + - reg: Physical base address and size of the controller's register area.
>
>1 or 3 regions? If 3, what is each one and the order?
I will add extra description.
>
>> + - compatible: Should contain: "cdns,usb3"
>
>Only one version and one set of bugs?
Yes, currently we have only one version.
>
>> + - interrupts: Interrupt specifier. Refer to interrupt bindings.
>
>How many interrupts?
Single line for Device/Host/OTG
I will add description
>
>> +
>> +
>> +Example:
>> + cdns3@f3000000 {
>
>usb@...
>
Ok.
>> + compatible = "cdns,usb3";
>> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>;
>> + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers
>> + 0xf3010000 0x10000 //memory area for HOST registers
>> + 0xf3020000 0x10000>; //memory area for Device registers
>> + };
>> +
>> --
>> 2.17.1
>>
Thanks,
Cheers
Pawel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC,v2,03/15] dt-bindings: add binding for USBSS-DRD controller.
@ 2018-11-25 7:33 Pawel Laszczak
0 siblings, 0 replies; 5+ messages in thread
From: Pawel Laszczak @ 2018-11-25 7:33 UTC (permalink / raw)
To: Roger Quadros, devicetree
Cc: gregkh, linux-usb, linux-kernel, Alan Douglas, jbergsagel,
nsekhar, nm, Suresh Punnoose, peter.chen, Pawel Jez, Rahul Kumar
Hi Roger
>On 18/11/18 12:08, Pawel Laszczak wrote:
>> Thsi patch aim at documenting USB related dt-bindings for the
>
>s/Thsi/This
>
>> Cadence USBSS-DRD controller.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>> .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
>> new file mode 100644
>> index 000000000000..f9e953f32d47
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
>> @@ -0,0 +1,17 @@
>> +Binding for the Cadence USBSS-DRD controller
>> +
>> +Required properties:
>> + - reg: Physical base address and size of the controller's register area.
>> + - compatible: Should contain: "cdns,usb3"
>> + - interrupts: Interrupt specifier. Refer to interrupt bindings.
>
>Do you also comply with USB generic bindings for dr_mode, speed, etc?
>i.e. Documentation/devicetree/bindings/usb/generic.txt
>
>If yes it must be mentioned in Optional properties:
I took a look at this document and I think that only dr_mode and maximum-speed make sense
as optional parameters.
I will add these two as optional.
Thanks.
>
>> +
>> +
>> +Example:
>> + cdns3@f3000000 {
>> + compatible = "cdns,usb3";
>> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>;
>> + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers
>> + 0xf3010000 0x10000 //memory area for HOST registers
>> + 0xf3020000 0x10000>; //memory area for Device registers
>> + };
>> +
>>
>
>cheers,
>-roger
>--
>Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Cheers,
Pawel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC,v2,03/15] dt-bindings: add binding for USBSS-DRD controller.
@ 2018-11-23 10:53 Roger Quadros
0 siblings, 0 replies; 5+ messages in thread
From: Roger Quadros @ 2018-11-23 10:53 UTC (permalink / raw)
To: Pawel Laszczak, devicetree
Cc: gregkh, linux-usb, linux-kernel, adouglas, jbergsagel, nsekhar,
nm, sureshp, peter.chen, pjez, kurahul
On 18/11/18 12:08, Pawel Laszczak wrote:
> Thsi patch aim at documenting USB related dt-bindings for the
s/Thsi/This
> Cadence USBSS-DRD controller.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
> .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> new file mode 100644
> index 000000000000..f9e953f32d47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> @@ -0,0 +1,17 @@
> +Binding for the Cadence USBSS-DRD controller
> +
> +Required properties:
> + - reg: Physical base address and size of the controller's register area.
> + - compatible: Should contain: "cdns,usb3"
> + - interrupts: Interrupt specifier. Refer to interrupt bindings.
Do you also comply with USB generic bindings for dr_mode, speed, etc?
i.e. Documentation/devicetree/bindings/usb/generic.txt
If yes it must be mentioned in Optional properties:
> +
> +
> +Example:
> + cdns3@f3000000 {
> + compatible = "cdns,usb3";
> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers
> + 0xf3010000 0x10000 //memory area for HOST registers
> + 0xf3020000 0x10000>; //memory area for Device registers
> + };
> +
>
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC,v2,03/15] dt-bindings: add binding for USBSS-DRD controller.
@ 2018-11-18 10:08 Pawel Laszczak
0 siblings, 0 replies; 5+ messages in thread
From: Pawel Laszczak @ 2018-11-18 10:08 UTC (permalink / raw)
To: devicetree
Cc: gregkh, linux-usb, rogerq, linux-kernel, adouglas, jbergsagel,
nsekhar, nm, sureshp, peter.chen, pjez, kurahul, Pawel Laszczak
Thsi patch aim at documenting USB related dt-bindings for the
Cadence USBSS-DRD controller.
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
---
.../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
new file mode 100644
index 000000000000..f9e953f32d47
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
@@ -0,0 +1,17 @@
+Binding for the Cadence USBSS-DRD controller
+
+Required properties:
+ - reg: Physical base address and size of the controller's register area.
+ - compatible: Should contain: "cdns,usb3"
+ - interrupts: Interrupt specifier. Refer to interrupt bindings.
+
+
+Example:
+ cdns3@f3000000 {
+ compatible = "cdns,usb3";
+ interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers
+ 0xf3010000 0x10000 //memory area for HOST registers
+ 0xf3020000 0x10000>; //memory area for Device registers
+ };
+
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-06 10:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 22:41 [RFC,v2,03/15] dt-bindings: add binding for USBSS-DRD controller Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2018-12-06 10:26 Pawel Laszczak
2018-11-25 7:33 Pawel Laszczak
2018-11-23 10:53 Roger Quadros
2018-11-18 10:08 Pawel Laszczak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).