From: Charles Yeh <charlesyeh522@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Yeh.Charles [葉榮鑫]" <charles-yeh@prolific.com.tw>
Subject: Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)
Date: Wed, 17 Apr 2019 21:48:13 +0800 [thread overview]
Message-ID: <CAAZvQQ6=KnZCHryxByJ2N2GhCqrk6gcGHwTETnHWH=-yCzc7HQ@mail.gmail.com> (raw)
Message-ID: <20190417134813.IRQ1vbgjVpxlMBw9skuJ_3kCnbTXasLnfCpzBt_5nmw@z> (raw)
In-Reply-To: <20190417111340.GA2520@localhost>
Johan Hovold <johan@kernel.org> 於 2019年4月17日 週三 下午7:13寫道:
> > The code I see in the pl2303_set_termios function
> > is still pl2303_vendor_write(serial,0x0,0x41),
> > Not pl2303_update_reg(serial,0,PL2303_FLOWCTRL_MASK,0x40);
>
> Yes, you need to base it on my usb-next branch (or linux-next):
>
> git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
OK, I will use
"git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git "
> I'll try to clean up the current driver some more based on your
> feedback. I'll get back to you as soon as have something concrete
> and we'll get the HXN support in place.
Thank you very much!
>
> Meanwhile here are few questions:
>
> 1. Can bcdUSB be used to detect the HXN devices?
No , you can't use bcdUSB be used to detect the HXN devices.
>
> 2. Does the old (type 01 and hx) devices require the register address
> to be ORed with 0x80 when reading?
Yes, the old (type_01 and HX ) needs require the register address to be
ORed with 0x80 when reading.
> 3. And the HXN does not need that ORing with 0x80 it seems?
Yes, HXN's hardware design is different old (type_01 and hx).
> 4. How do you use the chip-reset register (0x7) on HXN; do you write
> 0x03 if you only want to reset both data pipes?
Yes, I only want to reset both data pipes.
Charles.
next prev parent reply other threads:[~2019-04-17 13:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 12:30 USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN) Charles Yeh
2019-04-02 7:22 ` Johan Hovold
2019-04-09 9:52 ` Charles Yeh
2019-04-09 9:52 ` [PATCH] " Charles Yeh
2019-04-12 2:33 ` Charles Yeh
2019-04-12 2:33 ` [PATCH] " Charles Yeh
2019-04-15 8:56 ` Johan Hovold
2019-04-15 8:56 ` [PATCH] " Johan Hovold
2019-04-17 10:50 ` Charles Yeh
2019-04-17 10:50 ` [PATCH] " Charles Yeh
2019-04-17 11:13 ` Johan Hovold
2019-04-17 11:13 ` [PATCH] " Johan Hovold
2019-04-17 13:48 ` Charles Yeh [this message]
2019-04-17 13:48 ` Charles Yeh
2019-02-19 6:47 Charles Yeh
2019-03-04 1:24 Charles Yeh
2019-04-03 4:51 Charles Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAZvQQ6=KnZCHryxByJ2N2GhCqrk6gcGHwTETnHWH=-yCzc7HQ@mail.gmail.com' \
--to=charlesyeh522@gmail.com \
--cc=charles-yeh@prolific.com.tw \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).