From: Ming Lei <ming.lei@redhat.com> To: linux-scsi@vger.kernel.org, "Martin K . Petersen" <martin.petersen@oracle.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>, Bart Van Assche <bvanassche@acm.org>, Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>, Jim Gill <jgill@vmware.com>, Cathy Avery <cavery@redhat.com>, "Ewan D . Milne" <emilne@redhat.com>, Brian King <brking@us.ibm.com>, James Smart <james.smart@broadcom.com>, "Juergen E . Fischer" <fischer@norbit.de>, Michael Schmitz <schmitzmic@gmail.com>, Finn Thain <fthain@telegraphics.com.au>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>, Benjamin Block <bblock@linux.ibm.com>, Ming Lei <ming.lei@redhat.com> Subject: [PATCH V5 08/16] staging: unisys: visorhba: use sg helper to operate scatterlist Date: Tue, 18 Jun 2019 09:37:49 +0800 Message-ID: <20190618013757.22401-9-ming.lei@redhat.com> (raw) In-Reply-To: <20190618013757.22401-1-ming.lei@redhat.com> Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Cc: devel@driverdev.osuosl.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Ming Lei <ming.lei@redhat.com> --- drivers/staging/unisys/visorhba/visorhba_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c index 2dad36a05518..dd979ee4dcf1 100644 --- a/drivers/staging/unisys/visorhba/visorhba_main.c +++ b/drivers/staging/unisys/visorhba/visorhba_main.c @@ -871,12 +871,11 @@ static void do_scsi_nolinuxstat(struct uiscmdrsp *cmdrsp, return; } - sg = scsi_sglist(scsicmd); - for (i = 0; i < scsi_sg_count(scsicmd); i++) { - this_page_orig = kmap_atomic(sg_page(sg + i)); + scsi_for_each_sg(scsicmd, sg, scsi_sg_count(scsicmd), i) { + this_page_orig = kmap_atomic(sg_page(sg)); this_page = (void *)((unsigned long)this_page_orig | - sg[i].offset); - memcpy(this_page, buf + bufind, sg[i].length); + sg->offset); + memcpy(this_page, buf + bufind, sg->length); kunmap_atomic(this_page_orig); } kfree(buf); -- 2.20.1
next prev parent reply index Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-18 1:37 [PATCH V5 00/16] " Ming Lei 2019-06-18 1:37 ` [PATCH V5 01/16] scsi: vmw_pscsi: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 02/16] scsi: advansys: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 03/16] scsi: lpfc: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 04/16] scsi: mvumi: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 05/16] scsi: ipr: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 06/16] scsi: pmcraid: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 07/16] usb: image: microtek: " Ming Lei 2019-06-18 1:37 ` Ming Lei [this message] 2019-06-18 1:37 ` [PATCH V5 09/16] staging: rtsx: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 10/16] s390: zfcp_fc: " Ming Lei 2019-06-24 15:13 ` Steffen Maier 2019-06-25 1:19 ` Ming Lei 2019-06-25 2:01 ` Finn Thain 2019-06-25 2:30 ` Ming Lei 2019-06-25 3:42 ` Finn Thain 2019-06-25 10:51 ` Steffen Maier 2019-06-26 3:07 ` Ming Lei 2019-06-26 8:17 ` Steffen Maier 2019-06-18 1:37 ` [PATCH V5 11/16] scsi: aha152x: " Ming Lei 2019-06-18 3:54 ` Finn Thain 2019-06-18 1:37 ` [PATCH V5 12/16] scsi: imm: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 13/16] scsi: pcmcia: nsp_cs: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 14/16] scsi: ppa: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 15/16] scsi: wd33c93: " Ming Lei 2019-06-18 1:37 ` [PATCH V5 16/16] NCR5380: Support chained sg lists Ming Lei 2019-06-19 0:29 ` [PATCH V5 00/16] use sg helper to operate scatterlist Martin K. Petersen 2019-06-19 19:43 ` Bart Van Assche 2019-06-19 19:55 ` Martin K. Petersen 2019-06-24 12:40 ` Ming Lei 2019-06-24 12:54 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190618013757.22401-9-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=James.Bottomley@HansenPartnership.com \ --cc=bblock@linux.ibm.com \ --cc=brking@us.ibm.com \ --cc=bvanassche@acm.org \ --cc=cavery@redhat.com \ --cc=dan.carpenter@oracle.com \ --cc=devel@driverdev.osuosl.org \ --cc=emilne@redhat.com \ --cc=fischer@norbit.de \ --cc=fthain@telegraphics.com.au \ --cc=gregkh@linuxfoundation.org \ --cc=hare@suse.com \ --cc=hch@lst.de \ --cc=james.smart@broadcom.com \ --cc=jgill@vmware.com \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=schmitzmic@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-USB Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \ linux-usb@vger.kernel.org public-inbox-index linux-usb Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb AGPL code for this site: git clone https://public-inbox.org/public-inbox.git