[balbi-usb:testing/next 2/13] drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?

[balbi-usb:testing/next 2/13] drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/balbi/usb.git testing/next
head:   d06a2c3f683a591efce9d02b2b60ef346df5ae02
commit: 2a714ea6d90d9d1b510ba424652a2e3dfd547267 [2/13] USB: phy: tahvo: convert platform driver to use dev_groups
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 2a714ea6d90d9d1b510ba424652a2e3dfd547267
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?
      .dev_groups = tahvo_groups,
       ^~~~~~~~~~
       groups
>> drivers/usb/phy/phy-tahvo.c:434:17: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
      .dev_groups = tahvo_groups,
                    ^~~~~~~~~~~~
   drivers/usb/phy/phy-tahvo.c:434:17: note: (near initialization for 'tahvo_usb_driver.driver.bus')
   cc1: some warnings being treated as errors

vim +434 drivers/usb/phy/phy-tahvo.c

   428	
   429	static struct platform_driver tahvo_usb_driver = {
   430		.probe		= tahvo_usb_probe,
   431		.remove		= tahvo_usb_remove,
   432		.driver		= {
   433			.name	= "tahvo-usb",
 > 434			.dev_groups = tahvo_groups,
   435		},
   436	};
   437	module_platform_driver(tahvo_usb_driver);
   438	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51784 bytes --]

Re: [balbi-usb:testing/next 2/13] drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?

[Felipe Balbi]

Hi,

kbuild test robot <lkp@intel.com> writes:

> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/balbi/usb.git testing/next
> head:   d06a2c3f683a591efce9d02b2b60ef346df5ae02
> commit: 2a714ea6d90d9d1b510ba424652a2e3dfd547267 [2/13] USB: phy: tahvo: convert platform driver to use dev_groups
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 2a714ea6d90d9d1b510ba424652a2e3dfd547267
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=sh 
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>>> drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?
>       .dev_groups = tahvo_groups,
>        ^~~~~~~~~~


looks like these patches depend on something else that's not upstream
yet. I'll drop the patches from my queue. Greg,if you'd like to add my
ack:

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

cheers

-- 
balbi

Re: [balbi-usb:testing/next 2/13] drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?

[Greg Kroah-Hartman]

On Fri, Aug 09, 2019 at 08:27:52AM +0300, Felipe Balbi wrote:
> 
> Hi,
> 
> kbuild test robot <lkp@intel.com> writes:
> 
> > tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/balbi/usb.git testing/next
> > head:   d06a2c3f683a591efce9d02b2b60ef346df5ae02
> > commit: 2a714ea6d90d9d1b510ba424652a2e3dfd547267 [2/13] USB: phy: tahvo: convert platform driver to use dev_groups
> > config: sh-allmodconfig (attached as .config)
> > compiler: sh4-linux-gcc (GCC) 7.4.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 2a714ea6d90d9d1b510ba424652a2e3dfd547267
> >         # save the attached .config to linux build tree
> >         GCC_VERSION=7.4.0 make.cross ARCH=sh 
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >>> drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?
> >       .dev_groups = tahvo_groups,
> >        ^~~~~~~~~~
> 
> 
> looks like these patches depend on something else that's not upstream
> yet. I'll drop the patches from my queue. Greg,if you'd like to add my
> ack:
> 
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

Thanks, they depend on a patch that is in linux-next and in my tree (and
a few other developer's trees) already.

greg k-h