linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] USB: serial: FTDI: Add device IDs for Sienna and Echelon PL-20
@ 2019-09-04 22:26 beni.mahler
  2019-10-02  9:59 ` Johan Hovold
  0 siblings, 1 reply; 2+ messages in thread
From: beni.mahler @ 2019-09-04 22:26 UTC (permalink / raw)
  To: johan; +Cc: linux-usb, Beni Mahler

From: Beni Mahler <beni.mahler@gmx.net>

Both devices added here have a FTDI chip inside. The device from Echelon
is called 'Network Interface' it is actually a LON network gateway.

 ID 0403:8348 Future Technology Devices International, Ltd
 https://www.eltako.com/fileadmin/downloads/de/datenblatt/Datenblatt_PL-SW-PROF.pdf

 ID 0920:7500 Network Interface
 https://www.echelon.com/products/u20-usb-network-interface

Signed-off-by: Beni Mahler <beni.mahler@gmx.net>
---
 drivers/usb/serial/ftdi_sio.c     | 3 +++
 drivers/usb/serial/ftdi_sio_ids.h | 9 +++++++++
 2 files changed, 12 insertions(+)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 4b3a049561f3..e25352932ba7 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -1030,6 +1030,9 @@ static const struct usb_device_id id_table_combined[] = {
 	/* EZPrototypes devices */
 	{ USB_DEVICE(EZPROTOTYPES_VID, HJELMSLUND_USB485_ISO_PID) },
 	{ USB_DEVICE_INTERFACE_NUMBER(UNJO_VID, UNJO_ISODEBUG_V1_PID, 1) },
+	/* Sienna devices */
+	{ USB_DEVICE(FTDI_VID, FTDI_SIENNA_PID) },
+	{ USB_DEVICE(ECHELON_VID, ECHELON_U20_PID) },
 	{ }					/* Terminating entry */
 };

diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
index f12d806220b4..22d66217cb41 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -39,6 +39,9 @@

 #define FTDI_LUMEL_PD12_PID	0x6002

+/* Sienna Serial Interface by Secyourit GmbH */
+#define FTDI_SIENNA_PID		0x8348
+
 /* Cyber Cortex AV by Fabulous Silicon (http://fabuloussilicon.com) */
 #define CYBER_CORTEX_AV_PID	0x8698

@@ -688,6 +691,12 @@
 #define BANDB_TTL3USB9M_PID	0xAC50
 #define BANDB_ZZ_PROG1_USB_PID	0xBA02

+/*
+ * Echelon USB Serial Interface
+ */
+#define ECHELON_VID		0x0920
+#define ECHELON_U20_PID		0x7500
+
 /*
  * Intrepid Control Systems (http://www.intrepidcs.com/) ValueCAN and NeoVI
  */
--
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] USB: serial: FTDI: Add device IDs for Sienna and Echelon PL-20
  2019-09-04 22:26 [PATCH] USB: serial: FTDI: Add device IDs for Sienna and Echelon PL-20 beni.mahler
@ 2019-10-02  9:59 ` Johan Hovold
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2019-10-02  9:59 UTC (permalink / raw)
  To: beni.mahler; +Cc: johan, linux-usb

On Thu, Sep 05, 2019 at 12:26:20AM +0200, beni.mahler@gmx.net wrote:
> From: Beni Mahler <beni.mahler@gmx.net>
> 
> Both devices added here have a FTDI chip inside. The device from Echelon
> is called 'Network Interface' it is actually a LON network gateway.
> 
>  ID 0403:8348 Future Technology Devices International, Ltd
>  https://www.eltako.com/fileadmin/downloads/de/datenblatt/Datenblatt_PL-SW-PROF.pdf
> 
>  ID 0920:7500 Network Interface
>  https://www.echelon.com/products/u20-usb-network-interface

It wasn't obvious to me that these two are essentially the same product
(?) using different IDs so at first I wondered why you included them in
the same patch.

> Signed-off-by: Beni Mahler <beni.mahler@gmx.net>

Now applied, thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-02  9:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 22:26 [PATCH] USB: serial: FTDI: Add device IDs for Sienna and Echelon PL-20 beni.mahler
2019-10-02  9:59 ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).