Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource()
       [not found] <20191008102751.GA10401@saurav>
@ 2019-10-08 15:05 ` Kevin Hilman
  2019-10-08 17:29   ` Martin Blumenstingl
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2019-10-08 15:05 UTC (permalink / raw)
  To: Saurav Girepunje, balbi, gregkh, linux-usb, linux-arm-kernel,
	linux-amlogic, linux-kernel
  Cc: saurav.girepunje

Saurav Girepunje <saurav.girepunje@gmail.com> writes:

> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together in dwc3_meson_g12a_probe().
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Reviewed-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  drivers/usb/dwc3/dwc3-meson-g12a.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index bca7e92a10e9..d73ccd9e1366 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -386,7 +386,6 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
>  	struct device		*dev = &pdev->dev;
>  	struct device_node	*np = dev->of_node;
>  	void __iomem *base;
> -	struct resource *res;
>  	enum phy_mode otg_id;
>  	int ret, i, irq;
>  
> @@ -394,8 +393,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(dev, res);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base))
>  		return PTR_ERR(base);
>  
> -- 
> 2.20.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource()
  2019-10-08 15:05 ` [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource() Kevin Hilman
@ 2019-10-08 17:29   ` Martin Blumenstingl
  2019-10-08 18:43     ` SAURAV GIREPUNJE
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Blumenstingl @ 2019-10-08 17:29 UTC (permalink / raw)
  To: Saurav Girepunje
  Cc: balbi, Kevin Hilman, gregkh, linux-usb, linux-arm-kernel,
	linux-amlogic, linux-kernel, saurav.girepunje

Hi Saurav,

On Tue, Oct 8, 2019 at 5:06 PM Kevin Hilman <khilman@baylibre.com> wrote:
>
> Saurav Girepunje <saurav.girepunje@gmail.com> writes:
>
> > Use the new helper that wraps the calls to platform_get_resource()
> > and devm_ioremap_resource() together in dwc3_meson_g12a_probe().
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
the following commit is already in mainline:

commit c6e4999cd930b8bd11dd8d4767e871b47f502845
Author: YueHaibing <yuehaibing@huawei.com>
Date:   Fri Aug 2 21:04:08 2019 +0800
   usb: dwc3: meson-g12a: use devm_platform_ioremap_resource() to simplify code


Martin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource()
  2019-10-08 17:29   ` Martin Blumenstingl
@ 2019-10-08 18:43     ` SAURAV GIREPUNJE
  0 siblings, 0 replies; 3+ messages in thread
From: SAURAV GIREPUNJE @ 2019-10-08 18:43 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: balbi, Kevin Hilman, gregkh, linux-usb, saurav.girepunje

On Tue, Oct 08, 2019 at 07:29:28PM +0200, Martin Blumenstingl wrote:
> Hi Saurav,
> 
> On Tue, Oct 8, 2019 at 5:06 PM Kevin Hilman <khilman@baylibre.com> wrote:
> >
> > Saurav Girepunje <saurav.girepunje@gmail.com> writes:
> >
> > > Use the new helper that wraps the calls to platform_get_resource()
> > > and devm_ioremap_resource() together in dwc3_meson_g12a_probe().
> > >
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> the following commit is already in mainline:
> 
> commit c6e4999cd930b8bd11dd8d4767e871b47f502845
> Author: YueHaibing <yuehaibing@huawei.com>
> Date:   Fri Aug 2 21:04:08 2019 +0800
>    usb: dwc3: meson-g12a: use devm_platform_ioremap_resource() to simplify code
> 
> 
> Martin
Ok...Thanks for the information.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191008102751.GA10401@saurav>
2019-10-08 15:05 ` [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource() Kevin Hilman
2019-10-08 17:29   ` Martin Blumenstingl
2019-10-08 18:43     ` SAURAV GIREPUNJE

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org linux-usb@archiver.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/ public-inbox