* [PATCH] usb: typec: fix an IS_ERR() vs NULL bug in hd3ss3220_probe()
@ 2019-10-11 13:35 Dan Carpenter
2019-10-11 13:59 ` Heikki Krogerus
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2019-10-11 13:35 UTC (permalink / raw)
To: Heikki Krogerus, Biju Das; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors
The device_get_named_child_node() function doesn't return error
pointers, it returns NULL on error.
Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/usb/typec/hd3ss3220.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
index 9715600aeb04..37b08f57aac4 100644
--- a/drivers/usb/typec/hd3ss3220.c
+++ b/drivers/usb/typec/hd3ss3220.c
@@ -172,8 +172,8 @@ static int hd3ss3220_probe(struct i2c_client *client,
hd3ss3220_set_source_pref(hd3ss3220,
HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT);
connector = device_get_named_child_node(hd3ss3220->dev, "connector");
- if (IS_ERR(connector))
- return PTR_ERR(connector);
+ if (!connector)
+ return -EIO;
hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
fwnode_handle_put(connector);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: typec: fix an IS_ERR() vs NULL bug in hd3ss3220_probe()
2019-10-11 13:35 [PATCH] usb: typec: fix an IS_ERR() vs NULL bug in hd3ss3220_probe() Dan Carpenter
@ 2019-10-11 13:59 ` Heikki Krogerus
2019-10-11 18:50 ` [PATCH v2] " Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Heikki Krogerus @ 2019-10-11 13:59 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Biju Das, Greg Kroah-Hartman, linux-usb, kernel-janitors
On Fri, Oct 11, 2019 at 04:35:58PM +0300, Dan Carpenter wrote:
> The device_get_named_child_node() function doesn't return error
> pointers, it returns NULL on error.
>
> Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/usb/typec/hd3ss3220.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 9715600aeb04..37b08f57aac4 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -172,8 +172,8 @@ static int hd3ss3220_probe(struct i2c_client *client,
> hd3ss3220_set_source_pref(hd3ss3220,
> HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT);
> connector = device_get_named_child_node(hd3ss3220->dev, "connector");
> - if (IS_ERR(connector))
> - return PTR_ERR(connector);
> + if (!connector)
> + return -EIO;
I think the driver should return -ENODEV if there is no node for the
connector.
thanks,
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] usb: typec: fix an IS_ERR() vs NULL bug in hd3ss3220_probe()
2019-10-11 13:59 ` Heikki Krogerus
@ 2019-10-11 18:50 ` Dan Carpenter
2019-10-14 11:00 ` Heikki Krogerus
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2019-10-11 18:50 UTC (permalink / raw)
To: Heikki Krogerus, Biju Das; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors
The device_get_named_child_node() function doesn't return error
pointers, it returns NULL on error.
Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: remove -ENODEV instead of -EIO
drivers/usb/typec/hd3ss3220.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
index 9715600aeb04..8afaf5768a17 100644
--- a/drivers/usb/typec/hd3ss3220.c
+++ b/drivers/usb/typec/hd3ss3220.c
@@ -172,8 +172,8 @@ static int hd3ss3220_probe(struct i2c_client *client,
hd3ss3220_set_source_pref(hd3ss3220,
HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT);
connector = device_get_named_child_node(hd3ss3220->dev, "connector");
- if (IS_ERR(connector))
- return PTR_ERR(connector);
+ if (!connector)
+ return -ENODEV;
hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
fwnode_handle_put(connector);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: typec: fix an IS_ERR() vs NULL bug in hd3ss3220_probe()
2019-10-11 18:50 ` [PATCH v2] " Dan Carpenter
@ 2019-10-14 11:00 ` Heikki Krogerus
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2019-10-14 11:00 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Biju Das, Greg Kroah-Hartman, linux-usb, kernel-janitors
On Fri, Oct 11, 2019 at 09:50:55PM +0300, Dan Carpenter wrote:
> The device_get_named_child_node() function doesn't return error
> pointers, it returns NULL on error.
>
> Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> v2: remove -ENODEV instead of -EIO
>
> drivers/usb/typec/hd3ss3220.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 9715600aeb04..8afaf5768a17 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -172,8 +172,8 @@ static int hd3ss3220_probe(struct i2c_client *client,
> hd3ss3220_set_source_pref(hd3ss3220,
> HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT);
> connector = device_get_named_child_node(hd3ss3220->dev, "connector");
> - if (IS_ERR(connector))
> - return PTR_ERR(connector);
> + if (!connector)
> + return -ENODEV;
>
> hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
> fwnode_handle_put(connector);
> --
> 2.20.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-14 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11 13:35 [PATCH] usb: typec: fix an IS_ERR() vs NULL bug in hd3ss3220_probe() Dan Carpenter
2019-10-11 13:59 ` Heikki Krogerus
2019-10-11 18:50 ` [PATCH v2] " Dan Carpenter
2019-10-14 11:00 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).