* [PATCH 1/3] usb: usb251xb: Drop some unused defines
@ 2019-10-23 10:52 Uwe Kleine-König
2019-10-23 10:52 ` [PATCH 2/3] usb: usb251xb: Document chip variant usb2422 Uwe Kleine-König
2019-10-23 10:52 ` [PATCH 3/3] usb: usb251xb: Add support for USB2422 Uwe Kleine-König
0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2019-10-23 10:52 UTC (permalink / raw)
To: Richard Leitner, Greg Kroah-Hartman
Cc: Rob Herring, Mark Rutland, linux-usb, devicetree, Carsten Stelling
The five removed symbols are unused since they were introduced in commit
3ec72a2a1e5d ("usb: misc: add USB251xB/xBi Hi-Speed Hub Controller
Driver") back in 2017.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/misc/usb251xb.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 6ca9111d150a..d91ef9cf3623 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -26,10 +26,6 @@
#define USB251XB_ADDR_PRODUCT_ID_LSB 0x02
#define USB251XB_ADDR_PRODUCT_ID_MSB 0x03
-#define USB251XB_DEF_PRODUCT_ID_12 0x2512 /* USB2512B/12Bi */
-#define USB251XB_DEF_PRODUCT_ID_13 0x2513 /* USB2513B/13Bi */
-#define USB251XB_DEF_PRODUCT_ID_14 0x2514 /* USB2514B/14Bi */
-#define USB251XB_DEF_PRODUCT_ID_17 0x2517 /* USB2517/17i */
#define USB251XB_ADDR_DEVICE_ID_LSB 0x04
#define USB251XB_ADDR_DEVICE_ID_MSB 0x05
@@ -74,7 +70,6 @@
#define USB251XB_ADDR_PRODUCT_STRING_LEN 0x14
#define USB251XB_ADDR_PRODUCT_STRING 0x54
-#define USB251XB_DEF_PRODUCT_STRING "USB251xB/xBi/7i"
#define USB251XB_ADDR_SERIAL_STRING_LEN 0x15
#define USB251XB_ADDR_SERIAL_STRING 0x92
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] usb: usb251xb: Document chip variant usb2422
2019-10-23 10:52 [PATCH 1/3] usb: usb251xb: Drop some unused defines Uwe Kleine-König
@ 2019-10-23 10:52 ` Uwe Kleine-König
2019-10-29 18:52 ` Rob Herring
2019-10-23 10:52 ` [PATCH 3/3] usb: usb251xb: Add support for USB2422 Uwe Kleine-König
1 sibling, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2019-10-23 10:52 UTC (permalink / raw)
To: Richard Leitner, Greg Kroah-Hartman
Cc: Rob Herring, Mark Rutland, linux-usb, devicetree, Carsten Stelling
The next patch introduces support for the USB2422. Add it to the list of
devices supported by the binding.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Documentation/devicetree/bindings/usb/usb251xb.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt
index 17915f64b8ee..6e3356dc2e6d 100644
--- a/Documentation/devicetree/bindings/usb/usb251xb.txt
+++ b/Documentation/devicetree/bindings/usb/usb251xb.txt
@@ -7,7 +7,7 @@ Required properties :
- compatible : Should be "microchip,usb251xb" or one of the specific types:
"microchip,usb2512b", "microchip,usb2512bi", "microchip,usb2513b",
"microchip,usb2513bi", "microchip,usb2514b", "microchip,usb2514bi",
- "microchip,usb2517", "microchip,usb2517i"
+ "microchip,usb2517", "microchip,usb2517i", "microchip,usb2422"
- reg : I2C address on the selected bus (default is <0x2C>)
Optional properties :
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] usb: usb251xb: Add support for USB2422
2019-10-23 10:52 [PATCH 1/3] usb: usb251xb: Drop some unused defines Uwe Kleine-König
2019-10-23 10:52 ` [PATCH 2/3] usb: usb251xb: Document chip variant usb2422 Uwe Kleine-König
@ 2019-10-23 10:52 ` Uwe Kleine-König
1 sibling, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2019-10-23 10:52 UTC (permalink / raw)
To: Richard Leitner, Greg Kroah-Hartman
Cc: Rob Herring, Mark Rutland, linux-usb, devicetree, Carsten Stelling
The USB2422 uses a different package that the USB251x and only comes in
a variant with 2 downstream ports. Other than that it is software
compatible.
Tested-by: Carsten Stelling <carsten.stelling@goerlitz.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/misc/usb251xb.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index d91ef9cf3623..7e4e4787f746 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -154,6 +154,14 @@ struct usb251xb_data {
char product_str[USB251XB_STRING_BUFSIZE / 2]; /* ASCII string */
};
+static const struct usb251xb_data usb2422_data = {
+ .product_id = 0x2422,
+ .port_cnt = 2,
+ .led_support = false,
+ .bat_support = true,
+ .product_str = "USB2422",
+};
+
static const struct usb251xb_data usb2512b_data = {
.product_id = 0x2512,
.port_cnt = 2,
@@ -588,6 +596,9 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
static const struct of_device_id usb251xb_of_match[] = {
{
+ .compatible = "microchip,usb2422",
+ .data = &usb2422_data,
+ }, {
.compatible = "microchip,usb2512b",
.data = &usb2512b_data,
}, {
@@ -688,6 +699,7 @@ static int usb251xb_i2c_probe(struct i2c_client *i2c,
}
static const struct i2c_device_id usb251xb_id[] = {
+ { "usb2422", 0 },
{ "usb2512b", 0 },
{ "usb2512bi", 0 },
{ "usb2513b", 0 },
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] usb: usb251xb: Document chip variant usb2422
2019-10-23 10:52 ` [PATCH 2/3] usb: usb251xb: Document chip variant usb2422 Uwe Kleine-König
@ 2019-10-29 18:52 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2019-10-29 18:52 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Richard Leitner, Greg Kroah-Hartman, Mark Rutland, linux-usb,
devicetree, Carsten Stelling
On Wed, 23 Oct 2019 12:52:49 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= wrote:
> The next patch introduces support for the USB2422. Add it to the list of
> devices supported by the binding.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Documentation/devicetree/bindings/usb/usb251xb.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-29 18:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 10:52 [PATCH 1/3] usb: usb251xb: Drop some unused defines Uwe Kleine-König
2019-10-23 10:52 ` [PATCH 2/3] usb: usb251xb: Document chip variant usb2422 Uwe Kleine-König
2019-10-29 18:52 ` Rob Herring
2019-10-23 10:52 ` [PATCH 3/3] usb: usb251xb: Add support for USB2422 Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).