[usb:usb-testing 133/136] drivers/usb/gadget/udc/atmel_usba_udc.c:229:46: error: 'usb_debug_root' undeclared; did you mean 'usb_ep_ops'?

[usb:usb-testing 133/136] drivers/usb/gadget/udc/atmel_usba_udc.c:229:46: error: 'usb_debug_root' undeclared; did you mean 'usb_ep_ops'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
head:   9c54450066cc56b1a47b2472333103569c402d0e
commit: fc05dc6c6ab3619084ef340f53c4a869cb3ea6e6 [133/136] usb: gadget: atmel: create debugfs directory under usb root
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout fc05dc6c6ab3619084ef340f53c4a869cb3ea6e6
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_init_debugfs':
>> drivers/usb/gadget/udc/atmel_usba_udc.c:229:46: error: 'usb_debug_root' undeclared (first use in this function); did you mean 'usb_ep_ops'?
     root = debugfs_create_dir(udc->gadget.name, usb_debug_root);
                                                 ^~~~~~~~~~~~~~
                                                 usb_ep_ops
   drivers/usb/gadget/udc/atmel_usba_udc.c:229:46: note: each undeclared identifier is reported only once for each function it appears in

vim +229 drivers/usb/gadget/udc/atmel_usba_udc.c

   223	
   224	static void usba_init_debugfs(struct usba_udc *udc)
   225	{
   226		struct dentry *root;
   227		struct resource *regs_resource;
   228	
 > 229		root = debugfs_create_dir(udc->gadget.name, usb_debug_root);
   230		udc->debugfs_root = root;
   231	
   232		regs_resource = platform_get_resource(udc->pdev, IORESOURCE_MEM,
   233					CTRL_IOMEM_ID);
   234	
   235		if (regs_resource) {
   236			debugfs_create_file_size("regs", 0400, root, udc,
   237						 &regs_dbg_fops,
   238						 resource_size(regs_resource));
   239		}
   240	
   241		usba_ep_init_debugfs(udc, to_usba_ep(udc->gadget.ep0));
   242	}
   243	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71985 bytes --]

Re: [usb:usb-testing 133/136] drivers/usb/gadget/udc/atmel_usba_udc.c:229:46: error: 'usb_debug_root' undeclared; did you mean 'usb_ep_ops'?

[Greg Kroah-Hartman]

On Thu, Nov 14, 2019 at 04:15:55PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> head:   9c54450066cc56b1a47b2472333103569c402d0e
> commit: fc05dc6c6ab3619084ef340f53c4a869cb3ea6e6 [133/136] usb: gadget: atmel: create debugfs directory under usb root
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout fc05dc6c6ab3619084ef340f53c4a869cb3ea6e6
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=arm 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_init_debugfs':
> >> drivers/usb/gadget/udc/atmel_usba_udc.c:229:46: error: 'usb_debug_root' undeclared (first use in this function); did you mean 'usb_ep_ops'?
>      root = debugfs_create_dir(udc->gadget.name, usb_debug_root);
>                                                  ^~~~~~~~~~~~~~
>                                                  usb_ep_ops
>    drivers/usb/gadget/udc/atmel_usba_udc.c:229:46: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +229 drivers/usb/gadget/udc/atmel_usba_udc.c
> 
>    223	
>    224	static void usba_init_debugfs(struct usba_udc *udc)
>    225	{
>    226		struct dentry *root;
>    227		struct resource *regs_resource;
>    228	
>  > 229		root = debugfs_create_dir(udc->gadget.name, usb_debug_root);
>    230		udc->debugfs_root = root;
>    231	
>    232		regs_resource = platform_get_resource(udc->pdev, IORESOURCE_MEM,
>    233					CTRL_IOMEM_ID);
>    234	
>    235		if (regs_resource) {
>    236			debugfs_create_file_size("regs", 0400, root, udc,
>    237						 &regs_dbg_fops,
>    238						 resource_size(regs_resource));
>    239		}
>    240	
>    241		usba_ep_init_debugfs(udc, to_usba_ep(udc->gadget.ep0));
>    242	}
>    243	
> 

I will go drop this patch from my tree too.  Please fix it up and
resend.

thanks,

greg k-h