* [PATCH net] ax88179_178a: add ethtool_op_get_ts_info()
@ 2019-11-23 21:04 Andreas K. Besslein
2019-11-25 2:41 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Andreas K. Besslein @ 2019-11-23 21:04 UTC (permalink / raw)
To: netdev; +Cc: linux-usb, oneukum, davem
This enables the use of SW timestamping.
ax88179_178a uses the usbnet transmit function usbnet_start_xmit() which
implements software timestamping. ax88179_178a overrides ethtool_ops but
missed to set .get_ts_info. This caused SOF_TIMESTAMPING_TX_SOFTWARE
capapility to be not available.
Signed-off-by: Andreas K. Besslein <besslein.andreas@gmail.com>
---
drivers/net/usb/ax88179_178a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index daa54486ab09..8bc44c3f7c45 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -827,6 +827,7 @@ static const struct ethtool_ops ax88179_ethtool_ops = {
.nway_reset = usbnet_nway_reset,
.get_link_ksettings = ax88179_get_link_ksettings,
.set_link_ksettings = ax88179_set_link_ksettings,
+ .get_ts_info = ethtool_op_get_ts_info,
};
static void ax88179_set_multicast(struct net_device *net)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] ax88179_178a: add ethtool_op_get_ts_info()
2019-11-23 21:04 [PATCH net] ax88179_178a: add ethtool_op_get_ts_info() Andreas K. Besslein
@ 2019-11-25 2:41 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2019-11-25 2:41 UTC (permalink / raw)
To: Andreas K. Besslein; +Cc: netdev, linux-usb, oneukum, davem
On Sat, 23 Nov 2019 22:04:47 +0100, Andreas K. Besslein wrote:
> This enables the use of SW timestamping.
>
> ax88179_178a uses the usbnet transmit function usbnet_start_xmit() which
> implements software timestamping. ax88179_178a overrides ethtool_ops but
> missed to set .get_ts_info. This caused SOF_TIMESTAMPING_TX_SOFTWARE
> capapility to be not available.
>
> Signed-off-by: Andreas K. Besslein <besslein.andreas@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-25 2:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-23 21:04 [PATCH net] ax88179_178a: add ethtool_op_get_ts_info() Andreas K. Besslein
2019-11-25 2:41 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).