From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Wen Yang <wenyang@linux.alibaba.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: fix use after free in typec_register_port()
Date: Tue, 26 Nov 2019 17:46:54 +0200 [thread overview]
Message-ID: <20191126154654.GA6428@kuha.fi.intel.com> (raw)
In-Reply-To: <20191126140452.14048-1-wenyang@linux.alibaba.com>
On Tue, Nov 26, 2019 at 10:04:52PM +0800, Wen Yang wrote:
> We can't use "port->sw" and/or "port->mux" after it has been freed.
>
> Fixes: 23481121c81d ("usb: typec: class: Don't use port parent for getting mux handles")
> Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/usb/typec/class.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 7ece6ca..91d6227 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1612,14 +1612,16 @@ struct typec_port *typec_register_port(struct device *parent,
>
> port->sw = typec_switch_get(&port->dev);
> if (IS_ERR(port->sw)) {
> + ret = PTR_ERR(port->sw);
> put_device(&port->dev);
> - return ERR_CAST(port->sw);
> + return ERR_PTR(ret);
> }
>
> port->mux = typec_mux_get(&port->dev, NULL);
> if (IS_ERR(port->mux)) {
> + ret = PTR_ERR(port->mux);
> put_device(&port->dev);
> - return ERR_CAST(port->mux);
> + return ERR_PTR(ret);
> }
>
> ret = device_add(&port->dev);
> --
> 1.8.3.1
thanks,
--
heikki
prev parent reply other threads:[~2019-11-26 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 14:04 [PATCH] usb: typec: fix use after free in typec_register_port() Wen Yang
2019-11-26 15:46 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126154654.GA6428@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wenyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).