Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v4 0/2] usb: override hub device bInterval with device
@ 2019-12-03 10:15 Ikjoon Jang
  2019-12-03 16:40 ` Johan Hovold
  0 siblings, 1 reply; 3+ messages in thread
From: Ikjoon Jang @ 2019-12-03 10:15 UTC (permalink / raw)
  To: linux-usb, devicetree
  Cc: GregKroah-Hartman, RobHerring, MarkRutland, AlanStern, SuwanKim,
	GustavoA . R . Silva, IkjoonJang, JohanHovold, linux-kernel,
	drinkcat

This patchset enables hard wired hub device to use different bInterval
from its descriptor when the hub has a combined device node.

When we know reducing autosuspend delay for built-in HIDs is better for
power saving, we can reduce it to the optimal value. But if a parent hub
has a long bInterval, mouse lags a lot from more frequent autosuspend.
So this enables overriding bInterval for a hard wired hub device only
when we know that reduces the power consumption.

Changes in v4
- use of_property_read_u32() instead of of_property_read_u8()

Ikjoon Jang (2):
  dt-bindings: usb: add "hub,interval" property
  usb: overridable hub bInterval by device node

 Documentation/devicetree/bindings/usb/usb-device.txt | 4 ++++
 drivers/usb/core/config.c                            | 9 +++++++++
 2 files changed, 13 insertions(+)

-- 
2.24.0.393.g34dc348eaf-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4 0/2] usb: override hub device bInterval with device
  2019-12-03 10:15 [PATCH v4 0/2] usb: override hub device bInterval with device Ikjoon Jang
@ 2019-12-03 16:40 ` Johan Hovold
  2019-12-04  2:46   ` Ikjoon Jang
  0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2019-12-03 16:40 UTC (permalink / raw)
  To: Ikjoon Jang
  Cc: linux-usb, devicetree, GregKroah-Hartman, RobHerring,
	MarkRutland, AlanStern, SuwanKim, GustavoA . R . Silva,
	JohanHovold, linux-kernel, drinkcat

On Tue, Dec 03, 2019 at 06:15:21PM +0800, Ikjoon Jang wrote:
> This patchset enables hard wired hub device to use different bInterval
> from its descriptor when the hub has a combined device node.
> 
> When we know reducing autosuspend delay for built-in HIDs is better for
> power saving, we can reduce it to the optimal value. But if a parent hub
> has a long bInterval, mouse lags a lot from more frequent autosuspend.
> So this enables overriding bInterval for a hard wired hub device only
> when we know that reduces the power consumption.
> 
> Changes in v4
> - use of_property_read_u32() instead of of_property_read_u8()

What changed in the previous versions?

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4 0/2] usb: override hub device bInterval with device
  2019-12-03 16:40 ` Johan Hovold
@ 2019-12-04  2:46   ` Ikjoon Jang
  0 siblings, 0 replies; 3+ messages in thread
From: Ikjoon Jang @ 2019-12-04  2:46 UTC (permalink / raw)
  To: Johan Hovold
  Cc: linux-usb, devicetree, GregKroah-Hartman, RobHerring,
	MarkRutland, AlanStern, SuwanKim, GustavoA . R . Silva,
	linux-kernel, Nicolas Boichat

On Wed, Dec 4, 2019 at 12:40 AM Johan Hovold <johan@kernel.org> wrote:
>
> On Tue, Dec 03, 2019 at 06:15:21PM +0800, Ikjoon Jang wrote:
> > This patchset enables hard wired hub device to use different bInterval
> > from its descriptor when the hub has a combined device node.
> >
> > When we know reducing autosuspend delay for built-in HIDs is better for
> > power saving, we can reduce it to the optimal value. But if a parent hub
> > has a long bInterval, mouse lags a lot from more frequent autosuspend.
> > So this enables overriding bInterval for a hard wired hub device only
> > when we know that reduces the power consumption.
> >
> > Changes in v4
> > - use of_property_read_u32() instead of of_property_read_u8()
>
> What changed in the previous versions?

changes in the previous versions:
v4: use of_property_read_u32() instead of of_property_read_u8()
v3: errata fixed "hub, interval" --> "hub,interval"
v2: do not use unlikely() macro, commit message

>
> Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 10:15 [PATCH v4 0/2] usb: override hub device bInterval with device Ikjoon Jang
2019-12-03 16:40 ` Johan Hovold
2019-12-04  2:46   ` Ikjoon Jang

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git