linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Ajay Gupta <ajaykuee@gmail.com>
Cc: linux-usb@vger.kernel.org, Ajay Gupta <ajayg@nvidia.com>
Subject: Re: [PATCH v6] usb: typec: ucsi: add support for separate DP altmode devices
Date: Thu, 12 Dec 2019 15:44:12 +0200	[thread overview]
Message-ID: <20191212134412.GF31345@kuha.fi.intel.com> (raw)
In-Reply-To: <20191123004347.5127-1-ajayg@nvidia.com>

Hi Ajay,

On Fri, Nov 22, 2019 at 04:43:47PM -0800, Ajay Gupta wrote:
> From: Ajay Gupta <ajayg@nvidia.com>
> 
> CCGx controller used on NVIDIA GPU card has two separate display
> altmode for two DP pin assignments. UCSI specification doesn't
> prohibits using separate display altmode.
> 
> Current UCSI Type-C framework expects only one display altmode for
> all DP pin assignment. This patch squashes two separate display
> altmode into single altmode to support controllers with separate
> display altmode. We first read all the alternate modes of connector
> and then run through it to know if there are separate display
> altmodes. If so, it prepares a new port altmode set after squashing
> two or more separate altmodes into one.

I didn't see any major issues with this. There were still few extra
spaces etc., but I can clean those. Maybe it would have been good to
mention in the commit message that the reason why we need those two
separate alt modes, for what is in reality two separate pin
configurations, is limitations in UCSI specification, but never mind.

I still don't like the approach, but since I'm unable to explain my
idea, or have time to write something for this myself, I don't want
block this any longer. It does not add that much code, so once I have
time, I can always try to improve it myself, right?

Otherwise it's OK by me. I'll queue it up.

thanks,

-- 
heikki

  parent reply	other threads:[~2019-12-12 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23  0:43 [PATCH v6] usb: typec: ucsi: add support for separate DP altmode devices Ajay Gupta
2019-12-03 17:45 ` Ajay Gupta
2019-12-04 16:02   ` Heikki Krogerus
2019-12-12 13:44 ` Heikki Krogerus [this message]
2019-12-12 17:42   ` Ajay Gupta
2019-12-13 12:37     ` Heikki Krogerus
2019-12-16 22:49       ` Ajay Gupta
2019-12-17  9:21         ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212134412.GF31345@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=ajayg@nvidia.com \
    --cc=ajaykuee@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).