* [PATCH] usb: musb/ux500: Use dma_request_chan() instead dma_request_slave_channel()
@ 2019-12-17 11:00 Peter Ujfalusi
2019-12-17 18:51 ` Bin Liu
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2019-12-17 11:00 UTC (permalink / raw)
To: b-liu, gregkh; +Cc: vkoul, linux-usb, linux-kernel
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/usb/musb/ux500_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c
index d19bb3e89da6..d5cf5e8bb1ca 100644
--- a/drivers/usb/musb/ux500_dma.c
+++ b/drivers/usb/musb/ux500_dma.c
@@ -310,9 +310,9 @@ static int ux500_dma_controller_start(struct ux500_dma_controller *controller)
dma_channel->max_len = SZ_16M;
ux500_channel->dma_chan =
- dma_request_slave_channel(dev, chan_names[ch_num]);
+ dma_request_chan(dev, chan_names[ch_num]);
- if (!ux500_channel->dma_chan)
+ if (IS_ERR(ux500_channel->dma_chan))
ux500_channel->dma_chan =
dma_request_channel(mask,
data ?
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: musb/ux500: Use dma_request_chan() instead dma_request_slave_channel()
2019-12-17 11:00 [PATCH] usb: musb/ux500: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
@ 2019-12-17 18:51 ` Bin Liu
0 siblings, 0 replies; 2+ messages in thread
From: Bin Liu @ 2019-12-17 18:51 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: gregkh, vkoul, linux-usb, linux-kernel
On Tue, Dec 17, 2019 at 01:00:30PM +0200, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
Applied. Thanks.
-Bin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-17 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 11:00 [PATCH] usb: musb/ux500: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2019-12-17 18:51 ` Bin Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).