* [PATCH] USB: serial: cp210x: Enables usb generic functions for throttle/unthrottle to prevent USB data loss.
@ 2019-12-18 18:55 Brant Merryman
2020-01-07 10:32 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Brant Merryman @ 2019-12-18 18:55 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel
Cc: Brant Merryman, Richard Hendricks
USB: serial: cp210x: Enables usb generic functions for
throttle/unthrottle to prevent USB data loss.
Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
---
drivers/usb/serial/cp210x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f5143eedbc48..bcceb4ad8be0 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -272,6 +272,8 @@ static struct usb_serial_driver cp210x_device = {
.break_ctl = cp210x_break_ctl,
.set_termios = cp210x_set_termios,
.tx_empty = cp210x_tx_empty,
+ .throttle = usb_serial_generic_throttle,
+ .unthrottle = usb_serial_generic_unthrottle,
.tiocmget = cp210x_tiocmget,
.tiocmset = cp210x_tiocmset,
.attach = cp210x_attach,
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] USB: serial: cp210x: Enables usb generic functions for throttle/unthrottle to prevent USB data loss.
2019-12-18 18:55 [PATCH] USB: serial: cp210x: Enables usb generic functions for throttle/unthrottle to prevent USB data loss Brant Merryman
@ 2020-01-07 10:32 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2020-01-07 10:32 UTC (permalink / raw)
To: Brant Merryman
Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel,
Richard Hendricks
On Wed, Dec 18, 2019 at 06:55:04PM +0000, Brant Merryman wrote:
> USB: serial: cp210x: Enables usb generic functions for
> throttle/unthrottle to prevent USB data loss.
Please resubmit this with a short summary (Subject, < 80 chars) and
separate commit message (body). Try to explain why this is needed a bit
more verbosely.
> Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
> ---
Also always include a changelog here (after "---") when you update
patches, and indicate the patch revision in the Subject prefix (e.g.
this should have been "[PATCH v2]".
Since the two patches you sent are related, you should submit them in a
series. Take a look at git-format-patch and git-send-email for one way
of doing that, more details can be found in:
Documentation/process/submitting-patches.rst
Let's get you up to speed on the process now, so that we don't have to
deal with that bit for your future contributions.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-07 10:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 18:55 [PATCH] USB: serial: cp210x: Enables usb generic functions for throttle/unthrottle to prevent USB data loss Brant Merryman
2020-01-07 10:32 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).