From: Rob Herring <robh@kernel.org>
To: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
John Youn <John.Youn@synopsys.com>
Subject: Re: [RFC PATCH 4/4] dt-bindings: usb: Add snps,consolidate-trbs & consolidate-trbs
Date: Wed, 8 Jan 2020 09:19:48 -0600 [thread overview]
Message-ID: <20200108151948.GA24992@bogus> (raw)
In-Reply-To: <2450178afa4e09b315402c64224b44b542363fc7.1576848504.git.joglekar@synopsys.com>
On Fri, Dec 20, 2019 at 07:10:24PM +0530, Tejas Joglekar wrote:
> This commit adds the documentation for consolidate-trbs, and
> snps,consolidate-trbs property. These when set enables the quirk for
> XHCI driver for consolidation of TRB's when small buffer sizes are
> scattered over the TRB cache not making up to MPS or total transfer size
> with Synopsys xHC.
>
> Signed-off-by: Tejas Joglekar <joglekar@synopsys.com>
> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 6 ++++++
> Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 66780a47ad85..9851da41a442 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,12 @@ Optional properties:
> this and tx-thr-num-pkt-prd to a valid, non-zero value
> 1-16 (DWC_usb31 programming guide section 1.2.3) to
> enable periodic ESS TX threshold.
> + - snps,consolidate-trbs: enable TRBs consolidation - host mode only. Set this
> + to valid then for Synopsys xHC the TRBs would be
> + consolidated to at least MPS in order to prevent the
> + controller getting hang due to small buffer sizes which
> + does not make up to MPS size or total transfer size
> + across TRB cache.
Why not just always enable this?
Otherwise, this should be implied by the compatible string.
>
> - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.
> - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index 3f378951d624..be8d5e6a6333 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -43,6 +43,7 @@ Optional properties:
> - quirk-broken-port-ped: set if the controller has broken port disable mechanism
> - imod-interval-ns: default interrupt moderation interval is 5000ns
> - phys : see usb-hcd.yaml in the current directory
> + - consolidate-trbs: indicate if you need to consolidate trbs
>
> additionally the properties from usb-hcd.yaml (in the current directory) are
> supported.
> --
> 2.11.0
>
prev parent reply other threads:[~2020-01-08 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 13:38 [RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC Tejas Joglekar
2019-12-20 13:39 ` [RFC PATCH 1/4] usb: xhci: Synopsys xHC consolidate TRBs Tejas Joglekar
2020-01-02 9:08 ` David Laight
2020-01-03 16:44 ` Mathias Nyman
2020-02-07 17:17 ` Tejas Joglekar
2020-02-12 15:04 ` Mathias Nyman
2020-02-14 8:36 ` Tejas Joglekar
2020-03-03 10:24 ` Tejas Joglekar
2020-03-03 14:47 ` Mathias Nyman
2020-03-16 17:09 ` Tejas Joglekar
2020-03-17 8:48 ` Mathias Nyman
2019-12-20 13:39 ` [RFC PATCH 2/4] usb: dwc3: Add device property consolidate-trbs Tejas Joglekar
2019-12-20 13:40 ` [RFC PATCH 3/4] usb: xhci: Set quirk for XHCI_CONSOLIDATE_TRBS Tejas Joglekar
2019-12-20 13:40 ` [RFC PATCH 4/4] dt-bindings: usb: Add snps,consolidate-trbs & consolidate-trbs Tejas Joglekar
2020-01-08 15:19 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108151948.GA24992@bogus \
--to=robh@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Tejas.Joglekar@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).