From: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Mark Rutland <mark.rutland@arm.com>
Cc: John Youn <John.Youn@synopsys.com>
Subject: [RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC
Date: Fri, 20 Dec 2019 19:08:46 +0530 [thread overview]
Message-ID: <cover.1576848504.git.joglekar@synopsys.com> (raw)
The Synopsys xHC has an internal TRB cache of size TRB_CACHE_SIZE for
each endpoint. The default value for TRB_CACHE_SIZE is 16 for SS and 8
for HS. The controller loads and updates the TRB cache from the
transfer ring in system memory whenever the driver issues a start
transfer or update transfer command.
For chained TRBs, the Synopsys xHC requires that the total amount of
bytes for all TRBs loaded in the TRB cache be greater than or equal to
1 MPS. Or the chain ends within the TRB cache (with a last TRB).
If this requirement is not met, the controller will not be able to
send or receive a packet and it will hang causing a driver timeout and
error.
This patch set adds logic to the XHCI driver to detect and prevent this
from happening along with the quirk to enable this logic for Synopsys
HAPS platform.
Tejas Joglekar (4):
usb: xhci: Synopsys xHC consolidate TRBs
usb: dwc3: Add device property consolidate-trbs
usb: xhci: Set quirk for XHCI_CONSOLIDATE_TRBS
dt-bindings: usb: Add snps,consolidate-trbs & consolidate-trbs
Documentation/devicetree/bindings/usb/dwc3.txt | 6 +
Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
drivers/usb/dwc3/core.c | 2 +
drivers/usb/dwc3/core.h | 2 +
drivers/usb/dwc3/dwc3-haps.c | 1 +
drivers/usb/dwc3/host.c | 3 +
drivers/usb/host/xhci-pci.c | 3 +
drivers/usb/host/xhci-plat.c | 3 +
drivers/usb/host/xhci-ring.c | 278 ++++++++++++++++++++-
drivers/usb/host/xhci.c | 3 +
drivers/usb/host/xhci.h | 23 ++
11 files changed, 317 insertions(+), 8 deletions(-)
--
2.11.0
next reply other threads:[~2019-12-20 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 13:38 Tejas Joglekar [this message]
2019-12-20 13:39 ` [RFC PATCH 1/4] usb: xhci: Synopsys xHC consolidate TRBs Tejas Joglekar
2020-01-02 9:08 ` David Laight
2020-01-03 16:44 ` Mathias Nyman
2020-02-07 17:17 ` Tejas Joglekar
2020-02-12 15:04 ` Mathias Nyman
2020-02-14 8:36 ` Tejas Joglekar
2020-03-03 10:24 ` Tejas Joglekar
2020-03-03 14:47 ` Mathias Nyman
2020-03-16 17:09 ` Tejas Joglekar
2020-03-17 8:48 ` Mathias Nyman
2019-12-20 13:39 ` [RFC PATCH 2/4] usb: dwc3: Add device property consolidate-trbs Tejas Joglekar
2019-12-20 13:40 ` [RFC PATCH 3/4] usb: xhci: Set quirk for XHCI_CONSOLIDATE_TRBS Tejas Joglekar
2019-12-20 13:40 ` [RFC PATCH 4/4] dt-bindings: usb: Add snps,consolidate-trbs & consolidate-trbs Tejas Joglekar
2020-01-08 15:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1576848504.git.joglekar@synopsys.com \
--to=tejas.joglekar@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).