linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Felipe Balbi <balbi@kernel.org>
Subject: Re: No message is showed after USB gadget has configured
Date: Mon, 20 Jan 2020 11:48:01 +0100	[thread overview]
Message-ID: <20200120104801.GA421434@kroah.com> (raw)
In-Reply-To: <VI1PR04MB53272657D56EE193CEB29CC68B320@VI1PR04MB5327.eurprd04.prod.outlook.com>

On Mon, Jan 20, 2020 at 09:48:24AM +0000, Peter Chen wrote:
>  
> > On Mon, Jan 20, 2020 at 09:03:59AM +0000, Peter Chen wrote:
> > > Hi all,
> > >
> > > >From commit 1cbfb8c4f62d ("usb: gadget: Quieten gadget config
> > > >message"),
> > > there is no any message from gadget side after it connects to host and
> > > works correctly. Although we could cat "state" under
> > > /sys/class/udc/$CONTROLLER/ to know its state, we can't easily know if
> > > the gadget works or not from console, USB host could have many
> > > messages after one device has connected, why we can't keep one for USB
> > > gadget?
> > 
> > Why not make "normal" USB devices quieter too? :)
> > 
> > Surely you do not have tools that watch syslog to determine if a device is working
> > properly or not, right?  That's what sysfs is for, not syslog entries.
> > 
> 
> Yes, we use our eyes during the hot plug test for device or count the number of
> messages for it, with this change, it may cause difficult for hot plug test. For
> other tests, we could judge sysfs before later tests.
> 
> Since this message in there many years, we (and tester) may need time to adapt for
> this change.

Can you just turn on dynamic debugging for that one line with a simple
echo to the debugfs file so that you still see this in your test
framework?

thanks,

greg k-h

  reply	other threads:[~2020-01-20 10:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  9:03 No message is showed after USB gadget has configured Peter Chen
2020-01-20  9:29 ` Greg Kroah-Hartman
2020-01-20  9:48   ` Peter Chen
2020-01-20 10:48     ` Greg Kroah-Hartman [this message]
2020-01-21  2:04       ` Peter Chen
2020-01-21 12:08         ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200120104801.GA421434@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).