linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Al Cooper <alcooperx@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Arnd Bergmann <arnd@arndb.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Johan Hovold <johan@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-usb@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
Date: Fri, 13 Mar 2020 16:58:46 +0200	[thread overview]
Message-ID: <20200313145846.GU1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200313141545.31943-3-alcooperx@gmail.com>

On Fri, Mar 13, 2020 at 10:15:43AM -0400, Al Cooper wrote:
> Add support for Broadcom STB SoC's to the xhci platform driver

...

>  #include "xhci-plat.h"
>  #include "xhci-mvebu.h"
>  #include "xhci-rcar.h"
> +#include "xhci-brcm.h"

Perhaps put it in order, i.e. after xhci-plat.h?

...

> +static const struct xhci_plat_priv xhci_plat_brcm = {
> +	.init_quirk = xhci_plat_brcm_init_quirk

Add comma at the end, it might help to reduce burden on update.

> +};

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-03-13 14:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 14:15 [PATCH 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Al Cooper
2020-03-13 14:15 ` [PATCH 1/4] dt-bindings: Add Broadcom STB USB support Al Cooper
2020-03-13 22:02   ` Rob Herring
2020-03-27 20:25     ` Al Cooper
2020-03-13 14:15 ` [PATCH 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's Al Cooper
2020-03-13 14:58   ` Andy Shevchenko [this message]
2020-03-13 14:15 ` [PATCH 3/4] usb: ehci: Add new EHCI driver " Al Cooper
2020-03-13 15:08   ` Andy Shevchenko
2020-03-27 20:27     ` Al Cooper
2020-03-17 18:48   ` Greg Kroah-Hartman
2020-03-27 20:28     ` Al Cooper
2020-03-13 14:15 ` [PATCH 4/4] usb: host: Add ability to build new Broadcom STB USB drivers Al Cooper
2020-03-13 15:10   ` Andy Shevchenko
2020-03-13 16:18 ` [PATCH 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Andy Shevchenko
2020-03-27 20:22   ` Al Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313145846.GU1922688@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alcooperx@gmail.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathias.nyman@intel.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).