* [PATCH 1/3] usb: chipidea: udc: fix the kernel doc for udc.h
@ 2020-03-26 10:43 Peter Chen
2020-03-26 10:43 ` [PATCH 2/3] usb: chipidea: core: refine the description for this driver Peter Chen
2020-03-26 10:43 ` [PATCH 3/3] usb: chipidea: core: show the real pointer value for register Peter Chen
0 siblings, 2 replies; 3+ messages in thread
From: Peter Chen @ 2020-03-26 10:43 UTC (permalink / raw)
To: linux-usb; +Cc: linux-imx, jun.li, Peter Chen
From: Peter Chen <peter.chen@nxp.com>
The kernel doc for td_node is outdated, update it.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/chipidea/udc.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/chipidea/udc.h b/drivers/usb/chipidea/udc.h
index ebb11b625bb8..32b56f84f77a 100644
--- a/drivers/usb/chipidea/udc.h
+++ b/drivers/usb/chipidea/udc.h
@@ -67,10 +67,7 @@ struct td_node {
* struct ci_hw_req - usb request representation
* @req: request structure for gadget drivers
* @queue: link to QH list
- * @ptr: transfer descriptor for this request
- * @dma: dma address for the transfer descriptor
- * @zptr: transfer descriptor for the zero packet
- * @zdma: dma address of the zero packet's transfer descriptor
+ * @tds: link to TD list
*/
struct ci_hw_req {
struct usb_request req;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] usb: chipidea: core: refine the description for this driver
2020-03-26 10:43 [PATCH 1/3] usb: chipidea: udc: fix the kernel doc for udc.h Peter Chen
@ 2020-03-26 10:43 ` Peter Chen
2020-03-26 10:43 ` [PATCH 3/3] usb: chipidea: core: show the real pointer value for register Peter Chen
1 sibling, 0 replies; 3+ messages in thread
From: Peter Chen @ 2020-03-26 10:43 UTC (permalink / raw)
To: linux-usb; +Cc: linux-imx, jun.li, Peter Chen
From: Peter Chen <peter.chen@nxp.com>
Some descriptions are outdated, update them.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/chipidea/core.c | 40 +++++++------------------------------
1 file changed, 7 insertions(+), 33 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index ae0bdc036464..12971c96c19e 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -3,42 +3,16 @@
* core.c - ChipIdea USB IP core family device controller
*
* Copyright (C) 2008 Chipidea - MIPS Technologies, Inc. All rights reserved.
+ * Copyright (C) 2020 NXP
*
* Author: David Lopo
- */
-
-/*
- * Description: ChipIdea USB IP core family device controller
- *
- * This driver is composed of several blocks:
- * - HW: hardware interface
- * - DBG: debug facilities (optional)
- * - UTIL: utilities
- * - ISR: interrupts handling
- * - ENDPT: endpoint operations (Gadget API)
- * - GADGET: gadget operations (Gadget API)
- * - BUS: bus glue code, bus abstraction layer
- *
- * Compile Options
- * - STALL_IN: non-empty bulk-in pipes cannot be halted
- * if defined mass storage compliance succeeds but with warnings
- * => case 4: Hi > Dn
- * => case 5: Hi > Di
- * => case 8: Hi <> Do
- * if undefined usbtest 13 fails
- * - TRACE: enable function tracing (depends on DEBUG)
- *
- * Main Features
- * - Chapter 9 & Mass Storage Compliance with Gadget File Storage
- * - Chapter 9 Compliance with Gadget Zero (STALL_IN undefined)
- * - Normal & LPM support
- *
- * USBTEST Report
- * - OK: 0-12, 13 (STALL_IN defined) & 14
- * - Not Supported: 15 & 16 (ISO)
+ * Peter Chen <peter.chen@nxp.com>
*
- * TODO List
- * - Suspend & Remote Wakeup
+ * Main Features:
+ * - Four transfers are supported, usbtest is passed
+ * - USB Certification for gadget: CH9 and Mass Storage are passed
+ * - Low power mode
+ * - USB wakeup
*/
#include <linux/delay.h>
#include <linux/device.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] usb: chipidea: core: show the real pointer value for register
2020-03-26 10:43 [PATCH 1/3] usb: chipidea: udc: fix the kernel doc for udc.h Peter Chen
2020-03-26 10:43 ` [PATCH 2/3] usb: chipidea: core: refine the description for this driver Peter Chen
@ 2020-03-26 10:43 ` Peter Chen
1 sibling, 0 replies; 3+ messages in thread
From: Peter Chen @ 2020-03-26 10:43 UTC (permalink / raw)
To: linux-usb; +Cc: linux-imx, jun.li, Peter Chen
From: Peter Chen <peter.chen@nxp.com>
The pointer value is "ptrval" like below at current code:
ci_hdrc ci_hdrc.0: ChipIdea HDRC found, revision: 25, lpm: 0;
cap: (ptrval) op: (ptrval)
According to Documentation/core-api/printk-formats.rst, we change
it from %p to %px for real value.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/chipidea/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 12971c96c19e..ea8ac4a54a8d 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -246,7 +246,7 @@ static int hw_device_init(struct ci_hdrc *ci, void __iomem *base)
ci->rev = ci_get_revision(ci);
dev_dbg(ci->dev,
- "ChipIdea HDRC found, revision: %d, lpm: %d; cap: %p op: %p\n",
+ "revision: %d, lpm: %d; cap: %px op: %px\n",
ci->rev, ci->hw_bank.lpm, ci->hw_bank.cap, ci->hw_bank.op);
/* setup lock mode ? */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-26 10:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 10:43 [PATCH 1/3] usb: chipidea: udc: fix the kernel doc for udc.h Peter Chen
2020-03-26 10:43 ` [PATCH 2/3] usb: chipidea: core: refine the description for this driver Peter Chen
2020-03-26 10:43 ` [PATCH 3/3] usb: chipidea: core: show the real pointer value for register Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).