Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* question on tty_operations->flush_char()
@ 2020-05-19 15:39 Oliver Neukum
  2020-05-20  5:35 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Oliver Neukum @ 2020-05-19 15:39 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-usb

Hi,

is the flush_char() opertion of tty_operations allowed to sleep?

	Regards
		Oliver


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: question on tty_operations->flush_char()
  2020-05-19 15:39 question on tty_operations->flush_char() Oliver Neukum
@ 2020-05-20  5:35 ` Greg KH
  2020-05-20  6:42   ` Johan Hovold
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-05-20  5:35 UTC (permalink / raw)
  To: Oliver Neukum; +Cc: Johan Hovold, linux-usb

On Tue, May 19, 2020 at 05:39:49PM +0200, Oliver Neukum wrote:
> Hi,
> 
> is the flush_char() opertion of tty_operations allowed to sleep?

"flush_chars"?

I am pretty sure, given that the caller locations of it sleep before
they call it.  I thought I documented stuff like that a long time ago,
maybe not :(

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: question on tty_operations->flush_char()
  2020-05-20  5:35 ` Greg KH
@ 2020-05-20  6:42   ` Johan Hovold
  0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2020-05-20  6:42 UTC (permalink / raw)
  To: Greg KH; +Cc: Oliver Neukum, Johan Hovold, linux-usb

On Wed, May 20, 2020 at 07:35:49AM +0200, Greg Kroah-Hartman wrote:
> On Tue, May 19, 2020 at 05:39:49PM +0200, Oliver Neukum wrote:
> > Hi,
> > 
> > is the flush_char() opertion of tty_operations allowed to sleep?
> 
> "flush_chars"?
> 
> I am pretty sure, given that the caller locations of it sleep before
> they call it.  I thought I documented stuff like that a long time ago,
> maybe not :(

I agree, I don't see why that wouldn't be allowed currently.

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 15:39 question on tty_operations->flush_char() Oliver Neukum
2020-05-20  5:35 ` Greg KH
2020-05-20  6:42   ` Johan Hovold

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git