* [PATCH] drivers: usb: core: driver: fixed 80 line character length issue
@ 2020-05-31 1:50 Lokesh Chebrolu
2020-05-31 6:41 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Lokesh Chebrolu @ 2020-05-31 1:50 UTC (permalink / raw)
To: gregkh; +Cc: hadess, stern, linux-usb, linux-kernel, lokeshch007
From: lokeshch007 <lokeshch007@gmail.com>
Fixed a coding style issue
Signed-off-by: Lokesh Chebrolu <lokeshch007@gmail.com>
---
drivers/usb/core/driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index f81606c..83c3287 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -1796,7 +1796,9 @@ int usb_autopm_get_interface_async(struct usb_interface *intf)
EXPORT_SYMBOL_GPL(usb_autopm_get_interface_async);
/**
- * usb_autopm_get_interface_no_resume - increment a USB interface's PM-usage counter
+ * usb_autopm_get_interface_no_resume -
+ * increment a USB interface's PM-usage counter
+ *
* @intf: the usb_interface whose counter should be incremented
*
* This routine increments @intf's usage counter but does not carry out an
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: usb: core: driver: fixed 80 line character length issue
2020-05-31 1:50 [PATCH] drivers: usb: core: driver: fixed 80 line character length issue Lokesh Chebrolu
@ 2020-05-31 6:41 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-05-31 6:41 UTC (permalink / raw)
To: Lokesh Chebrolu; +Cc: hadess, stern, linux-usb, linux-kernel
On Sun, May 31, 2020 at 07:20:06AM +0530, Lokesh Chebrolu wrote:
> From: lokeshch007 <lokeshch007@gmail.com>
This has to match the s-o-b line
>
> Fixed a coding style issue
What issue?
>
> Signed-off-by: Lokesh Chebrolu <lokeshch007@gmail.com>
> ---
> drivers/usb/core/driver.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> index f81606c..83c3287 100644
> --- a/drivers/usb/core/driver.c
> +++ b/drivers/usb/core/driver.c
> @@ -1796,7 +1796,9 @@ int usb_autopm_get_interface_async(struct usb_interface *intf)
> EXPORT_SYMBOL_GPL(usb_autopm_get_interface_async);
>
> /**
> - * usb_autopm_get_interface_no_resume - increment a USB interface's PM-usage counter
> + * usb_autopm_get_interface_no_resume -
> + * increment a USB interface's PM-usage counter
> + *
Nope, the original is correct, sorry, kerneldoc wants this to be a long
single line.
When starting out in kernel development, please stick to
drivers/staging/ which has lots of places to clean up and patches like
this are welcomed much more so than other parts of the kernel.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-31 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-31 1:50 [PATCH] drivers: usb: core: driver: fixed 80 line character length issue Lokesh Chebrolu
2020-05-31 6:41 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).