* [PATCH 1/6] USB: sisusbvga: change char to u8 for sisusb_copy_memory
2020-05-30 1:48 [PATCH 0/6] USB: sisusbvga: series of changes char to u8 Changming
@ 2020-05-30 1:48 ` Changming
2020-05-30 1:48 ` [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk Changming
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Changming @ 2020-05-30 1:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, thomas, Changming Liu
From: Changming Liu <liu.changm@northeastern.edu>
sisusb_copy_memory is called in several places.
sisusb_copy_memory calls sisusb_write_mem_bulk which
is called by sisusb_write and sisusb_send_bulk_msg.
change the related parameters from char to u8 accordingly
Signed-off-by: Changming Liu <liu.changm@northeastern.edu>
---
drivers/usb/misc/sisusbvga/sisusb.c | 6 +++---
drivers/usb/misc/sisusbvga/sisusb_con.c | 10 +++++-----
drivers/usb/misc/sisusbvga/sisusb_init.h | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index fc8a5da4a07c..88c4975e303d 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -1283,7 +1283,7 @@ int sisusb_readb(struct sisusb_usb_data *sisusb, u32 adr, u8 *data)
return sisusb_read_memio_byte(sisusb, SISUSB_TYPE_MEM, adr, data);
}
-int sisusb_copy_memory(struct sisusb_usb_data *sisusb, char *src,
+int sisusb_copy_memory(struct sisusb_usb_data *sisusb, u8 *src,
u32 dest, int length)
{
size_t dummy;
@@ -1307,7 +1307,7 @@ static int sisusb_read_memory(struct sisusb_usb_data *sisusb, char *dest,
#ifdef SISUSBENDIANTEST
static void sisusb_testreadwrite(struct sisusb_usb_data *sisusb)
{
- static char srcbuffer[] = { 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77 };
+ static u8 srcbuffer[] = { 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77 };
char destbuffer[10];
int i, j;
@@ -2340,7 +2340,7 @@ int sisusb_reset_text_mode(struct sisusb_usb_data *sisusb, int init)
}
} else if (sisusb->scrbuf) {
- ret |= sisusb_copy_memory(sisusb, (char *)sisusb->scrbuf,
+ ret |= sisusb_copy_memory(sisusb, (u8 *)sisusb->scrbuf,
sisusb->vrambase, sisusb->scrbuf_size);
}
diff --git a/drivers/usb/misc/sisusbvga/sisusb_con.c b/drivers/usb/misc/sisusbvga/sisusb_con.c
index cd0155310fea..85a324b658ab 100644
--- a/drivers/usb/misc/sisusbvga/sisusb_con.c
+++ b/drivers/usb/misc/sisusbvga/sisusb_con.c
@@ -509,7 +509,7 @@ sisusbcon_switch(struct vc_data *c)
/* Restore the screen contents */
memcpy((u16 *)c->vc_origin, (u16 *)c->vc_screenbuf, length);
- sisusb_copy_memory(sisusb, (char *)c->vc_origin,
+ sisusb_copy_memory(sisusb, (u8 *)c->vc_origin,
sisusb_haddr(sisusb, c, 0, 0), length);
mutex_unlock(&sisusb->lock);
@@ -615,7 +615,7 @@ sisusbcon_blank(struct vc_data *c, int blank, int mode_switch)
sisusbcon_memsetw((u16 *)c->vc_origin,
c->vc_video_erase_char,
c->vc_screenbuf_size);
- sisusb_copy_memory(sisusb, (char *)c->vc_origin,
+ sisusb_copy_memory(sisusb, (u8 *)c->vc_origin,
sisusb_haddr(sisusb, c, 0, 0),
c->vc_screenbuf_size);
sisusb->con_blanked = 1;
@@ -897,18 +897,18 @@ sisusbcon_scroll(struct vc_data *c, unsigned int t, unsigned int b,
if (copyall)
sisusb_copy_memory(sisusb,
- (char *)c->vc_origin,
+ (u8 *)c->vc_origin,
sisusb_haddr(sisusb, c, 0, 0),
c->vc_screenbuf_size);
else if (dir == SM_UP)
sisusb_copy_memory(sisusb,
- (char *)c->vc_origin + c->vc_screenbuf_size - delta,
+ (u8 *)c->vc_origin + c->vc_screenbuf_size - delta,
sisusb_haddr(sisusb, c, 0, 0) +
c->vc_screenbuf_size - delta,
delta);
else
sisusb_copy_memory(sisusb,
- (char *)c->vc_origin,
+ (u8 *)c->vc_origin,
sisusb_haddr(sisusb, c, 0, 0),
delta);
diff --git a/drivers/usb/misc/sisusbvga/sisusb_init.h b/drivers/usb/misc/sisusbvga/sisusb_init.h
index ace09985dae4..d0154394ba12 100644
--- a/drivers/usb/misc/sisusbvga/sisusb_init.h
+++ b/drivers/usb/misc/sisusbvga/sisusb_init.h
@@ -828,7 +828,7 @@ extern int sisusb_setidxregand(struct sisusb_usb_data *sisusb, u32 port,
void sisusb_delete(struct kref *kref);
int sisusb_writeb(struct sisusb_usb_data *sisusb, u32 adr, u8 data);
int sisusb_readb(struct sisusb_usb_data *sisusb, u32 adr, u8 * data);
-int sisusb_copy_memory(struct sisusb_usb_data *sisusb, char *src,
+int sisusb_copy_memory(struct sisusb_usb_data *sisusb, u8 *src,
u32 dest, int length);
int sisusb_reset_text_mode(struct sisusb_usb_data *sisusb, int init);
int sisusbcon_do_font_op(struct sisusb_usb_data *sisusb, int set, int slot,
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk
2020-05-30 1:48 [PATCH 0/6] USB: sisusbvga: series of changes char to u8 Changming
2020-05-30 1:48 ` [PATCH 1/6] USB: sisusbvga: change char to u8 for sisusb_copy_memory Changming
@ 2020-05-30 1:48 ` Changming
2020-05-31 21:14 ` kbuild test robot
` (2 more replies)
2020-05-30 1:48 ` [PATCH 3/6] USB: sisusbvga: change sisusb->ibuf,obuf,font_backup Changming
` (3 subsequent siblings)
5 siblings, 3 replies; 13+ messages in thread
From: Changming @ 2020-05-30 1:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, thomas, Changming Liu
From: Changming Liu <liu.changm@northeastern.edu>
isusb_write_mem_bulk calls sisusb_send_bulk_msg and
is called by sisusb_write.
Changed their parameters accordingly.
Also change the local buf[4] of sisusb_write_mem_bulk
to u8. This fixed a potential undefined behavior.
Signed-off-by: Changming Liu <liu.changm@northeastern.edu>
---
drivers/usb/misc/sisusbvga/sisusb.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index 88c4975e303d..f800a9c7feec 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -327,7 +327,7 @@ static int sisusb_bulkin_msg(struct sisusb_usb_data *sisusb,
*/
static int sisusb_send_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
- char *kernbuffer, const char __user *userbuffer, int index,
+ u8 *kernbuffer, const u8 __user *userbuffer, int index,
ssize_t *bytes_written, unsigned int tflags, int async)
{
int result = 0, retry, count = len;
@@ -543,7 +543,7 @@ static int sisusb_send_packet(struct sisusb_usb_data *sisusb, int len,
/* 1. send the packet */
ret = sisusb_send_bulk_msg(sisusb, SISUSB_EP_GFX_OUT, len,
- (char *)packet, NULL, 0, &bytes_transferred, 0, 0);
+ (u8 *)packet, NULL, 0, &bytes_transferred, 0, 0);
if ((ret == 0) && (len == 6)) {
@@ -579,7 +579,7 @@ static int sisusb_send_bridge_packet(struct sisusb_usb_data *sisusb, int len,
/* 1. send the packet */
ret = sisusb_send_bulk_msg(sisusb, SISUSB_EP_BRIDGE_OUT, len,
- (char *)packet, NULL, 0, &bytes_transferred, tflags, 0);
+ (u8 *)packet, NULL, 0, &bytes_transferred, tflags, 0);
if ((ret == 0) && (len == 6)) {
@@ -752,7 +752,7 @@ static int sisusb_write_memio_long(struct sisusb_usb_data *sisusb, int type,
*/
static int sisusb_write_mem_bulk(struct sisusb_usb_data *sisusb, u32 addr,
- char *kernbuffer, int length, const char __user *userbuffer,
+ u8 *kernbuffer, int length, const u8 __user *userbuffer,
int index, ssize_t *bytes_written)
{
struct sisusb_packet packet;
@@ -761,7 +761,7 @@ static int sisusb_write_mem_bulk(struct sisusb_usb_data *sisusb, u32 addr,
u8 swap8, fromkern = kernbuffer ? 1 : 0;
u16 swap16;
u32 swap32, flag = (length >> 28) & 1;
- char buf[4];
+ u8 buf[4];
/* if neither kernbuffer not userbuffer are given, assume
* data in obuf
@@ -2615,7 +2615,7 @@ static ssize_t sisusb_read(struct file *file, char __user *buffer,
return errno ? errno : bytes_read;
}
-static ssize_t sisusb_write(struct file *file, const char __user *buffer,
+static ssize_t sisusb_write(struct file *file, const u8 __user *buffer,
size_t count, loff_t *ppos)
{
struct sisusb_usb_data *sisusb;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk
2020-05-30 1:48 ` [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk Changming
@ 2020-05-31 21:14 ` kbuild test robot
2020-05-31 21:35 ` kbuild test robot
2020-05-31 21:37 ` kbuild test robot
2 siblings, 0 replies; 13+ messages in thread
From: kbuild test robot @ 2020-05-31 21:14 UTC (permalink / raw)
To: Changming, gregkh; +Cc: kbuild-all, linux-usb, thomas, Changming Liu
[-- Attachment #1: Type: text/plain, Size: 11397 bytes --]
Hi Changming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next peter.chen-usb/ci-for-usb-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Changming/USB-sisusbvga-series-of-changes-char-to-u8/20200601-012438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/usb/misc/sisusbvga/sisusb.c:2997:11: error: initialization of 'ssize_t (*)(struct file *, const char *, size_t, loff_t *)' {aka 'long int (*)(struct file *, const char *, long unsigned int, long long int *)'} from incompatible pointer type 'ssize_t (*)(struct file *, const u8 *, size_t, loff_t *)' {aka 'long int (*)(struct file *, const unsigned char *, long unsigned int, long long int *)'} [-Werror=incompatible-pointer-types]
2997 | .write = sisusb_write,
| ^~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: note: (near initialization for 'usb_sisusb_fops.write')
In file included from drivers/usb/misc/sisusbvga/sisusb.c:54:
drivers/usb/misc/sisusbvga/sisusb_init.h:695:34: warning: 'SiSUSB_VCLKData' defined but not used [-Wunused-const-variable=]
695 | static const struct SiS_VCLKData SiSUSB_VCLKData[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:437:35: warning: 'SiSUSB_CRT1Table' defined but not used [-Wunused-const-variable=]
437 | static const struct SiS_CRT1Table SiSUSB_CRT1Table[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:379:30: warning: 'SiSUSB_RefIndex' defined but not used [-Wunused-const-variable=]
379 | static const struct SiS_Ext2 SiSUSB_RefIndex[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:300:29: warning: 'SiSUSB_EModeIDTable' defined but not used [-Wunused-const-variable=]
300 | static const struct SiS_Ext SiSUSB_EModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:269:36: warning: 'SiSUSB_StandTable' defined but not used [-Wunused-const-variable=]
269 | static const struct SiS_StandTable SiSUSB_StandTable[] = {
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:232:37: warning: 'SiSUSB_ModeResInfo' defined but not used [-Wunused-const-variable=]
232 | static const struct SiS_ModeResInfo SiSUSB_ModeResInfo[] = {
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:224:37: warning: 'SiSUSB_StResInfo' defined but not used [-Wunused-const-variable=]
224 | static const struct SiS_StResInfo_S SiSUSB_StResInfo[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:219:28: warning: 'SiSUSB_SModeIDTable' defined but not used [-Wunused-const-variable=]
219 | static const struct SiS_St SiSUSB_SModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:206:28: warning: 'SiS_VGA_DAC' defined but not used [-Wunused-const-variable=]
206 | static const unsigned char SiS_VGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:195:28: warning: 'SiS_EGA_DAC' defined but not used [-Wunused-const-variable=]
195 | static const unsigned char SiS_EGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:184:28: warning: 'SiS_CGA_DAC' defined but not used [-Wunused-const-variable=]
184 | static const unsigned char SiS_CGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:173:28: warning: 'SiS_MDA_DAC' defined but not used [-Wunused-const-variable=]
173 | static const unsigned char SiS_MDA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:171:29: warning: 'ModeIndex_1280x1024' defined but not used [-Wunused-const-variable=]
171 | static const unsigned short ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 };
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:170:29: warning: 'ModeIndex_1280x768' defined but not used [-Wunused-const-variable=]
170 | static const unsigned short ModeIndex_1280x768[] = { 0x23, 0x24, 0x00, 0x25 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:169:29: warning: 'ModeIndex_1280x720' defined but not used [-Wunused-const-variable=]
169 | static const unsigned short ModeIndex_1280x720[] = { 0x79, 0x75, 0x00, 0x78 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:168:29: warning: 'ModeIndex_1152x864' defined but not used [-Wunused-const-variable=]
168 | static const unsigned short ModeIndex_1152x864[] = { 0x29, 0x2a, 0x00, 0x2b };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:167:29: warning: 'ModeIndex_1024x576' defined but not used [-Wunused-const-variable=]
167 | static const unsigned short ModeIndex_1024x576[] = { 0x71, 0x74, 0x00, 0x77 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:166:29: warning: 'ModeIndex_1024x768' defined but not used [-Wunused-const-variable=]
166 | static const unsigned short ModeIndex_1024x768[] = { 0x38, 0x4a, 0x00, 0x64 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:165:29: warning: 'ModeIndex_960x600' defined but not used [-Wunused-const-variable=]
165 | static const unsigned short ModeIndex_960x600[] = { 0x20, 0x21, 0x00, 0x22 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:164:29: warning: 'ModeIndex_960x540' defined but not used [-Wunused-const-variable=]
164 | static const unsigned short ModeIndex_960x540[] = { 0x1d, 0x1e, 0x00, 0x1f };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:163:29: warning: 'ModeIndex_856x480' defined but not used [-Wunused-const-variable=]
163 | static const unsigned short ModeIndex_856x480[] = { 0x3f, 0x42, 0x00, 0x45 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:162:29: warning: 'ModeIndex_848x480' defined but not used [-Wunused-const-variable=]
162 | static const unsigned short ModeIndex_848x480[] = { 0x39, 0x3b, 0x00, 0x3e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:161:29: warning: 'ModeIndex_800x600' defined but not used [-Wunused-const-variable=]
161 | static const unsigned short ModeIndex_800x600[] = { 0x30, 0x47, 0x00, 0x63 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:160:29: warning: 'ModeIndex_800x480' defined but not used [-Wunused-const-variable=]
160 | static const unsigned short ModeIndex_800x480[] = { 0x70, 0x7a, 0x00, 0x76 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:159:29: warning: 'ModeIndex_768x576' defined but not used [-Wunused-const-variable=]
159 | static const unsigned short ModeIndex_768x576[] = { 0x5f, 0x60, 0x00, 0x61 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:158:29: warning: 'ModeIndex_720x576' defined but not used [-Wunused-const-variable=]
158 | static const unsigned short ModeIndex_720x576[] = { 0x32, 0x34, 0x00, 0x36 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:157:29: warning: 'ModeIndex_720x480' defined but not used [-Wunused-const-variable=]
157 | static const unsigned short ModeIndex_720x480[] = { 0x31, 0x33, 0x00, 0x35 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:156:29: warning: 'ModeIndex_640x480' defined but not used [-Wunused-const-variable=]
156 | static const unsigned short ModeIndex_640x480[] = { 0x2e, 0x44, 0x00, 0x62 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:155:29: warning: 'ModeIndex_640x400' defined but not used [-Wunused-const-variable=]
155 | static const unsigned short ModeIndex_640x400[] = { 0x2f, 0x5d, 0x00, 0x5e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:154:29: warning: 'ModeIndex_512x384' defined but not used [-Wunused-const-variable=]
154 | static const unsigned short ModeIndex_512x384[] = { 0x52, 0x58, 0x00, 0x5c };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:153:29: warning: 'ModeIndex_400x300' defined but not used [-Wunused-const-variable=]
153 | static const unsigned short ModeIndex_400x300[] = { 0x51, 0x57, 0x00, 0x54 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:152:29: warning: 'ModeIndex_320x240' defined but not used [-Wunused-const-variable=]
152 | static const unsigned short ModeIndex_320x240[] = { 0x50, 0x56, 0x00, 0x53 };
| ^~~~~~~~~~~~~~~~~
vim +2997 drivers/usb/misc/sisusbvga/sisusb.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2991
066202dd48cf32 Luiz Fernando N. Capitulino 2006-08-05 2992 static const struct file_operations usb_sisusb_fops = {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2993 .owner = THIS_MODULE,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2994 .open = sisusb_open,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2995 .release = sisusb_release,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2996 .read = sisusb_read,
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2997 .write = sisusb_write,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2998 .llseek = sisusb_lseek,
022e468e139573 Jiri Slaby 2019-01-22 2999 #ifdef CONFIG_COMPAT
^1da177e4c3f41 Linus Torvalds 2005-04-16 3000 .compat_ioctl = sisusb_compat_ioctl,
^1da177e4c3f41 Linus Torvalds 2005-04-16 3001 #endif
49f15255465321 Alan Cox 2008-05-22 3002 .unlocked_ioctl = sisusb_ioctl
^1da177e4c3f41 Linus Torvalds 2005-04-16 3003 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 3004
:::::: The code at line 2997 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61396 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk
2020-05-30 1:48 ` [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk Changming
2020-05-31 21:14 ` kbuild test robot
@ 2020-05-31 21:35 ` kbuild test robot
2020-05-31 21:37 ` kbuild test robot
2 siblings, 0 replies; 13+ messages in thread
From: kbuild test robot @ 2020-05-31 21:35 UTC (permalink / raw)
To: Changming, gregkh
Cc: kbuild-all, clang-built-linux, linux-usb, thomas, Changming Liu
[-- Attachment #1: Type: text/plain, Size: 3448 bytes --]
Hi Changming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Changming/USB-sisusbvga-series-of-changes-char-to-u8/20200601-012438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/usb/misc/sisusbvga/sisusb.c:2997:11: error: incompatible function pointer types initializing 'ssize_t (*)(struct file *, const char *, size_t, loff_t *)' (aka 'long (*)(struct file *, const char *, unsigned long, long long *)') with an expression of type 'ssize_t (struct file *, const u8 *, size_t, loff_t *)' (aka 'long (struct file *, const unsigned char *, unsigned long, long long *)') [-Werror,-Wincompatible-function-pointer-types]
.write = sisusb_write,
^~~~~~~~~~~~
1 error generated.
vim +2997 drivers/usb/misc/sisusbvga/sisusb.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2991
066202dd48cf32 Luiz Fernando N. Capitulino 2006-08-05 2992 static const struct file_operations usb_sisusb_fops = {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2993 .owner = THIS_MODULE,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2994 .open = sisusb_open,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2995 .release = sisusb_release,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2996 .read = sisusb_read,
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2997 .write = sisusb_write,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2998 .llseek = sisusb_lseek,
022e468e139573 Jiri Slaby 2019-01-22 2999 #ifdef CONFIG_COMPAT
^1da177e4c3f41 Linus Torvalds 2005-04-16 3000 .compat_ioctl = sisusb_compat_ioctl,
^1da177e4c3f41 Linus Torvalds 2005-04-16 3001 #endif
49f15255465321 Alan Cox 2008-05-22 3002 .unlocked_ioctl = sisusb_ioctl
^1da177e4c3f41 Linus Torvalds 2005-04-16 3003 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 3004
:::::: The code at line 2997 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73536 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk
2020-05-30 1:48 ` [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk Changming
2020-05-31 21:14 ` kbuild test robot
2020-05-31 21:35 ` kbuild test robot
@ 2020-05-31 21:37 ` kbuild test robot
2 siblings, 0 replies; 13+ messages in thread
From: kbuild test robot @ 2020-05-31 21:37 UTC (permalink / raw)
To: Changming, gregkh; +Cc: kbuild-all, linux-usb, thomas, Changming Liu
[-- Attachment #1: Type: text/plain, Size: 11374 bytes --]
Hi Changming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next peter.chen-usb/ci-for-usb-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Changming/USB-sisusbvga-series-of-changes-char-to-u8/20200601-012438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/usb/misc/sisusbvga/sisusb.c:2997:11: error: initialization of 'ssize_t (*)(struct file *, const char *, size_t, loff_t *)' {aka 'int (*)(struct file *, const char *, unsigned int, long long int *)'} from incompatible pointer type 'ssize_t (*)(struct file *, const u8 *, size_t, loff_t *)' {aka 'int (*)(struct file *, const unsigned char *, unsigned int, long long int *)'} [-Werror=incompatible-pointer-types]
2997 | .write = sisusb_write,
| ^~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: note: (near initialization for 'usb_sisusb_fops.write')
In file included from drivers/usb/misc/sisusbvga/sisusb.c:54:
drivers/usb/misc/sisusbvga/sisusb_init.h:695:34: warning: 'SiSUSB_VCLKData' defined but not used [-Wunused-const-variable=]
695 | static const struct SiS_VCLKData SiSUSB_VCLKData[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:437:35: warning: 'SiSUSB_CRT1Table' defined but not used [-Wunused-const-variable=]
437 | static const struct SiS_CRT1Table SiSUSB_CRT1Table[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:379:30: warning: 'SiSUSB_RefIndex' defined but not used [-Wunused-const-variable=]
379 | static const struct SiS_Ext2 SiSUSB_RefIndex[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:300:29: warning: 'SiSUSB_EModeIDTable' defined but not used [-Wunused-const-variable=]
300 | static const struct SiS_Ext SiSUSB_EModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:269:36: warning: 'SiSUSB_StandTable' defined but not used [-Wunused-const-variable=]
269 | static const struct SiS_StandTable SiSUSB_StandTable[] = {
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:232:37: warning: 'SiSUSB_ModeResInfo' defined but not used [-Wunused-const-variable=]
232 | static const struct SiS_ModeResInfo SiSUSB_ModeResInfo[] = {
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:224:37: warning: 'SiSUSB_StResInfo' defined but not used [-Wunused-const-variable=]
224 | static const struct SiS_StResInfo_S SiSUSB_StResInfo[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:219:28: warning: 'SiSUSB_SModeIDTable' defined but not used [-Wunused-const-variable=]
219 | static const struct SiS_St SiSUSB_SModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:206:28: warning: 'SiS_VGA_DAC' defined but not used [-Wunused-const-variable=]
206 | static const unsigned char SiS_VGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:195:28: warning: 'SiS_EGA_DAC' defined but not used [-Wunused-const-variable=]
195 | static const unsigned char SiS_EGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:184:28: warning: 'SiS_CGA_DAC' defined but not used [-Wunused-const-variable=]
184 | static const unsigned char SiS_CGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:173:28: warning: 'SiS_MDA_DAC' defined but not used [-Wunused-const-variable=]
173 | static const unsigned char SiS_MDA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:171:29: warning: 'ModeIndex_1280x1024' defined but not used [-Wunused-const-variable=]
171 | static const unsigned short ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 };
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:170:29: warning: 'ModeIndex_1280x768' defined but not used [-Wunused-const-variable=]
170 | static const unsigned short ModeIndex_1280x768[] = { 0x23, 0x24, 0x00, 0x25 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:169:29: warning: 'ModeIndex_1280x720' defined but not used [-Wunused-const-variable=]
169 | static const unsigned short ModeIndex_1280x720[] = { 0x79, 0x75, 0x00, 0x78 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:168:29: warning: 'ModeIndex_1152x864' defined but not used [-Wunused-const-variable=]
168 | static const unsigned short ModeIndex_1152x864[] = { 0x29, 0x2a, 0x00, 0x2b };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:167:29: warning: 'ModeIndex_1024x576' defined but not used [-Wunused-const-variable=]
167 | static const unsigned short ModeIndex_1024x576[] = { 0x71, 0x74, 0x00, 0x77 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:166:29: warning: 'ModeIndex_1024x768' defined but not used [-Wunused-const-variable=]
166 | static const unsigned short ModeIndex_1024x768[] = { 0x38, 0x4a, 0x00, 0x64 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:165:29: warning: 'ModeIndex_960x600' defined but not used [-Wunused-const-variable=]
165 | static const unsigned short ModeIndex_960x600[] = { 0x20, 0x21, 0x00, 0x22 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:164:29: warning: 'ModeIndex_960x540' defined but not used [-Wunused-const-variable=]
164 | static const unsigned short ModeIndex_960x540[] = { 0x1d, 0x1e, 0x00, 0x1f };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:163:29: warning: 'ModeIndex_856x480' defined but not used [-Wunused-const-variable=]
163 | static const unsigned short ModeIndex_856x480[] = { 0x3f, 0x42, 0x00, 0x45 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:162:29: warning: 'ModeIndex_848x480' defined but not used [-Wunused-const-variable=]
162 | static const unsigned short ModeIndex_848x480[] = { 0x39, 0x3b, 0x00, 0x3e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:161:29: warning: 'ModeIndex_800x600' defined but not used [-Wunused-const-variable=]
161 | static const unsigned short ModeIndex_800x600[] = { 0x30, 0x47, 0x00, 0x63 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:160:29: warning: 'ModeIndex_800x480' defined but not used [-Wunused-const-variable=]
160 | static const unsigned short ModeIndex_800x480[] = { 0x70, 0x7a, 0x00, 0x76 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:159:29: warning: 'ModeIndex_768x576' defined but not used [-Wunused-const-variable=]
159 | static const unsigned short ModeIndex_768x576[] = { 0x5f, 0x60, 0x00, 0x61 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:158:29: warning: 'ModeIndex_720x576' defined but not used [-Wunused-const-variable=]
158 | static const unsigned short ModeIndex_720x576[] = { 0x32, 0x34, 0x00, 0x36 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:157:29: warning: 'ModeIndex_720x480' defined but not used [-Wunused-const-variable=]
157 | static const unsigned short ModeIndex_720x480[] = { 0x31, 0x33, 0x00, 0x35 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:156:29: warning: 'ModeIndex_640x480' defined but not used [-Wunused-const-variable=]
156 | static const unsigned short ModeIndex_640x480[] = { 0x2e, 0x44, 0x00, 0x62 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:155:29: warning: 'ModeIndex_640x400' defined but not used [-Wunused-const-variable=]
155 | static const unsigned short ModeIndex_640x400[] = { 0x2f, 0x5d, 0x00, 0x5e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:154:29: warning: 'ModeIndex_512x384' defined but not used [-Wunused-const-variable=]
154 | static const unsigned short ModeIndex_512x384[] = { 0x52, 0x58, 0x00, 0x5c };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:153:29: warning: 'ModeIndex_400x300' defined but not used [-Wunused-const-variable=]
153 | static const unsigned short ModeIndex_400x300[] = { 0x51, 0x57, 0x00, 0x54 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:152:29: warning: 'ModeIndex_320x240' defined but not used [-Wunused-const-variable=]
152 | static const unsigned short ModeIndex_320x240[] = { 0x50, 0x56, 0x00, 0x53 };
| ^~~~~~~~~~~~~~~~~
vim +2997 drivers/usb/misc/sisusbvga/sisusb.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2991
066202dd48cf32 Luiz Fernando N. Capitulino 2006-08-05 2992 static const struct file_operations usb_sisusb_fops = {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2993 .owner = THIS_MODULE,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2994 .open = sisusb_open,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2995 .release = sisusb_release,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2996 .read = sisusb_read,
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2997 .write = sisusb_write,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2998 .llseek = sisusb_lseek,
022e468e139573 Jiri Slaby 2019-01-22 2999 #ifdef CONFIG_COMPAT
^1da177e4c3f41 Linus Torvalds 2005-04-16 3000 .compat_ioctl = sisusb_compat_ioctl,
^1da177e4c3f41 Linus Torvalds 2005-04-16 3001 #endif
49f15255465321 Alan Cox 2008-05-22 3002 .unlocked_ioctl = sisusb_ioctl
^1da177e4c3f41 Linus Torvalds 2005-04-16 3003 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 3004
:::::: The code at line 2997 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65470 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/6] USB: sisusbvga: change sisusb->ibuf,obuf,font_backup
2020-05-30 1:48 [PATCH 0/6] USB: sisusbvga: series of changes char to u8 Changming
2020-05-30 1:48 ` [PATCH 1/6] USB: sisusbvga: change char to u8 for sisusb_copy_memory Changming
2020-05-30 1:48 ` [PATCH 2/6] USB: sisusbvga: change sisusb_write_mem_bulk Changming
@ 2020-05-30 1:48 ` Changming
2020-05-30 1:48 ` [PATCH 4/6] USB: sisusbvga: change userbuffer for sisusb_recv_bulk_msg to u8 Changming
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Changming @ 2020-05-30 1:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, thomas, Changming Liu
From: Changming Liu <liu.changm@northeastern.edu>
change sisusb->ibuf,obuf,font_backup to u8
and related buf which can be assigned to them
Signed-off-by: Changming Liu <liu.changm@northeastern.edu>
---
drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
drivers/usb/misc/sisusbvga/sisusb.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index f800a9c7feec..83c3785ce4ab
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -335,7 +335,7 @@ static int sisusb_send_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
int fromuser = (userbuffer != NULL) ? 1 : 0;
int fromkern = (kernbuffer != NULL) ? 1 : 0;
unsigned int pipe;
- char *buffer;
+ u8 *buffer;
(*bytes_written) = 0;
@@ -454,7 +454,7 @@ static int sisusb_recv_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
int result = 0, retry, count = len;
int bufsize, thispass, transferred_len;
unsigned int pipe;
- char *buffer;
+ u8 *buffer;
(*bytes_read) = 0;
diff --git a/drivers/usb/misc/sisusbvga/sisusb.h b/drivers/usb/misc/sisusbvga/sisusb.h
index 8a5e6bb07d05..f761ede77c0b 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.h
+++ b/drivers/usb/misc/sisusbvga/sisusb.h
@@ -109,7 +109,7 @@ struct sisusb_usb_data {
int present; /* !=0 if device is present on the bus */
int ready; /* !=0 if device is ready for userland */
int numobufs; /* number of obufs = number of out urbs */
- char *obuf[NUMOBUFS], *ibuf; /* transfer buffers */
+ unsigned char *obuf[NUMOBUFS], *ibuf; /* transfer buffers */
int obufsize, ibufsize;
struct urb *sisurbout[NUMOBUFS];
struct urb *sisurbin;
@@ -140,7 +140,7 @@ struct sisusb_usb_data {
int sisusb_cursor_size_to;
int current_font_height, current_font_512;
int font_backup_size, font_backup_height, font_backup_512;
- char *font_backup;
+ unsigned char *font_backup;
int font_slot;
struct vc_data *sisusb_display_fg;
int is_gfx;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 4/6] USB: sisusbvga: change userbuffer for sisusb_recv_bulk_msg to u8
2020-05-30 1:48 [PATCH 0/6] USB: sisusbvga: series of changes char to u8 Changming
` (2 preceding siblings ...)
2020-05-30 1:48 ` [PATCH 3/6] USB: sisusbvga: change sisusb->ibuf,obuf,font_backup Changming
@ 2020-05-30 1:48 ` Changming
2020-05-30 1:48 ` [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk Changming
2020-05-30 1:48 ` [PATCH 6/6] USB: sisusbvga: change the local char array to u8 array Changming
5 siblings, 0 replies; 13+ messages in thread
From: Changming @ 2020-05-30 1:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, thomas, Changming Liu
From: Changming Liu <liu.changm@northeastern.edu>
change the userbuffer of sisusb_recv_bulk_msg
also force cast the kernbuffer to u8 when passed in
Signed-off-by: Changming Liu <liu.changm@northeastern.edu>
---
drivers/usb/misc/sisusbvga/sisusb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index 83c3785ce4ab..9e858530c4ed 100755
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -448,7 +448,7 @@ static int sisusb_send_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
*/
static int sisusb_recv_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
- void *kernbuffer, char __user *userbuffer, ssize_t *bytes_read,
+ void *kernbuffer, u8 __user *userbuffer, ssize_t *bytes_read,
unsigned int tflags)
{
int result = 0, retry, count = len;
@@ -551,7 +551,7 @@ static int sisusb_send_packet(struct sisusb_usb_data *sisusb, int len,
* return value and write it to packet->data
*/
ret = sisusb_recv_bulk_msg(sisusb, SISUSB_EP_GFX_IN, 4,
- (char *)&tmp, NULL, &bytes_transferred, 0);
+ (u8 *)&tmp, NULL, &bytes_transferred, 0);
packet->data = le32_to_cpu(tmp);
}
@@ -587,7 +587,7 @@ static int sisusb_send_bridge_packet(struct sisusb_usb_data *sisusb, int len,
* return value and write it to packet->data
*/
ret = sisusb_recv_bulk_msg(sisusb, SISUSB_EP_BRIDGE_IN, 4,
- (char *)&tmp, NULL, &bytes_transferred, 0);
+ (u8 *)&tmp, NULL, &bytes_transferred, 0);
packet->data = le32_to_cpu(tmp);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk
2020-05-30 1:48 [PATCH 0/6] USB: sisusbvga: series of changes char to u8 Changming
` (3 preceding siblings ...)
2020-05-30 1:48 ` [PATCH 4/6] USB: sisusbvga: change userbuffer for sisusb_recv_bulk_msg to u8 Changming
@ 2020-05-30 1:48 ` Changming
2020-05-31 22:26 ` kbuild test robot
` (2 more replies)
2020-05-30 1:48 ` [PATCH 6/6] USB: sisusbvga: change the local char array to u8 array Changming
5 siblings, 3 replies; 13+ messages in thread
From: Changming @ 2020-05-30 1:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, thomas, Changming Liu
From: Changming Liu <liu.changm@northeastern.edu>
change sisusb_read_mem_bulk userbuffer,kernbuffer
and local buf from char to u8.
Also it's called by sisusb_read_memory sisusb_testreadwrite
and sisusb_read. Change their parameter types accordingly.
Signed-off-by: Changming Liu <liu.changm@northeastern.edu>
---
drivers/usb/misc/sisusbvga/sisusb.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index 9e858530c4ed..1f21db40fdb5 100755
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -1104,11 +1104,11 @@ static int sisusb_read_memio_long(struct sisusb_usb_data *sisusb, int type,
}
static int sisusb_read_mem_bulk(struct sisusb_usb_data *sisusb, u32 addr,
- char *kernbuffer, int length, char __user *userbuffer,
+ u8 *kernbuffer, int length, u8 __user *userbuffer,
ssize_t *bytes_read)
{
int ret = 0;
- char buf[4];
+ u8 buf[4];
u16 swap16;
u32 swap32;
@@ -1293,7 +1293,7 @@ int sisusb_copy_memory(struct sisusb_usb_data *sisusb, u8 *src,
}
#ifdef SISUSBENDIANTEST
-static int sisusb_read_memory(struct sisusb_usb_data *sisusb, char *dest,
+static int sisusb_read_memory(struct sisusb_usb_data *sisusb, u8 *dest,
u32 src, int length)
{
size_t dummy;
@@ -1308,7 +1308,7 @@ static int sisusb_read_memory(struct sisusb_usb_data *sisusb, char *dest,
static void sisusb_testreadwrite(struct sisusb_usb_data *sisusb)
{
static u8 srcbuffer[] = { 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77 };
- char destbuffer[10];
+ u8 destbuffer[10];
int i, j;
sisusb_copy_memory(sisusb, srcbuffer, sisusb->vrambase, 7);
@@ -2479,7 +2479,7 @@ static int sisusb_release(struct inode *inode, struct file *file)
return 0;
}
-static ssize_t sisusb_read(struct file *file, char __user *buffer,
+static ssize_t sisusb_read(struct file *file, u8 __user *buffer,
size_t count, loff_t *ppos)
{
struct sisusb_usb_data *sisusb;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk
2020-05-30 1:48 ` [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk Changming
@ 2020-05-31 22:26 ` kbuild test robot
2020-05-31 22:43 ` kbuild test robot
2020-05-31 22:47 ` kbuild test robot
2 siblings, 0 replies; 13+ messages in thread
From: kbuild test robot @ 2020-05-31 22:26 UTC (permalink / raw)
To: Changming, gregkh; +Cc: kbuild-all, linux-usb, thomas, Changming Liu
[-- Attachment #1: Type: text/plain, Size: 11664 bytes --]
Hi Changming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next peter.chen-usb/ci-for-usb-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Changming/USB-sisusbvga-series-of-changes-char-to-u8/20200601-012438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/usb/misc/sisusbvga/sisusb.c:2996:11: error: initialization of 'ssize_t (*)(struct file *, char *, size_t, loff_t *)' {aka 'long int (*)(struct file *, char *, long unsigned int, long long int *)'} from incompatible pointer type 'ssize_t (*)(struct file *, u8 *, size_t, loff_t *)' {aka 'long int (*)(struct file *, unsigned char *, long unsigned int, long long int *)'} [-Werror=incompatible-pointer-types]
2996 | .read = sisusb_read,
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2996:11: note: (near initialization for 'usb_sisusb_fops.read')
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: error: initialization of 'ssize_t (*)(struct file *, const char *, size_t, loff_t *)' {aka 'long int (*)(struct file *, const char *, long unsigned int, long long int *)'} from incompatible pointer type 'ssize_t (*)(struct file *, const u8 *, size_t, loff_t *)' {aka 'long int (*)(struct file *, const unsigned char *, long unsigned int, long long int *)'} [-Werror=incompatible-pointer-types]
2997 | .write = sisusb_write,
| ^~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: note: (near initialization for 'usb_sisusb_fops.write')
In file included from drivers/usb/misc/sisusbvga/sisusb.c:54:
drivers/usb/misc/sisusbvga/sisusb_init.h:695:34: warning: 'SiSUSB_VCLKData' defined but not used [-Wunused-const-variable=]
695 | static const struct SiS_VCLKData SiSUSB_VCLKData[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:437:35: warning: 'SiSUSB_CRT1Table' defined but not used [-Wunused-const-variable=]
437 | static const struct SiS_CRT1Table SiSUSB_CRT1Table[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:379:30: warning: 'SiSUSB_RefIndex' defined but not used [-Wunused-const-variable=]
379 | static const struct SiS_Ext2 SiSUSB_RefIndex[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:300:29: warning: 'SiSUSB_EModeIDTable' defined but not used [-Wunused-const-variable=]
300 | static const struct SiS_Ext SiSUSB_EModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:269:36: warning: 'SiSUSB_StandTable' defined but not used [-Wunused-const-variable=]
269 | static const struct SiS_StandTable SiSUSB_StandTable[] = {
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:232:37: warning: 'SiSUSB_ModeResInfo' defined but not used [-Wunused-const-variable=]
232 | static const struct SiS_ModeResInfo SiSUSB_ModeResInfo[] = {
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:224:37: warning: 'SiSUSB_StResInfo' defined but not used [-Wunused-const-variable=]
224 | static const struct SiS_StResInfo_S SiSUSB_StResInfo[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:219:28: warning: 'SiSUSB_SModeIDTable' defined but not used [-Wunused-const-variable=]
219 | static const struct SiS_St SiSUSB_SModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:206:28: warning: 'SiS_VGA_DAC' defined but not used [-Wunused-const-variable=]
206 | static const unsigned char SiS_VGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:195:28: warning: 'SiS_EGA_DAC' defined but not used [-Wunused-const-variable=]
195 | static const unsigned char SiS_EGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:184:28: warning: 'SiS_CGA_DAC' defined but not used [-Wunused-const-variable=]
184 | static const unsigned char SiS_CGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:173:28: warning: 'SiS_MDA_DAC' defined but not used [-Wunused-const-variable=]
173 | static const unsigned char SiS_MDA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:171:29: warning: 'ModeIndex_1280x1024' defined but not used [-Wunused-const-variable=]
171 | static const unsigned short ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 };
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:170:29: warning: 'ModeIndex_1280x768' defined but not used [-Wunused-const-variable=]
170 | static const unsigned short ModeIndex_1280x768[] = { 0x23, 0x24, 0x00, 0x25 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:169:29: warning: 'ModeIndex_1280x720' defined but not used [-Wunused-const-variable=]
169 | static const unsigned short ModeIndex_1280x720[] = { 0x79, 0x75, 0x00, 0x78 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:168:29: warning: 'ModeIndex_1152x864' defined but not used [-Wunused-const-variable=]
168 | static const unsigned short ModeIndex_1152x864[] = { 0x29, 0x2a, 0x00, 0x2b };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:167:29: warning: 'ModeIndex_1024x576' defined but not used [-Wunused-const-variable=]
167 | static const unsigned short ModeIndex_1024x576[] = { 0x71, 0x74, 0x00, 0x77 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:166:29: warning: 'ModeIndex_1024x768' defined but not used [-Wunused-const-variable=]
166 | static const unsigned short ModeIndex_1024x768[] = { 0x38, 0x4a, 0x00, 0x64 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:165:29: warning: 'ModeIndex_960x600' defined but not used [-Wunused-const-variable=]
165 | static const unsigned short ModeIndex_960x600[] = { 0x20, 0x21, 0x00, 0x22 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:164:29: warning: 'ModeIndex_960x540' defined but not used [-Wunused-const-variable=]
164 | static const unsigned short ModeIndex_960x540[] = { 0x1d, 0x1e, 0x00, 0x1f };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:163:29: warning: 'ModeIndex_856x480' defined but not used [-Wunused-const-variable=]
163 | static const unsigned short ModeIndex_856x480[] = { 0x3f, 0x42, 0x00, 0x45 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:162:29: warning: 'ModeIndex_848x480' defined but not used [-Wunused-const-variable=]
162 | static const unsigned short ModeIndex_848x480[] = { 0x39, 0x3b, 0x00, 0x3e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:161:29: warning: 'ModeIndex_800x600' defined but not used [-Wunused-const-variable=]
161 | static const unsigned short ModeIndex_800x600[] = { 0x30, 0x47, 0x00, 0x63 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:160:29: warning: 'ModeIndex_800x480' defined but not used [-Wunused-const-variable=]
160 | static const unsigned short ModeIndex_800x480[] = { 0x70, 0x7a, 0x00, 0x76 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:159:29: warning: 'ModeIndex_768x576' defined but not used [-Wunused-const-variable=]
159 | static const unsigned short ModeIndex_768x576[] = { 0x5f, 0x60, 0x00, 0x61 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:158:29: warning: 'ModeIndex_720x576' defined but not used [-Wunused-const-variable=]
158 | static const unsigned short ModeIndex_720x576[] = { 0x32, 0x34, 0x00, 0x36 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:157:29: warning: 'ModeIndex_720x480' defined but not used [-Wunused-const-variable=]
157 | static const unsigned short ModeIndex_720x480[] = { 0x31, 0x33, 0x00, 0x35 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:156:29: warning: 'ModeIndex_640x480' defined but not used [-Wunused-const-variable=]
156 | static const unsigned short ModeIndex_640x480[] = { 0x2e, 0x44, 0x00, 0x62 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:155:29: warning: 'ModeIndex_640x400' defined but not used [-Wunused-const-variable=]
155 | static const unsigned short ModeIndex_640x400[] = { 0x2f, 0x5d, 0x00, 0x5e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:154:29: warning: 'ModeIndex_512x384' defined but not used [-Wunused-const-variable=]
154 | static const unsigned short ModeIndex_512x384[] = { 0x52, 0x58, 0x00, 0x5c };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:153:29: warning: 'ModeIndex_400x300' defined but not used [-Wunused-const-variable=]
153 | static const unsigned short ModeIndex_400x300[] = { 0x51, 0x57, 0x00, 0x54 };
vim +2996 drivers/usb/misc/sisusbvga/sisusb.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2991
066202dd48cf32 Luiz Fernando N. Capitulino 2006-08-05 2992 static const struct file_operations usb_sisusb_fops = {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2993 .owner = THIS_MODULE,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2994 .open = sisusb_open,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2995 .release = sisusb_release,
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2996 .read = sisusb_read,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2997 .write = sisusb_write,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2998 .llseek = sisusb_lseek,
022e468e139573 Jiri Slaby 2019-01-22 2999 #ifdef CONFIG_COMPAT
^1da177e4c3f41 Linus Torvalds 2005-04-16 3000 .compat_ioctl = sisusb_compat_ioctl,
^1da177e4c3f41 Linus Torvalds 2005-04-16 3001 #endif
49f15255465321 Alan Cox 2008-05-22 3002 .unlocked_ioctl = sisusb_ioctl
^1da177e4c3f41 Linus Torvalds 2005-04-16 3003 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 3004
:::::: The code at line 2996 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61396 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk
2020-05-30 1:48 ` [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk Changming
2020-05-31 22:26 ` kbuild test robot
@ 2020-05-31 22:43 ` kbuild test robot
2020-05-31 22:47 ` kbuild test robot
2 siblings, 0 replies; 13+ messages in thread
From: kbuild test robot @ 2020-05-31 22:43 UTC (permalink / raw)
To: Changming, gregkh
Cc: kbuild-all, clang-built-linux, linux-usb, thomas, Changming Liu
[-- Attachment #1: Type: text/plain, Size: 3913 bytes --]
Hi Changming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Changming/USB-sisusbvga-series-of-changes-char-to-u8/20200601-012438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/usb/misc/sisusbvga/sisusb.c:2996:11: error: incompatible function pointer types initializing 'ssize_t (*)(struct file *, char *, size_t, loff_t *)' (aka 'long (*)(struct file *, char *, unsigned long, long long *)') with an expression of type 'ssize_t (struct file *, u8 *, size_t, loff_t *)' (aka 'long (struct file *, unsigned char *, unsigned long, long long *)') [-Werror,-Wincompatible-function-pointer-types]
.read = sisusb_read,
^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: error: incompatible function pointer types initializing 'ssize_t (*)(struct file *, const char *, size_t, loff_t *)' (aka 'long (*)(struct file *, const char *, unsigned long, long long *)') with an expression of type 'ssize_t (struct file *, const u8 *, size_t, loff_t *)' (aka 'long (struct file *, const unsigned char *, unsigned long, long long *)') [-Werror,-Wincompatible-function-pointer-types]
.write = sisusb_write,
^~~~~~~~~~~~
2 errors generated.
vim +2996 drivers/usb/misc/sisusbvga/sisusb.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2991
066202dd48cf32 Luiz Fernando N. Capitulino 2006-08-05 2992 static const struct file_operations usb_sisusb_fops = {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2993 .owner = THIS_MODULE,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2994 .open = sisusb_open,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2995 .release = sisusb_release,
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2996 .read = sisusb_read,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2997 .write = sisusb_write,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2998 .llseek = sisusb_lseek,
022e468e139573 Jiri Slaby 2019-01-22 2999 #ifdef CONFIG_COMPAT
^1da177e4c3f41 Linus Torvalds 2005-04-16 3000 .compat_ioctl = sisusb_compat_ioctl,
^1da177e4c3f41 Linus Torvalds 2005-04-16 3001 #endif
49f15255465321 Alan Cox 2008-05-22 3002 .unlocked_ioctl = sisusb_ioctl
^1da177e4c3f41 Linus Torvalds 2005-04-16 3003 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 3004
:::::: The code at line 2996 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73536 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk
2020-05-30 1:48 ` [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk Changming
2020-05-31 22:26 ` kbuild test robot
2020-05-31 22:43 ` kbuild test robot
@ 2020-05-31 22:47 ` kbuild test robot
2 siblings, 0 replies; 13+ messages in thread
From: kbuild test robot @ 2020-05-31 22:47 UTC (permalink / raw)
To: Changming, gregkh; +Cc: kbuild-all, linux-usb, thomas, Changming Liu
[-- Attachment #1: Type: text/plain, Size: 11621 bytes --]
Hi Changming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next peter.chen-usb/ci-for-usb-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Changming/USB-sisusbvga-series-of-changes-char-to-u8/20200601-012438
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/usb/misc/sisusbvga/sisusb.c:2996:11: error: initialization of 'ssize_t (*)(struct file *, char *, size_t, loff_t *)' {aka 'int (*)(struct file *, char *, unsigned int, long long int *)'} from incompatible pointer type 'ssize_t (*)(struct file *, u8 *, size_t, loff_t *)' {aka 'int (*)(struct file *, unsigned char *, unsigned int, long long int *)'} [-Werror=incompatible-pointer-types]
2996 | .read = sisusb_read,
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2996:11: note: (near initialization for 'usb_sisusb_fops.read')
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: error: initialization of 'ssize_t (*)(struct file *, const char *, size_t, loff_t *)' {aka 'int (*)(struct file *, const char *, unsigned int, long long int *)'} from incompatible pointer type 'ssize_t (*)(struct file *, const u8 *, size_t, loff_t *)' {aka 'int (*)(struct file *, const unsigned char *, unsigned int, long long int *)'} [-Werror=incompatible-pointer-types]
2997 | .write = sisusb_write,
| ^~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb.c:2997:11: note: (near initialization for 'usb_sisusb_fops.write')
In file included from drivers/usb/misc/sisusbvga/sisusb.c:54:
drivers/usb/misc/sisusbvga/sisusb_init.h:695:34: warning: 'SiSUSB_VCLKData' defined but not used [-Wunused-const-variable=]
695 | static const struct SiS_VCLKData SiSUSB_VCLKData[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:437:35: warning: 'SiSUSB_CRT1Table' defined but not used [-Wunused-const-variable=]
437 | static const struct SiS_CRT1Table SiSUSB_CRT1Table[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:379:30: warning: 'SiSUSB_RefIndex' defined but not used [-Wunused-const-variable=]
379 | static const struct SiS_Ext2 SiSUSB_RefIndex[] = {
| ^~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:300:29: warning: 'SiSUSB_EModeIDTable' defined but not used [-Wunused-const-variable=]
300 | static const struct SiS_Ext SiSUSB_EModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:269:36: warning: 'SiSUSB_StandTable' defined but not used [-Wunused-const-variable=]
269 | static const struct SiS_StandTable SiSUSB_StandTable[] = {
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:232:37: warning: 'SiSUSB_ModeResInfo' defined but not used [-Wunused-const-variable=]
232 | static const struct SiS_ModeResInfo SiSUSB_ModeResInfo[] = {
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:224:37: warning: 'SiSUSB_StResInfo' defined but not used [-Wunused-const-variable=]
224 | static const struct SiS_StResInfo_S SiSUSB_StResInfo[] = {
| ^~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:219:28: warning: 'SiSUSB_SModeIDTable' defined but not used [-Wunused-const-variable=]
219 | static const struct SiS_St SiSUSB_SModeIDTable[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:206:28: warning: 'SiS_VGA_DAC' defined but not used [-Wunused-const-variable=]
206 | static const unsigned char SiS_VGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:195:28: warning: 'SiS_EGA_DAC' defined but not used [-Wunused-const-variable=]
195 | static const unsigned char SiS_EGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:184:28: warning: 'SiS_CGA_DAC' defined but not used [-Wunused-const-variable=]
184 | static const unsigned char SiS_CGA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:173:28: warning: 'SiS_MDA_DAC' defined but not used [-Wunused-const-variable=]
173 | static const unsigned char SiS_MDA_DAC[] = {
| ^~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:171:29: warning: 'ModeIndex_1280x1024' defined but not used [-Wunused-const-variable=]
171 | static const unsigned short ModeIndex_1280x1024[] = { 0x3a, 0x4d, 0x00, 0x65 };
| ^~~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:170:29: warning: 'ModeIndex_1280x768' defined but not used [-Wunused-const-variable=]
170 | static const unsigned short ModeIndex_1280x768[] = { 0x23, 0x24, 0x00, 0x25 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:169:29: warning: 'ModeIndex_1280x720' defined but not used [-Wunused-const-variable=]
169 | static const unsigned short ModeIndex_1280x720[] = { 0x79, 0x75, 0x00, 0x78 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:168:29: warning: 'ModeIndex_1152x864' defined but not used [-Wunused-const-variable=]
168 | static const unsigned short ModeIndex_1152x864[] = { 0x29, 0x2a, 0x00, 0x2b };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:167:29: warning: 'ModeIndex_1024x576' defined but not used [-Wunused-const-variable=]
167 | static const unsigned short ModeIndex_1024x576[] = { 0x71, 0x74, 0x00, 0x77 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:166:29: warning: 'ModeIndex_1024x768' defined but not used [-Wunused-const-variable=]
166 | static const unsigned short ModeIndex_1024x768[] = { 0x38, 0x4a, 0x00, 0x64 };
| ^~~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:165:29: warning: 'ModeIndex_960x600' defined but not used [-Wunused-const-variable=]
165 | static const unsigned short ModeIndex_960x600[] = { 0x20, 0x21, 0x00, 0x22 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:164:29: warning: 'ModeIndex_960x540' defined but not used [-Wunused-const-variable=]
164 | static const unsigned short ModeIndex_960x540[] = { 0x1d, 0x1e, 0x00, 0x1f };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:163:29: warning: 'ModeIndex_856x480' defined but not used [-Wunused-const-variable=]
163 | static const unsigned short ModeIndex_856x480[] = { 0x3f, 0x42, 0x00, 0x45 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:162:29: warning: 'ModeIndex_848x480' defined but not used [-Wunused-const-variable=]
162 | static const unsigned short ModeIndex_848x480[] = { 0x39, 0x3b, 0x00, 0x3e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:161:29: warning: 'ModeIndex_800x600' defined but not used [-Wunused-const-variable=]
161 | static const unsigned short ModeIndex_800x600[] = { 0x30, 0x47, 0x00, 0x63 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:160:29: warning: 'ModeIndex_800x480' defined but not used [-Wunused-const-variable=]
160 | static const unsigned short ModeIndex_800x480[] = { 0x70, 0x7a, 0x00, 0x76 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:159:29: warning: 'ModeIndex_768x576' defined but not used [-Wunused-const-variable=]
159 | static const unsigned short ModeIndex_768x576[] = { 0x5f, 0x60, 0x00, 0x61 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:158:29: warning: 'ModeIndex_720x576' defined but not used [-Wunused-const-variable=]
158 | static const unsigned short ModeIndex_720x576[] = { 0x32, 0x34, 0x00, 0x36 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:157:29: warning: 'ModeIndex_720x480' defined but not used [-Wunused-const-variable=]
157 | static const unsigned short ModeIndex_720x480[] = { 0x31, 0x33, 0x00, 0x35 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:156:29: warning: 'ModeIndex_640x480' defined but not used [-Wunused-const-variable=]
156 | static const unsigned short ModeIndex_640x480[] = { 0x2e, 0x44, 0x00, 0x62 };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:155:29: warning: 'ModeIndex_640x400' defined but not used [-Wunused-const-variable=]
155 | static const unsigned short ModeIndex_640x400[] = { 0x2f, 0x5d, 0x00, 0x5e };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:154:29: warning: 'ModeIndex_512x384' defined but not used [-Wunused-const-variable=]
154 | static const unsigned short ModeIndex_512x384[] = { 0x52, 0x58, 0x00, 0x5c };
| ^~~~~~~~~~~~~~~~~
drivers/usb/misc/sisusbvga/sisusb_init.h:153:29: warning: 'ModeIndex_400x300' defined but not used [-Wunused-const-variable=]
153 | static const unsigned short ModeIndex_400x300[] = { 0x51, 0x57, 0x00, 0x54 };
vim +2996 drivers/usb/misc/sisusbvga/sisusb.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2991
066202dd48cf32 Luiz Fernando N. Capitulino 2006-08-05 2992 static const struct file_operations usb_sisusb_fops = {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2993 .owner = THIS_MODULE,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2994 .open = sisusb_open,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2995 .release = sisusb_release,
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2996 .read = sisusb_read,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2997 .write = sisusb_write,
^1da177e4c3f41 Linus Torvalds 2005-04-16 2998 .llseek = sisusb_lseek,
022e468e139573 Jiri Slaby 2019-01-22 2999 #ifdef CONFIG_COMPAT
^1da177e4c3f41 Linus Torvalds 2005-04-16 3000 .compat_ioctl = sisusb_compat_ioctl,
^1da177e4c3f41 Linus Torvalds 2005-04-16 3001 #endif
49f15255465321 Alan Cox 2008-05-22 3002 .unlocked_ioctl = sisusb_ioctl
^1da177e4c3f41 Linus Torvalds 2005-04-16 3003 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 3004
:::::: The code at line 2996 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65470 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 6/6] USB: sisusbvga: change the local char array to u8 array
2020-05-30 1:48 [PATCH 0/6] USB: sisusbvga: series of changes char to u8 Changming
` (4 preceding siblings ...)
2020-05-30 1:48 ` [PATCH 5/6] USB: sisusbvga: change sisusb_read_mem_bulk Changming
@ 2020-05-30 1:48 ` Changming
5 siblings, 0 replies; 13+ messages in thread
From: Changming @ 2020-05-30 1:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, thomas, Changming Liu
From: Changming Liu <liu.changm@northeastern.edu>
These arrays/data elements are used as unsigned.
So change them from char to u8.
Signed-off-by: Changming Liu <liu.changm@northeastern.edu>
---
drivers/usb/misc/sisusbvga/sisusb.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index 1f21db40fdb5..70a10ad9ae0a 100755
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -1752,22 +1752,22 @@ static void sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
{
int i, j, modex, bpp, du;
u8 sr31, cr63, tmp8;
- static const char attrdata[] = {
+ static const u8 attrdata[] = {
0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
0x01, 0x00, 0x00, 0x00
};
- static const char crtcrdata[] = {
+ static const u8 crtcrdata[] = {
0x5f, 0x4f, 0x50, 0x82, 0x54, 0x80, 0x0b, 0x3e,
0x00, 0x40, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0xea, 0x8c, 0xdf, 0x28, 0x40, 0xe7, 0x04, 0xa3,
0xff
};
- static const char grcdata[] = {
+ static const u8 grcdata[] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x05, 0x0f,
0xff
};
- static const char crtcdata[] = {
+ static const u8 crtcdata[] = {
0x5f, 0x4f, 0x4f, 0x83, 0x55, 0x81, 0x0b, 0x3e,
0xe9, 0x8b, 0xdf, 0xe8, 0x0c, 0x00, 0x00, 0x05,
0x00
@@ -1880,19 +1880,19 @@ static int sisusb_init_gfxcore(struct sisusb_usb_data *sisusb)
int ret = 0, i, j, bw, chab, iret, retry = 3;
u8 tmp8, ramtype;
u32 tmp32;
- static const char mclktable[] = {
+ static const u8 mclktable[] = {
0x3b, 0x22, 0x01, 143,
0x3b, 0x22, 0x01, 143,
0x3b, 0x22, 0x01, 143,
0x3b, 0x22, 0x01, 143
};
- static const char eclktable[] = {
+ static const u8 eclktable[] = {
0x3b, 0x22, 0x01, 143,
0x3b, 0x22, 0x01, 143,
0x3b, 0x22, 0x01, 143,
0x3b, 0x22, 0x01, 143
};
- static const char ramtypetable1[] = {
+ static const u8 ramtypetable1[] = {
0x00, 0x04, 0x60, 0x60,
0x0f, 0x0f, 0x1f, 0x1f,
0xba, 0xba, 0xba, 0xba,
@@ -1901,7 +1901,7 @@ static int sisusb_init_gfxcore(struct sisusb_usb_data *sisusb)
0x00, 0x00, 0x02, 0x02,
0x30, 0x30, 0x40, 0x40
};
- static const char ramtypetable2[] = {
+ static const u8 ramtypetable2[] = {
0x77, 0x77, 0x44, 0x44,
0x77, 0x77, 0x44, 0x44,
0x00, 0x00, 0x00, 0x00,
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread