From: Oliver Neukum <oneukum@suse.com>
To: penguin-kernel@i-love.sakura.ne.jp, bjorn@mork.no,
linux-usb@vger.kernel.org
Cc: Oliver Neukum <oneukum@suse.com>
Subject: [RFC 5/5] CDC-WDM: remove use of intf->dev after potential disconnect
Date: Wed, 12 Aug 2020 15:20:34 +0200 [thread overview]
Message-ID: <20200812132034.14363-6-oneukum@suse.com> (raw)
In-Reply-To: <20200812132034.14363-1-oneukum@suse.com>
After a disconnect intf->dev is not a valid pointer any longer
as flush() uses it only for logging purposes logging is not
worth it. Remove the dev_err()
Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/usb/class/cdc-wdm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
index 6071c9044574..2dcf1fb16f2b 100644
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -616,9 +616,6 @@ static int wdm_flush(struct file *file, fl_owner_t id)
desc->werr = 0;
spin_unlock_irq(&desc->iuspin);
- if (rv < 0)
- dev_err(&desc->intf->dev, "Error in flush path: %d\n", rv);
-
return usb_translate_errors(rv);
}
--
2.16.4
next prev parent reply other threads:[~2020-08-12 13:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 13:20 [RFC 0/5] fix races in CDC-WDM Oliver Neukum
2020-08-12 13:20 ` [RFC 1/5] CDC-WDM: fix hangs in flush() Oliver Neukum
2020-08-12 13:20 ` [RFC 2/5] CDC-WDM: introduce a timeout " Oliver Neukum
2020-08-12 13:20 ` [RFC 3/5] CDC-WDM: making flush() interruptible Oliver Neukum
2020-08-12 13:20 ` [RFC 4/5] CDC-WDM: fix race reporting errors in flush Oliver Neukum
2020-08-12 13:20 ` Oliver Neukum [this message]
2020-08-12 14:29 ` [RFC 0/5] fix races in CDC-WDM Tetsuo Handa
2020-09-10 9:09 ` Oliver Neukum
2020-09-10 10:01 ` Tetsuo Handa
2020-09-15 9:14 ` Oliver Neukum
2020-09-15 10:30 ` Tetsuo Handa
2020-09-16 10:18 ` Oliver Neukum
2020-09-16 11:14 ` Tetsuo Handa
2020-09-17 9:50 ` Oliver Neukum
2020-09-17 11:24 ` Tetsuo Handa
2020-09-17 14:17 ` Oliver Neukum
2020-09-17 16:17 ` Tetsuo Handa
2020-09-21 10:52 ` Oliver Neukum
2020-09-22 1:56 ` Tetsuo Handa
2020-09-22 7:33 ` Oliver Neukum
2020-09-22 8:34 ` Tetsuo Handa
2020-09-22 9:45 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812132034.14363-6-oneukum@suse.com \
--to=oneukum@suse.com \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).