From: Johan Hovold <johan@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] USB: cdc-acm: add Whistler radio scanners TRX series support
Date: Mon, 21 Sep 2020 11:31:45 +0200 [thread overview]
Message-ID: <20200921093145.GS24441@localhost> (raw)
In-Reply-To: <1600677792.2424.61.camel@suse.com>
On Mon, Sep 21, 2020 at 10:43:12AM +0200, Oliver Neukum wrote:
> Am Montag, den 21.09.2020, 10:10 +0200 schrieb Johan Hovold:
> > Add support for Whistler radio scanners TRX series, which have a union
> > descriptor that designates a mass-storage interface as master. Handle
> > that by generalising the NO_DATA_INTERFACE quirk to allow us to fall
> > back to using the combined-interface detection.
>
> Hi,
>
> it amazes me what solutions people can come up with. Yet in this case
> using a quirk looks like an inferior solution. If your master
> is a storage interface, you will have a condition on the device you
> can test for without the need for a quirk.
Sure, and I mentioned that as an alternative, another would be checking
for a control interface with three endpoints directly.
My fear is that any change in this direction risk introducing regression
if there are devices out there with broken descriptors that we currently
happen to support by chance. Then again, probably better to try to
handle any such breakage if/when reported.
I'll respin.
Johan
next prev parent reply other threads:[~2020-09-21 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 8:10 [PATCH v2] USB: cdc-acm: add Whistler radio scanners TRX series support Johan Hovold
2020-09-21 8:43 ` Oliver Neukum
2020-09-21 9:31 ` Johan Hovold [this message]
2020-09-21 10:29 ` Oliver Neukum
2020-09-21 11:36 ` Johan Hovold
2020-09-21 11:49 ` Oliver Neukum
2020-09-21 12:03 ` Johan Hovold
2020-09-21 12:17 ` Oliver Neukum
2020-09-21 13:43 ` Johan Hovold
2020-09-25 14:49 ` Greg Kroah-Hartman
2020-09-25 14:53 ` Johan Hovold
2020-09-25 15:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921093145.GS24441@localhost \
--to=johan@kernel.org \
--cc=f1rmb.daniel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).