linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>, Oliver Neukum <oneukum@suse.com>,
	linux-usb@vger.kernel.org,
	Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] USB: cdc-acm: add Whistler radio scanners TRX series support
Date: Fri, 25 Sep 2020 16:53:31 +0200	[thread overview]
Message-ID: <20200925145331.GL24441@localhost> (raw)
In-Reply-To: <20200925144922.GA3113925@kroah.com>

On Fri, Sep 25, 2020 at 04:49:22PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 21, 2020 at 10:10:22AM +0200, Johan Hovold wrote:
> > Add support for Whistler radio scanners TRX series, which have a union
> > descriptor that designates a mass-storage interface as master. Handle
> > that by generalising the NO_DATA_INTERFACE quirk to allow us to fall
> > back to using the combined-interface detection.
> > 
> > Note that the NO_DATA_INTERFACE quirk was added by commit fd5054c169d2
> > ("USB: cdc_acm: Fix oops when Droids MuIn LCD is connected") to handle a
> > combined-interface-type device with a broken call-management descriptor
> > by hardcoding the "data" interface number.
> > 
> > Link: https://lore.kernel.org/r/5f4ca4f8.1c69fb81.a4487.0f5f@mx.google.com
> > Reported-by: Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>
> > Tested-by: Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > 
> > v2
> >  - use the right class define in the device-id table (not subclass with
> >    same value)
> 
> Is this independant of your other patch series for cdc-acm?

This one is superseded by the series, so please drop this patch. Sorry
for not making that clear.

Johan

  reply	other threads:[~2020-09-25 14:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21  8:10 [PATCH v2] USB: cdc-acm: add Whistler radio scanners TRX series support Johan Hovold
2020-09-21  8:43 ` Oliver Neukum
2020-09-21  9:31   ` Johan Hovold
2020-09-21 10:29     ` Oliver Neukum
2020-09-21 11:36       ` Johan Hovold
2020-09-21 11:49         ` Oliver Neukum
2020-09-21 12:03           ` Johan Hovold
2020-09-21 12:17             ` Oliver Neukum
2020-09-21 13:43               ` Johan Hovold
2020-09-25 14:49 ` Greg Kroah-Hartman
2020-09-25 14:53   ` Johan Hovold [this message]
2020-09-25 15:00     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925145331.GL24441@localhost \
    --to=johan@kernel.org \
    --cc=f1rmb.daniel@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).