* [PATCH 6/6] USB: cdc-acm: blacklist ETAS ES58X device [not found] <20200926174542.278166-1-mailhol.vincent@wanadoo.fr> @ 2020-09-26 17:45 ` Vincent Mailhol 0 siblings, 0 replies; 5+ messages in thread From: Vincent Mailhol @ 2020-09-26 17:45 UTC (permalink / raw) To: linux-can, Wolfgang Grandegger, Marc Kleine-Budde, David S . Miller Cc: Vincent Mailhol, Oliver Neukum, Greg Kroah-Hartman, linux-usb, linux-kernel The ES58X devices are incorrectly recognized as USB Modem (CDC ACM), preventing the etas-es58x module to load. Thus, these have been added to the ignore list in drivers/usb/class/cdc-acm.c Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> --- drivers/usb/class/cdc-acm.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 7f6f3ab5b8a6..ed9355094e8c 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1906,6 +1906,17 @@ static const struct usb_device_id acm_ids[] = { .driver_info = IGNORE_DEVICE, }, + /* Exclude ETAS ES58x */ + { USB_DEVICE(0x108c, 0x0159), /* ES581.4 */ + .driver_info = IGNORE_DEVICE, + }, + { USB_DEVICE(0x108c, 0x0168), /* ES582.1 */ + .driver_info = IGNORE_DEVICE, + }, + { USB_DEVICE(0x108c, 0x0169), /* ES584.1 */ + .driver_info = IGNORE_DEVICE, + }, + { USB_DEVICE(0x1bc7, 0x0021), /* Telit 3G ACM only composition */ .driver_info = SEND_ZERO_PACKET, }, -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <20200926175810.278529-1-mailhol.vincent@wanadoo.fr>]
* [PATCH 6/6] USB: cdc-acm: blacklist ETAS ES58X device [not found] <20200926175810.278529-1-mailhol.vincent@wanadoo.fr> @ 2020-09-26 17:57 ` Vincent Mailhol 2020-09-27 5:45 ` Greg Kroah-Hartman 0 siblings, 1 reply; 5+ messages in thread From: Vincent Mailhol @ 2020-09-26 17:57 UTC (permalink / raw) To: linux-kernel, netdev, linux-can, Wolfgang Grandegger, Marc Kleine-Budde, David S . Miller Cc: Vincent Mailhol, Oliver Neukum, Greg Kroah-Hartman, linux-usb The ES58X devices are incorrectly recognized as USB Modem (CDC ACM), preventing the etas-es58x module to load. Thus, these have been added to the ignore list in drivers/usb/class/cdc-acm.c Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> --- drivers/usb/class/cdc-acm.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 7f6f3ab5b8a6..ed9355094e8c 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1906,6 +1906,17 @@ static const struct usb_device_id acm_ids[] = { .driver_info = IGNORE_DEVICE, }, + /* Exclude ETAS ES58x */ + { USB_DEVICE(0x108c, 0x0159), /* ES581.4 */ + .driver_info = IGNORE_DEVICE, + }, + { USB_DEVICE(0x108c, 0x0168), /* ES582.1 */ + .driver_info = IGNORE_DEVICE, + }, + { USB_DEVICE(0x108c, 0x0169), /* ES584.1 */ + .driver_info = IGNORE_DEVICE, + }, + { USB_DEVICE(0x1bc7, 0x0021), /* Telit 3G ACM only composition */ .driver_info = SEND_ZERO_PACKET, }, -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 6/6] USB: cdc-acm: blacklist ETAS ES58X device 2020-09-26 17:57 ` Vincent Mailhol @ 2020-09-27 5:45 ` Greg Kroah-Hartman 2020-09-27 5:52 ` Greg Kroah-Hartman 0 siblings, 1 reply; 5+ messages in thread From: Greg Kroah-Hartman @ 2020-09-27 5:45 UTC (permalink / raw) To: Vincent Mailhol Cc: linux-kernel, netdev, linux-can, Wolfgang Grandegger, Marc Kleine-Budde, David S . Miller, Oliver Neukum, linux-usb On Sun, Sep 27, 2020 at 02:57:56AM +0900, Vincent Mailhol wrote: > The ES58X devices are incorrectly recognized as USB Modem (CDC ACM), > preventing the etas-es58x module to load. > > Thus, these have been added > to the ignore list in drivers/usb/class/cdc-acm.c > > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> > --- > drivers/usb/class/cdc-acm.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) Did you mean to send this twice? And where are the 5 other patches in this series? And finally, it's a good idea to include the output of 'lsusb -v' for devices that need quirks so we can figure things out later on, can you fix up your changelog to include that information? thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/6] USB: cdc-acm: blacklist ETAS ES58X device 2020-09-27 5:45 ` Greg Kroah-Hartman @ 2020-09-27 5:52 ` Greg Kroah-Hartman 2020-09-29 2:15 ` Vincent Mailhol 0 siblings, 1 reply; 5+ messages in thread From: Greg Kroah-Hartman @ 2020-09-27 5:52 UTC (permalink / raw) To: Vincent Mailhol Cc: linux-kernel, netdev, linux-can, Wolfgang Grandegger, Marc Kleine-Budde, David S . Miller, Oliver Neukum, linux-usb On Sun, Sep 27, 2020 at 07:45:20AM +0200, Greg Kroah-Hartman wrote: > On Sun, Sep 27, 2020 at 02:57:56AM +0900, Vincent Mailhol wrote: > > The ES58X devices are incorrectly recognized as USB Modem (CDC ACM), > > preventing the etas-es58x module to load. > > > > Thus, these have been added > > to the ignore list in drivers/usb/class/cdc-acm.c > > > > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> > > --- > > drivers/usb/class/cdc-acm.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > Did you mean to send this twice? > > And where are the 5 other patches in this series? > > And finally, it's a good idea to include the output of 'lsusb -v' for > devices that need quirks so we can figure things out later on, can you > fix up your changelog to include that information? Also, why is the device saying it is a cdc-acm compliant device when it is not? Why lie to the operating system like that? thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/6] USB: cdc-acm: blacklist ETAS ES58X device 2020-09-27 5:52 ` Greg Kroah-Hartman @ 2020-09-29 2:15 ` Vincent Mailhol 0 siblings, 0 replies; 5+ messages in thread From: Vincent Mailhol @ 2020-09-29 2:15 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Vincent Mailhol, linux-kernel, netdev, linux-can, Wolfgang Grandegger, Marc Kleine-Budde, David S . Miller, Oliver Neukum, linux-usb, Arunachalam Santhanam > > Did you mean to send this twice? Sorry for that, I screwed things up a first time when sending the patches: only included the CAN mailing list (linux-can@vger.kernel.org) but ommitted linux-kernel@vger.kernel.org in the cover letter. As a result, it broke the chain reply on lkml.org so I preferred to resend it. > > And where are the 5 other patches in this series? I used the --cc-cmd="scripts/get_maintainer.pl -i" option in git send-email to send the series. The five other patches are not related to USB core but to CAN core, so you were not included in CC by the script. Now, I understand this is confusing, I will take care to CC you on the full series when sending V2. One more time, sorry for that. For your information, the full patch series is available here: https://lkml.org/lkml/2020/9/26/319 > > And finally, it's a good idea to include the output of 'lsusb -v' for > > devices that need quirks so we can figure things out later on, can you > > fix up your changelog to include that information? Noted, will be included in v2 of the patch series. > Also, why is the device saying it is a cdc-acm compliant device when it > is not? Why lie to the operating system like that? This is a leftover debug feature used during development. Future firmware version will have it remove but users with older revision will still face this issue which can be confusing. I will also amend the changelog to better reflect above reason. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-29 2:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200926174542.278166-1-mailhol.vincent@wanadoo.fr>
2020-09-26 17:45 ` [PATCH 6/6] USB: cdc-acm: blacklist ETAS ES58X device Vincent Mailhol
[not found] <20200926175810.278529-1-mailhol.vincent@wanadoo.fr>
2020-09-26 17:57 ` Vincent Mailhol
2020-09-27 5:45 ` Greg Kroah-Hartman
2020-09-27 5:52 ` Greg Kroah-Hartman
2020-09-29 2:15 ` Vincent Mailhol
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).