Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

From: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
To: Lars Melin <larsm17@gmail.com>
Cc: "Johan Hovold" <johan@kernel.org>,
	linux-kernel@vger.kernel.org, "Bjørn Mork" <bjorn@mork.no>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card
Date: Mon, 5 Oct 2020 14:07:23 +0200	[thread overview]
Message-ID: <20201005140723.56f6c434@monster.powergraphx.local> (raw)
In-Reply-To: <5222246c-08d7-dcf8-248d-c1fefc72c46f@gmail.com>

On Mon, 5 Oct 2020 18:36:36 +0700
Lars Melin <larsm17@gmail.com> wrote:

> On 10/5/2020 18:06, Johan Hovold wrote:
> > On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote:
> >> On Mon, 5 Oct 2020 10:20:45 +0200
> >> Johan Hovold <johan@kernel.org> wrote:
> >>
> >>> On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote:
> >>>> Add usb ids of the Cellient MPL200 card.
> >>>>
> >>>> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> >>>> ---
> > 
> >>>> @@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
> >>>>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2,
> >>>> 0xff, 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> >>>> MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID,
> >>>> CELLIENT_PRODUCT_MEN200) },
> >>>> +	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
> >>>> +	  .driver_info = RSVD(1) | RSVD(4) },
> >>>
> >>> Would you mind posting the output of "lsusb -v" for this device?
> >>
> >> I would like to, but unfortunately I lost access to this really rare hardware
> >> about a month ago. It is a Qualcomm device (0x05c6:0x9025) with a slightly
> >> modified firmware to rebrand it as a Cellient product with a different vendor
> >> id. How to proceed here, if I have no access to it anymore? Drop it?
> > 
> > No, that's ok, I've applied the patch now. It's just that in case we
> > ever need to revisit the handling of quirky devices, it has proven
> > useful to have a record the descriptors.
> > 
> > Do you remember the interface layout and why you blacklisted interface
> > 1?
> > 
> > Johan
> > 
> 
> It is very likely that Cellient has replaced the VID with their own and 
> kept the PID, it is something other mfgrs has done when buying modules 
> from Qualcomm's series of devices with predefined composition.
> 
> The MS Windows driver for 05c6:9025 describes the interfaces as:
> 
> MI_00 Qualcomm HS-USB Diagnostics 9025
> MI_01 Android Composite ADB Interface
> MI_02 Qualcomm HS-USB Android Modem 9025
> MI_03 Qualcomm HS-USB NMEA 9025
> MI_04 Qualcomm Wireless HS-USB Ethernet Adapter 9025
> MI_05 USB Mass Storage Device
> 
> where the net interface is for QMI/RMNET.
> It fully matches the blacklisting Wilken has done for 2692:9025

Does your device have a GPS connector? Mine had not and I'm not sure
if the description of MI_01 is actually correct. I remember looking at
this port and seeing bogus NMEA data.

greetings,
Will