linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
Cc: linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card
Date: Mon, 05 Oct 2020 12:07:12 +0200	[thread overview]
Message-ID: <87eemdnfzj.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20201004203042.093ac473@monster.powergraphx.local> (Wilken Gottwalt's message of "Sun, 4 Oct 2020 20:30:42 +0200")

Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:

> Oh sorry, looks like I got it mixed up a bit. It was my first attempt to submit
> a patch set. Which is the best way to resubmit an update if the other part of
> the patch set gets accepted? The documentation about re-/submitting patch sets
> is a bit thin.

I see that Johan already has answered this.  Just wanted to add that you
don't need to worry about doing anything wrong.  It was not my intention
to scare you :-) Fixing up and resending patches is a natural part of
the patch submission process.  Don't be afraid to resubmit.  The worst
that can happen is that you'll be asked to fix up something else.
That's not a problem.

The most important part is to make it clear that a resubmission replaces
an earlier version of the same patch.  This should be visible in the
subject.  E.g by using a revision number inside the brackes, like

  [PATCH v2] net: qmi_wwan: add Cellient MPL200 card

This tells us that the patch is a revised "v2" of an earlier patch, and
that it replaces "v1".  Patches without an explicit revision will then
be assumed to be "v1".

If you are sending a series, then the whole series should usually be
resubmitted with the new revsion number.  Even patches without any
changes. The cover letter should then also summarize the changes for
each revisions.  But as Johan said: The USB serial and net patches go
through different trees and are therefore best handled as standalone
patches, even if they deal with the same USB composite device. 


Bjørn

  parent reply	other threads:[~2020-10-05 10:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-03  9:39 [PATCH 0/2] add Cellient MPL200 card Wilken Gottwalt
2020-10-03  9:39 ` [PATCH 1/2] usb: serial: qmi_wwan: " Wilken Gottwalt
2020-10-04 15:29   ` Bjørn Mork
2020-10-04 18:30     ` Wilken Gottwalt
2020-10-05  8:06       ` Johan Hovold
2020-10-05  8:19         ` Johan Hovold
2020-10-05 10:07       ` Bjørn Mork [this message]
2020-10-03  9:40 ` [PATCH 2/2] usb: serial: option: " Wilken Gottwalt
2020-10-05  8:20   ` Johan Hovold
2020-10-05 11:01     ` Wilken Gottwalt
2020-10-05 11:06       ` Johan Hovold
2020-10-05 11:36         ` Lars Melin
2020-10-05 12:07           ` Wilken Gottwalt
2020-10-06  7:02             ` Johan Hovold
2020-10-08  6:47               ` Wilken Gottwalt
2020-10-08  7:16                 ` Johan Hovold
2020-10-05 12:02         ` Wilken Gottwalt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eemdnfzj.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wilken.gottwalt@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).