linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] add Cellient MPL200 card
@ 2020-10-08  7:21 Wilken Gottwalt
  2020-10-08  7:21 ` [PATCH v2 1/2] net: usb: qmi_wwan: " Wilken Gottwalt
  2020-10-08  7:22 ` [PATCH v2 2/2] usb: serial: option: " Wilken Gottwalt
  0 siblings, 2 replies; 8+ messages in thread
From: Wilken Gottwalt @ 2020-10-08  7:21 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjørn Mork, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Add the Cellient MPL200 card to usb/qmi_wwan and serial/option. The
serial/option patch got already applied.

Changes v2:
Picked proper subject for qmi_wwan patch, moved the MPL200 device to
the section of the combined devices and changed the comment about the
device to be more precise.

Wilken Gottwalt (2):
  net: usb: qmi_wwan: add Cellient MPL200 card
  usb: serial: option: add Cellient MPL200 card

 drivers/net/usb/qmi_wwan.c  | 1 +
 drivers/usb/serial/option.c | 3 +++
 2 files changed, 4 insertions(+)

-- 
2.28.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
  2020-10-08  7:21 [PATCH v2 0/2] add Cellient MPL200 card Wilken Gottwalt
@ 2020-10-08  7:21 ` Wilken Gottwalt
  2020-10-08  8:07   ` Bjørn Mork
  2020-10-08  7:22 ` [PATCH v2 2/2] usb: serial: option: " Wilken Gottwalt
  1 sibling, 1 reply; 8+ messages in thread
From: Wilken Gottwalt @ 2020-10-08  7:21 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjørn Mork, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Add usb ids of the Cellient MPL200 card.

Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 07c42c0719f5..5ca1356b8656 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1375,6 +1375,7 @@ static const struct usb_device_id products[] = {
 	{QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)},	/* Fibocom NL678 series */
 	{QMI_FIXED_INTF(0x0489, 0xe0b4, 0)},	/* Foxconn T77W968 LTE */
 	{QMI_FIXED_INTF(0x0489, 0xe0b5, 0)},	/* Foxconn T77W968 LTE with eSIM support*/
+	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},    /* Cellient MPL200 (rebranded Qualcomm 05c6:9025) */
 
 	/* 4. Gobi 1000 devices */
 	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-08  7:21 [PATCH v2 0/2] add Cellient MPL200 card Wilken Gottwalt
  2020-10-08  7:21 ` [PATCH v2 1/2] net: usb: qmi_wwan: " Wilken Gottwalt
@ 2020-10-08  7:22 ` Wilken Gottwalt
  2020-10-08  7:31   ` Johan Hovold
  1 sibling, 1 reply; 8+ messages in thread
From: Wilken Gottwalt @ 2020-10-08  7:22 UTC (permalink / raw)
  To: linux-kernel
  Cc: Bjørn Mork, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Add usb ids of the Cellient MPL200 card.

Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
---
 drivers/usb/serial/option.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 0c6f160a214a..a65e620b2277 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -528,6 +528,7 @@ static void option_instat_callback(struct urb *urb);
 /* Cellient products */
 #define CELLIENT_VENDOR_ID			0x2692
 #define CELLIENT_PRODUCT_MEN200			0x9005
+#define CELLIENT_PRODUCT_MPL200			0x9025
 
 /* Hyundai Petatel Inc. products */
 #define PETATEL_VENDOR_ID			0x1ff4
@@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x02, 0x01) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) },
 	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
+	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200),
+	  .driver_info = RSVD(1) | RSVD(4) },
 	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) },
 	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, TPLINK_PRODUCT_LTE, 0xff, 0x00, 0x00) },	/* TP-Link LTE Module */
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] usb: serial: option: add Cellient MPL200 card
  2020-10-08  7:22 ` [PATCH v2 2/2] usb: serial: option: " Wilken Gottwalt
@ 2020-10-08  7:31   ` Johan Hovold
  0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2020-10-08  7:31 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: linux-kernel, Bjørn Mork, David S. Miller, Jakub Kicinski,
	Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb

On Thu, Oct 08, 2020 at 09:22:19AM +0200, Wilken Gottwalt wrote:
> Add usb ids of the Cellient MPL200 card.
> 
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> ---

So I had already applied this one (which didn't change since v1).

Thanks again.

Johan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
  2020-10-08  7:21 ` [PATCH v2 1/2] net: usb: qmi_wwan: " Wilken Gottwalt
@ 2020-10-08  8:07   ` Bjørn Mork
  2020-10-08 16:56     ` Jakub Kicinski
  0 siblings, 1 reply; 8+ messages in thread
From: Bjørn Mork @ 2020-10-08  8:07 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: linux-kernel, David S. Miller, Jakub Kicinski, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:

> Add usb ids of the Cellient MPL200 card.
>
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> ---
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 07c42c0719f5..5ca1356b8656 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1375,6 +1375,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)},	/* Fibocom NL678 series */
>  	{QMI_FIXED_INTF(0x0489, 0xe0b4, 0)},	/* Foxconn T77W968 LTE */
>  	{QMI_FIXED_INTF(0x0489, 0xe0b5, 0)},	/* Foxconn T77W968 LTE with eSIM support*/
> +	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},    /* Cellient MPL200 (rebranded Qualcomm 05c6:9025) */
>  
>  	/* 4. Gobi 1000 devices */
>  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */


Thanks.  Looks nice now.

Acked-by: Bjørn Mork <bjorn@mork.no>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
  2020-10-08  8:07   ` Bjørn Mork
@ 2020-10-08 16:56     ` Jakub Kicinski
  2020-10-08 17:10       ` Bjørn Mork
  0 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2020-10-08 16:56 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: Wilken Gottwalt, linux-kernel, David S. Miller, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

On Thu, 08 Oct 2020 10:07:20 +0200 Bjørn Mork wrote:
> Wilken Gottwalt <wilken.gottwalt@mailbox.org> writes:
> > Add usb ids of the Cellient MPL200 card.
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@mailbox.org>
> > ---
> >  drivers/net/usb/qmi_wwan.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 07c42c0719f5..5ca1356b8656 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -1375,6 +1375,7 @@ static const struct usb_device_id products[] = {
> >  	{QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)},	/* Fibocom NL678 series */
> >  	{QMI_FIXED_INTF(0x0489, 0xe0b4, 0)},	/* Foxconn T77W968 LTE */
> >  	{QMI_FIXED_INTF(0x0489, 0xe0b5, 0)},	/* Foxconn T77W968 LTE with eSIM support*/
> > +	{QMI_FIXED_INTF(0x2692, 0x9025, 4)},    /* Cellient MPL200 (rebranded Qualcomm 05c6:9025) */
> >  
> >  	/* 4. Gobi 1000 devices */
> >  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */  
> 
> Thanks.  Looks nice now.
> 
> Acked-by: Bjørn Mork <bjorn@mork.no>

I'm guessing that I'm supposed to take this patch into the networking
tree, correct?

Is this net or net-next candidate? Bjørn?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
  2020-10-08 16:56     ` Jakub Kicinski
@ 2020-10-08 17:10       ` Bjørn Mork
  2020-10-08 21:27         ` Jakub Kicinski
  0 siblings, 1 reply; 8+ messages in thread
From: Bjørn Mork @ 2020-10-08 17:10 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Wilken Gottwalt, linux-kernel, David S. Miller, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

Jakub Kicinski <kuba@kernel.org> writes:

> I'm guessing that I'm supposed to take this patch into the networking
> tree, correct?

Correct.

> Is this net or net-next candidate? Bjørn?

Sorry, should have made that explicit. This is for net + stable

Thanks.


Bjørn

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
  2020-10-08 17:10       ` Bjørn Mork
@ 2020-10-08 21:27         ` Jakub Kicinski
  0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2020-10-08 21:27 UTC (permalink / raw)
  To: Bjørn Mork
  Cc: Wilken Gottwalt, linux-kernel, David S. Miller, Johan Hovold,
	Greg Kroah-Hartman, netdev, linux-usb

On Thu, 08 Oct 2020 19:10:57 +0200 Bjørn Mork wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> 
> > I'm guessing that I'm supposed to take this patch into the networking
> > tree, correct?  
> 
> Correct.
> 
> > Is this net or net-next candidate? Bjørn?  
> 
> Sorry, should have made that explicit. This is for net + stable

Done, thank you!

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-10-08 21:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08  7:21 [PATCH v2 0/2] add Cellient MPL200 card Wilken Gottwalt
2020-10-08  7:21 ` [PATCH v2 1/2] net: usb: qmi_wwan: " Wilken Gottwalt
2020-10-08  8:07   ` Bjørn Mork
2020-10-08 16:56     ` Jakub Kicinski
2020-10-08 17:10       ` Bjørn Mork
2020-10-08 21:27         ` Jakub Kicinski
2020-10-08  7:22 ` [PATCH v2 2/2] usb: serial: option: " Wilken Gottwalt
2020-10-08  7:31   ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).