* [PATCH] usb: gadget: function: printer: Fix usb function descriptors leak
@ 2020-10-14 7:55 Zqiang
2020-10-14 8:12 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Zqiang @ 2020-10-14 7:55 UTC (permalink / raw)
To: balbi, gregkh; +Cc: linux-usb, linux-kernel
If an error occurs after call 'usb_assign_descriptors' func, the
'usb_free_all_descriptors' need to be call to release memory space
occupied by function descriptors.
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
---
drivers/usb/gadget/function/f_printer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index 64a4112068fc..2f1eb2e81d30 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -1162,6 +1162,7 @@ static int printer_func_bind(struct usb_configuration *c,
printer_req_free(dev->in_ep, req);
}
+ usb_free_all_descriptors(f);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: function: printer: Fix usb function descriptors leak
2020-10-14 7:55 [PATCH] usb: gadget: function: printer: Fix usb function descriptors leak Zqiang
@ 2020-10-14 8:12 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-10-14 8:12 UTC (permalink / raw)
To: Zqiang; +Cc: balbi, linux-usb, linux-kernel
On Wed, Oct 14, 2020 at 03:55:23PM +0800, Zqiang wrote:
> If an error occurs after call 'usb_assign_descriptors' func, the
> 'usb_free_all_descriptors' need to be call to release memory space
> occupied by function descriptors.
>
> Signed-off-by: Zqiang <qiang.zhang@windriver.com>
Please use your ful name for the From: and signed-off-by lines, as the
documentation states is required. If this is your full name, then why
does it not match the name on your email address from your employer?
> ---
> drivers/usb/gadget/function/f_printer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
> index 64a4112068fc..2f1eb2e81d30 100644
> --- a/drivers/usb/gadget/function/f_printer.c
> +++ b/drivers/usb/gadget/function/f_printer.c
> @@ -1162,6 +1162,7 @@ static int printer_func_bind(struct usb_configuration *c,
> printer_req_free(dev->in_ep, req);
> }
>
> + usb_free_all_descriptors(f);
What commit caused this problem?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] usb: gadget: function: printer: Fix usb function descriptors leak
@ 2020-10-14 8:28 qiang.zhang
0 siblings, 0 replies; 3+ messages in thread
From: qiang.zhang @ 2020-10-14 8:28 UTC (permalink / raw)
To: balbi, gregkh; +Cc: linux-usb, linux-kernel
From: Zqiang <qiang.zhang@windriver.com>
If an error occurs after call 'usb_assign_descriptors' func, the
'usb_free_all_descriptors' need to be call to release memory space
occupied by function descriptors.
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
---
drivers/usb/gadget/function/f_printer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index 64a4112068fc..2f1eb2e81d30 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -1162,6 +1162,7 @@ static int printer_func_bind(struct usb_configuration *c,
printer_req_free(dev->in_ep, req);
}
+ usb_free_all_descriptors(f);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-14 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 7:55 [PATCH] usb: gadget: function: printer: Fix usb function descriptors leak Zqiang
2020-10-14 8:12 ` Greg KH
2020-10-14 8:28 qiang.zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).