From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: JC Kuo <jckuo@nvidia.com>,
gregkh@linuxfoundation.org, jonathanh@nvidia.com, kishon@ti.com,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
nkristam@nvidia.com
Subject: Re: [PATCH v4 10/16] dt-bindings: phy: tegra-xusb: Add nvidia,pmc prop
Date: Fri, 13 Nov 2020 17:20:43 +0100 [thread overview]
Message-ID: <20201113162043.GD1408970@ulmo> (raw)
In-Reply-To: <20201019214046.GA3645734@bogus>
[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]
On Mon, Oct 19, 2020 at 04:40:46PM -0500, Rob Herring wrote:
> On Fri, Oct 16, 2020 at 09:07:20PM +0800, JC Kuo wrote:
> > This commit describes the "nvidia,pmc" property for Tegra210 tegra-xusb
> > PHY driver. It is a phandle and specifier referring to the Tegra210
> > pmc@7000e400 node.
> >
> > Signed-off-by: JC Kuo <jckuo@nvidia.com>
> > ---
> > v4:
> > new change to document "nvidia,pmc" prop
> >
> > .../devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> > index 38c5fa21f435..ea559baeb546 100644
> > --- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> > +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> > @@ -54,6 +54,7 @@ For Tegra210:
> > - avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> > - dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> > - hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
> > +- nvidia,pmc: phandle and specifier referring to the Tegra210 pmc@7000e400 node.
>
> 'Tegra210 pmc@7000e400' is kind of specific. Going to update this for
> every address and chip?
>
> If there's only one PMC, you can just find the compatible PMC node. Then
> you don't need a DT update.
I did advise against doing the lookup by compatible string because I
think it has a couple of downsides. On one hand it's going to create an
additional maintenance burden on the XUSB pad controller driver because
the PMC is usually not compatible between SoC versions, so for every new
SoC generation we'll have to add the PMC compatible string to the XUSB
pad controller driver.
On the other hand, this is new functionality and we can easily gate that
on the existence of this phandle, so it doesn't impact DT backwards
compatibility. That also has the advantage of explicitly listing the
dependency between the PMC and the XUSB pad controller in DT, so if we
ever do get around to come up with an even better mechanism to resolve
these dependencies than deferred probe, we do have the data already
available.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-13 16:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 13:07 [PATCH v4 00/16] Tegra XHCI controller ELPG support JC Kuo
2020-10-16 13:07 ` [PATCH v4 01/16] clk: tegra: Add PLLE HW power sequencer control JC Kuo
2020-10-16 13:07 ` [PATCH v4 02/16] clk: tegra: Don't enable PLLE HW sequencer at init JC Kuo
2020-10-16 13:07 ` [PATCH v4 03/16] phy: tegra: xusb: Move usb3 port init for Tegra210 JC Kuo
2020-10-16 13:07 ` [PATCH v4 04/16] phy: tegra: xusb: tegra210: Do not reset UPHY PLL JC Kuo
2020-10-16 13:07 ` [PATCH v4 05/16] phy: tegra: xusb: Rearrange UPHY init on Tegra210 JC Kuo
2020-10-16 13:07 ` [PATCH v4 06/16] phy: tegra: xusb: Add Tegra210 lane_iddq operation JC Kuo
2020-10-16 13:07 ` [PATCH v4 07/16] phy: tegra: xusb: Add sleepwalk and suspend/resume JC Kuo
2020-10-16 13:07 ` [PATCH v4 08/16] soc/tegra: pmc: Provide USB sleepwalk register map JC Kuo
2020-10-16 13:07 ` [PATCH v4 09/16] arm64: tegra210: XUSB PADCTL add "nvidia,pmc" prop JC Kuo
2020-10-16 13:07 ` [PATCH v4 10/16] dt-bindings: phy: tegra-xusb: Add nvidia,pmc prop JC Kuo
2020-10-19 21:40 ` Rob Herring
2020-10-28 9:18 ` JC Kuo
2020-11-13 16:20 ` Thierry Reding [this message]
2020-11-19 5:28 ` JC Kuo
2020-10-16 13:07 ` [PATCH v4 11/16] phy: tegra: xusb: Add wake/sleepwalk for Tegra210 JC Kuo
2020-10-16 13:07 ` [PATCH v4 12/16] phy: tegra: xusb: Tegra210 host mode VBUS control JC Kuo
2020-10-16 13:07 ` [PATCH v4 13/16] phy: tegra: xusb: Add wake/sleepwalk for Tegra186 JC Kuo
2020-10-16 13:07 ` [PATCH v4 14/16] arm64: tegra210/tegra186/tegra194: XUSB PADCTL irq JC Kuo
2020-10-16 13:07 ` [PATCH v4 15/16] usb: host: xhci-tegra: Unlink power domain devices JC Kuo
2020-10-16 13:07 ` [PATCH v4 16/16] xhci: tegra: Enable ELPG for runtime/system PM JC Kuo
2020-10-27 6:10 ` kernel test robot
2020-11-13 16:44 ` [PATCH v4 00/16] Tegra XHCI controller ELPG support Thierry Reding
2020-11-17 6:14 ` JC Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113162043.GD1408970@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nkristam@nvidia.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).