* [PATCH v2] usb: roles: Call try_module_get() from usb_role_switch_find_by_fwnode()
@ 2021-04-09 12:41 Hans de Goede
2021-04-09 13:07 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2021-04-09 12:41 UTC (permalink / raw)
To: Greg Kroah-Hartman, Guenter Roeck, Heikki Krogerus
Cc: Hans de Goede, linux-usb
usb_role_switch_find_by_fwnode() returns a reference to the role-switch
which must be put by calling usb_role_switch_put().
usb_role_switch_put() calls module_put(sw->dev.parent->driver->owner),
add a matching try_module_get() to usb_role_switch_find_by_fwnode(),
making it behave the same as the other usb_role_switch functions
which return a reference.
This avoids a WARN_ON being hit at kernel/module.c:1158 due to the
module-refcount going below 0.
Fixes: c6919d5e0cd1 ("usb: roles: Add usb_role_switch_find_by_fwnode()")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
- Fix typo in Subject
- Add Fixes tag
---
drivers/usb/roles/class.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
index 97f37077b7f9..33b637d0d8d9 100644
--- a/drivers/usb/roles/class.c
+++ b/drivers/usb/roles/class.c
@@ -189,6 +189,8 @@ usb_role_switch_find_by_fwnode(const struct fwnode_handle *fwnode)
return NULL;
dev = class_find_device_by_fwnode(role_class, fwnode);
+ if (dev)
+ WARN_ON(!try_module_get(dev->parent->driver->owner));
return dev ? to_role_switch(dev) : NULL;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: roles: Call try_module_get() from usb_role_switch_find_by_fwnode()
2021-04-09 12:41 [PATCH v2] usb: roles: Call try_module_get() from usb_role_switch_find_by_fwnode() Hans de Goede
@ 2021-04-09 13:07 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2021-04-09 13:07 UTC (permalink / raw)
To: Hans de Goede; +Cc: Greg Kroah-Hartman, Guenter Roeck, linux-usb
On Fri, Apr 09, 2021 at 02:41:36PM +0200, Hans de Goede wrote:
> usb_role_switch_find_by_fwnode() returns a reference to the role-switch
> which must be put by calling usb_role_switch_put().
>
> usb_role_switch_put() calls module_put(sw->dev.parent->driver->owner),
> add a matching try_module_get() to usb_role_switch_find_by_fwnode(),
> making it behave the same as the other usb_role_switch functions
> which return a reference.
>
> This avoids a WARN_ON being hit at kernel/module.c:1158 due to the
> module-refcount going below 0.
>
> Fixes: c6919d5e0cd1 ("usb: roles: Add usb_role_switch_find_by_fwnode()")
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changes in v2:
> - Fix typo in Subject
> - Add Fixes tag
> ---
> drivers/usb/roles/class.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
> index 97f37077b7f9..33b637d0d8d9 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -189,6 +189,8 @@ usb_role_switch_find_by_fwnode(const struct fwnode_handle *fwnode)
> return NULL;
>
> dev = class_find_device_by_fwnode(role_class, fwnode);
> + if (dev)
> + WARN_ON(!try_module_get(dev->parent->driver->owner));
>
> return dev ? to_role_switch(dev) : NULL;
> }
> --
> 2.30.2
thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 12:41 [PATCH v2] usb: roles: Call try_module_get() from usb_role_switch_find_by_fwnode() Hans de Goede
2021-04-09 13:07 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).