From: Kyle Tso <kyletso@google.com>
To: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, robh+dt@kernel.org
Cc: badhri@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Kyle Tso <kyletso@google.com>
Subject: [PATCH v2 0/3] Add the support of SVDM Version 2.0 VDOs
Date: Mon, 31 May 2021 17:57:34 +0800 [thread overview]
Message-ID: <20210531095737.2258642-1-kyletso@google.com> (raw)
Got the Ack by Heikki so I re-examined the patches and found a *stupid*
bug in the patch "usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM
version 1.0" that I separate the "for loop" into two parts, which is not
only necessary but also redundant.
Changes since v1:
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- no code change
- add Acked-by tag
dt-bindings: connector: Add PD rev 2.0 VDO definition
- no code change
usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- merge the assignment to array element 1 into the for loop. No semantic
code logic change.
- add Acked-by tag
=== v1 cover letter
The patches are primarily for the responses to the Discover Identity
command. This part was changed a lot from PD rev2.0 to PD rev3.0 (now
it's rev3.1 :D). e.g. DFP can respond to Discover Identity command with
ACK in PD rev3.x and the Product Type VDOs are quite different. Given
that tcpm.c moved on to PD rev3.x and PD rev2.0 is still supported, some
changes need to be made to support both PD rev3.x and rev2.0.
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- This patch is to unblock the responder ACK to Discover Identity if the
port is DFP and the SVDM version is 2.0
dt-bindings: connector: Add PD rev 2.0 VDO definition
- similar changes to Commit 2a1673f0f1de ("usb: pd: Reland VDO
definitions of PD2.0")
https://lore.kernel.org/linux-usb/20210204005036.1555294-1-kyletso@google.com/
- add a new property sink-vdos-v1 to store the PD rev2.0 VDOs
usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- populate the legacy VDOs from fwnode
- send these data if the port partner is SVDM Version 1.0
===
Kyle Tso (3):
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
dt-bindings: connector: Add PD rev 2.0 VDO definition
usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
.../bindings/connector/usb-connector.yaml | 15 ++++
drivers/usb/typec/tcpm/tcpm.c | 52 ++++++++++----
include/dt-bindings/usb/pd.h | 69 ++++++++++++++++++-
3 files changed, 118 insertions(+), 18 deletions(-)
--
2.32.0.rc0.204.g9fa02ecfa5-goog
next reply other threads:[~2021-05-31 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 9:57 Kyle Tso [this message]
2021-05-31 9:57 ` [PATCH v2 1/3] usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP Kyle Tso
2021-05-31 9:57 ` [PATCH v2 2/3] dt-bindings: connector: Add PD rev 2.0 VDO definition Kyle Tso
2021-05-31 9:57 ` [PATCH v2 3/3] usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0 Kyle Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531095737.2258642-1-kyletso@google.com \
--to=kyletso@google.com \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).