[PATCH 5.10 067/131] USB: f_ncm: ncm_bitrate (speed) is unsigned

[PATCH 5.10 067/131] USB: f_ncm: ncm_bitrate (speed) is unsigned

[Greg Kroah-Hartman]

From: Maciej Żenczykowski <maze@google.com>

commit 3370139745853f7826895293e8ac3aec1430508e upstream.

[  190.544755] configfs-gadget gadget: notify speed -44967296

This is because 4250000000 - 2**32 is -44967296.

Fixes: 9f6ce4240a2b ("usb: gadget: f_ncm.c added")
Cc: Brooke Basile <brookebasile@gmail.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Lorenzo Colitti <lorenzo@google.com>
Cc: Yauheni Kaliuta <yauheni.kaliuta@nokia.com>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>
Acked-By: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210608005344.3762668-1-zenczykowski@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/gadget/function/f_ncm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/gadget/function/f_ncm.c
+++ b/drivers/usb/gadget/function/f_ncm.c
@@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *
 		data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
 		data[1] = data[0];
 
-		DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
+		DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
 		ncm->notify_state = NCM_NOTIFY_CONNECT;
 		break;
 	}

Re: [PATCH 5.10 000/131] 5.10.44-rc1 review

[Naresh Kamboju]

On Mon, 14 Jun 2021 at 16:11, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 131 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 10:26:30 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h


The following kernel crash reported on stable rc 5.10 arm64 db845c board.
I have not bisected this problem yet.

But there is a crash like this reported and discussed on a mailing thread.
https://lore.kernel.org/linux-usb/20210608105656.10795-1-peter.chen@kernel.org/

Crash log on dragonboard 845c:
[ 0.000000] Linux version 5.10.44-rc1 (tuxmake@7e2c3dff6c75)
(aarch64-linux-gnu-gcc (Debian 9.3.0-22) 9.3.0, GNU ld (GNU Binutils
for Debian) 2.35.2) #1 SMP PREEMPT Mon Jun 14 11:22:34 UTC 2021
[ 0.000000] Machine model: Thundercomm Dragonboard 845c
<>
[    5.095538] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
[    5.113805] Unable to handle kernel NULL pointer dereference at
virtual address 0000000000000002
[    5.122686] Mem abort info:
[    5.125531]   ESR = 0x96000004
[    5.128635]   EC = 0x25: DABT (current EL), IL = 32 bits
[    5.134005]   SET = 0, FnV = 0
[    5.137106]   EA = 0, S1PTW = 0
[    5.140297] Data abort info:
[    5.143212]   ISV = 0, ISS = 0x00000004
[    5.147092]   CM = 0, WnR = 0
[    5.150103] [0000000000000002] user address but active_mm is swapper
[    5.156530] Internal error: Oops: 96000004 [#1] PREEMPT SMP
[    5.162151] Modules linked in:
[    5.165254] CPU: 7 PID: 251 Comm: kworker/7:3 Not tainted 5.10.44-rc1 #1
[    5.172011] Hardware name: Thundercomm Dragonboard 845c (DT)
[    5.175959] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
[    5.177738] Workqueue: events deferred_probe_work_func
[    5.190098] ufshcd-qcom 1d84000.ufshc:
ufshcd_find_max_sup_active_icc_level: Regulator capability was not
set, actvIccLevel=0
[    5.194832] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
[    5.194843] pc : inode_permission+0x2c/0x178
[    5.194851] lr : lookup_one_len_common+0xac/0x100
[    5.207380] scsi 1:0:0:49488: Well-known LUN    SKhynix
H28S7Q302BMR     A001 PQ: 0 ANSI: 6

ref:
https://lkft.validation.linaro.org/scheduler/job/2896831#L2835

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

metadata:
  git branch: linux-5.10.y
  git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
  git commit: 406cd5feace812b3715b6fc8114472b6e3bd6d1f
  git describe: v5.10.43-132-g406cd5feace8
  make_kernelversion: 5.10.44-rc1
  kernel-config: https://builds.tuxbuild.com/1twAFGbHcDipBArvNuGfeOtyY9H/config

--
Linaro LKFT
https://lkft.linaro.org