From: Alan Stern <stern@rowland.harvard.edu>
To: Kees Cook <keescook@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Al Cooper <alcooperx@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 0/2] USB: EHCI: Add register array bounds to HCS ports
Date: Wed, 18 Aug 2021 13:49:13 -0400 [thread overview]
Message-ID: <20210818174913.GB197200@rowland.harvard.edu> (raw)
In-Reply-To: <20210818173018.2259231-1-keescook@chromium.org>
On Wed, Aug 18, 2021 at 10:30:16AM -0700, Kees Cook wrote:
> Hi,
>
> This is cleaning up some of the remaining things to be able to apply
> -Warray-bounds and -Wzero-length-bounds globally. Only after doing my
> own version of the port_status patch did I find Arnd's earlier
> patches, including for the weird Broadcom stuff[1].
>
> No binary differences.
>
> v2:
> - use 0x80 as base for brcm registers (stern)
> - switch HCS_N_PORTS_MAX to decimal (stern)
> - update various comments (stern)
> v1: https://lore.kernel.org/lkml/20210818043035.1308062-1-keescook@chromium.org
>
> Thanks!
>
> -Kees
>
> [1] https://lore.kernel.org/lkml/20200527134320.869042-1-arnd@arndb.de/#t
>
> Kees Cook (2):
> USB: EHCI: Add register array bounds to HCS ports
> USB: EHCI: Add alias for Broadcom INSNREG
>
> drivers/usb/host/ehci-brcm.c | 11 ++++-------
> include/linux/usb/ehci_def.h | 33 +++++++++++++++++++++------------
> 2 files changed, 25 insertions(+), 19 deletions(-)
For both patches:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
prev parent reply other threads:[~2021-08-18 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 17:30 [PATCH v2 0/2] USB: EHCI: Add register array bounds to HCS ports Kees Cook
2021-08-18 17:30 ` [PATCH v2 1/2] " Kees Cook
2021-08-18 17:30 ` [PATCH v2 2/2] USB: EHCI: Add alias for Broadcom INSNREG Kees Cook
2021-08-18 17:49 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818174913.GB197200@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).