linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Usb: Storage: usb: Fixed coding style issue
@ 2021-08-21 12:16 Niklas Lantau
  2021-08-26 11:24 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Niklas Lantau @ 2021-08-21 12:16 UTC (permalink / raw)
  To: stern; +Cc: linux-usb, usb-storage, linux-kernel, Niklas Lantau

Fixed coding style issue. Removed not needed braces.

Signed-off-by: Niklas Lantau <niklaslantau@gmail.com>
---
 drivers/usb/storage/usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 90aa9c12ffac..5f562bac14d0 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -926,9 +926,8 @@ static unsigned int usb_stor_sg_tablesize(struct usb_interface *intf)
 {
 	struct usb_device *usb_dev = interface_to_usbdev(intf);
 
-	if (usb_dev->bus->sg_tablesize) {
+	if (usb_dev->bus->sg_tablesize)
 		return usb_dev->bus->sg_tablesize;
-	}
 	return SG_ALL;
 }
 
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Usb: Storage: usb: Fixed coding style issue
  2021-08-21 12:16 [PATCH] Usb: Storage: usb: Fixed coding style issue Niklas Lantau
@ 2021-08-26 11:24 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-08-26 11:24 UTC (permalink / raw)
  To: Niklas Lantau; +Cc: stern, linux-usb, usb-storage, linux-kernel

On Sat, Aug 21, 2021 at 02:16:30PM +0200, Niklas Lantau wrote:
> Fixed coding style issue. Removed not needed braces.

That is not easy to parse.

And it is written either "USB" or "usb", never "Usb".

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-26 11:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 12:16 [PATCH] Usb: Storage: usb: Fixed coding style issue Niklas Lantau
2021-08-26 11:24 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).