* [RFC] aqc111: check for valid header length before parsing
@ 2022-02-15 11:02 Oliver Neukum
0 siblings, 0 replies; only message in thread
From: Oliver Neukum @ 2022-02-15 11:02 UTC (permalink / raw)
To: dmitry.bezrukov, igor.russkikh, meissner, netdev, linux-usb; +Cc: Oliver Neukum
The received package must be checked for being long
enough to contain the header to be parsed, or garbage
may be parsed during fixup.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/net/usb/aqc111.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c
index ea06d10e1c21..7848fe941a36 100644
--- a/drivers/net/usb/aqc111.c
+++ b/drivers/net/usb/aqc111.c
@@ -1084,10 +1084,10 @@ static int aqc111_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
if (!skb)
goto err;
- if (skb->len == 0)
+ skb_len = skb->len;
+ if (skb_len < sizeof(desc_hdr))
goto err;
- skb_len = skb->len;
/* RX Descriptor Header */
skb_trim(skb, skb->len - sizeof(desc_hdr));
desc_hdr = le64_to_cpup((u64 *)skb_tail_pointer(skb));
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-15 11:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 11:02 [RFC] aqc111: check for valid header length before parsing Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).