* [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex
@ 2022-02-18 16:15 Krzysztof Kozlowski
2022-02-18 16:15 ` [PATCH 2/4] dt-bindings: usb: dwc2: add iommus Krzysztof Kozlowski
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-18 16:15 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Dinh Nguyen, linux-usb, devicetree, linux-kernel
Intel Agilex USB DWC2 node is used as compatible with generic snps,dwc2
(just like Altera's Stratix10).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 481aaa09f3f2..048e352c531a 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -41,6 +41,7 @@ properties:
- amlogic,meson8b-usb
- amlogic,meson-gxbb-usb
- amlogic,meson-g12a-usb
+ - intel,socfpga-agilex-hsotg
- const: snps,dwc2
- const: amcc,dwc-otg
- const: apm,apm82181-dwc-otg
@@ -53,7 +54,6 @@ properties:
- const: st,stm32mp15-hsotg
- const: snps,dwc2
- const: samsung,s3c6400-hsotg
- - const: intel,socfpga-agilex-hsotg
reg:
maxItems: 1
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/4] dt-bindings: usb: dwc2: add iommus
2022-02-18 16:15 [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Krzysztof Kozlowski
@ 2022-02-18 16:15 ` Krzysztof Kozlowski
2022-02-22 22:00 ` Rob Herring
2022-02-18 16:15 ` [PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-18 16:15 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Dinh Nguyen, linux-usb, devicetree, linux-kernel
The DWC2 node might use IOMMU (e.g. Altera Stratix10), so add "iommus"
property. This fixes warnings like:
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml:
usb@ffb40000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 048e352c531a..1ba96706bbcb 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -68,6 +68,9 @@ properties:
items:
- const: otg
+ iommus:
+ maxItems: 1
+
resets:
items:
- description: common reset
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current
2022-02-18 16:15 [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Krzysztof Kozlowski
2022-02-18 16:15 ` [PATCH 2/4] dt-bindings: usb: dwc2: add iommus Krzysztof Kozlowski
@ 2022-02-18 16:15 ` Krzysztof Kozlowski
2022-02-22 22:00 ` Rob Herring
2022-02-18 16:15 ` [PATCH 4/4] arm64: dts: agilex/stratix10: add clock-names to USB DWC2 node Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-18 16:15 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Dinh Nguyen, linux-usb, devicetree, linux-kernel
The driver parses disable-over-current protection and some
implementations use it (e.g. Altera Stratix10), so document it in the
bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 1ba96706bbcb..1addab83f4fd 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -68,6 +68,10 @@ properties:
items:
- const: otg
+ disable-over-current:
+ type: boolean
+ description: whether to disable detection of over-current condition.
+
iommus:
maxItems: 1
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/4] arm64: dts: agilex/stratix10: add clock-names to USB DWC2 node
2022-02-18 16:15 [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Krzysztof Kozlowski
2022-02-18 16:15 ` [PATCH 2/4] dt-bindings: usb: dwc2: add iommus Krzysztof Kozlowski
2022-02-18 16:15 ` [PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current Krzysztof Kozlowski
@ 2022-02-18 16:15 ` Krzysztof Kozlowski
2022-02-22 22:00 ` [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Rob Herring
2022-02-22 22:46 ` Dinh Nguyen
4 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-18 16:15 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Dinh Nguyen, linux-usb, devicetree, linux-kernel
USB DWC2 requires clock-names:
arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml:
usb@ffb00000: 'clock-names' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 1 +
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 3ec301bd08a9..d7d1918ae471 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -484,6 +484,7 @@ usb0: usb@ffb00000 {
resets = <&rst USB0_RESET>, <&rst USB0_OCP_RESET>;
reset-names = "dwc2", "dwc2-ecc";
clocks = <&clkmgr STRATIX10_USB_CLK>;
+ clock-names = "otg";
iommus = <&smmu 6>;
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index f4270cf18996..984c71b850c9 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -510,6 +510,7 @@ usb0: usb@ffb00000 {
resets = <&rst USB0_RESET>, <&rst USB0_OCP_RESET>;
reset-names = "dwc2", "dwc2-ecc";
clocks = <&clkmgr AGILEX_USB_CLK>;
+ clock-names = "otg";
iommus = <&smmu 6>;
status = "disabled";
};
--
2.32.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex
2022-02-18 16:15 [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-02-18 16:15 ` [PATCH 4/4] arm64: dts: agilex/stratix10: add clock-names to USB DWC2 node Krzysztof Kozlowski
@ 2022-02-22 22:00 ` Rob Herring
2022-02-22 22:46 ` Dinh Nguyen
4 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-02-22 22:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-usb, Dinh Nguyen, Greg Kroah-Hartman, linux-kernel,
devicetree, Rob Herring
On Fri, 18 Feb 2022 17:15:19 +0100, Krzysztof Kozlowski wrote:
> Intel Agilex USB DWC2 node is used as compatible with generic snps,dwc2
> (just like Altera's Stratix10).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] dt-bindings: usb: dwc2: add iommus
2022-02-18 16:15 ` [PATCH 2/4] dt-bindings: usb: dwc2: add iommus Krzysztof Kozlowski
@ 2022-02-22 22:00 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-02-22 22:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Dinh Nguyen, Greg Kroah-Hartman, linux-kernel, Rob Herring,
devicetree, linux-usb
On Fri, 18 Feb 2022 17:15:20 +0100, Krzysztof Kozlowski wrote:
> The DWC2 node might use IOMMU (e.g. Altera Stratix10), so add "iommus"
> property. This fixes warnings like:
>
> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml:
> usb@ffb40000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current
2022-02-18 16:15 ` [PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current Krzysztof Kozlowski
@ 2022-02-22 22:00 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-02-22 22:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, linux-kernel, linux-usb, Dinh Nguyen,
Rob Herring, devicetree
On Fri, 18 Feb 2022 17:15:21 +0100, Krzysztof Kozlowski wrote:
> The driver parses disable-over-current protection and some
> implementations use it (e.g. Altera Stratix10), so document it in the
> bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex
2022-02-18 16:15 [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-02-22 22:00 ` [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Rob Herring
@ 2022-02-22 22:46 ` Dinh Nguyen
4 siblings, 0 replies; 8+ messages in thread
From: Dinh Nguyen @ 2022-02-22 22:46 UTC (permalink / raw)
To: Krzysztof Kozlowski, Greg Kroah-Hartman, Rob Herring, linux-usb,
devicetree, linux-kernel
All patches applied!
Thanks,
Dinh
On 2/18/22 10:15, Krzysztof Kozlowski wrote:
> Intel Agilex USB DWC2 node is used as compatible with generic snps,dwc2
> (just like Altera's Stratix10).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 481aaa09f3f2..048e352c531a 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -41,6 +41,7 @@ properties:
> - amlogic,meson8b-usb
> - amlogic,meson-gxbb-usb
> - amlogic,meson-g12a-usb
> + - intel,socfpga-agilex-hsotg
> - const: snps,dwc2
> - const: amcc,dwc-otg
> - const: apm,apm82181-dwc-otg
> @@ -53,7 +54,6 @@ properties:
> - const: st,stm32mp15-hsotg
> - const: snps,dwc2
> - const: samsung,s3c6400-hsotg
> - - const: intel,socfpga-agilex-hsotg
>
> reg:
> maxItems: 1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-02-22 22:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 16:15 [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Krzysztof Kozlowski
2022-02-18 16:15 ` [PATCH 2/4] dt-bindings: usb: dwc2: add iommus Krzysztof Kozlowski
2022-02-22 22:00 ` Rob Herring
2022-02-18 16:15 ` [PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current Krzysztof Kozlowski
2022-02-22 22:00 ` Rob Herring
2022-02-18 16:15 ` [PATCH 4/4] arm64: dts: agilex/stratix10: add clock-names to USB DWC2 node Krzysztof Kozlowski
2022-02-22 22:00 ` [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex Rob Herring
2022-02-22 22:46 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).