* [PATCH v2 1/2] usb: ehci-pci: Set PROBE_PREFER_ASYNCHRONOUS
@ 2022-10-29 1:45 Brian Norris
2022-10-29 1:45 ` [PATCH v2 2/2] usb: xhci-pci: " Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2022-10-29 1:45 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, Mathias Nyman
Cc: Brian Norris, linux-kernel, linux-usb
This driver often takes on the order of 8ms to start, but every little
bit counts. It shouldn't have many cross-device dependencies to
race with, nor racy access to shared state with other drivers, so this
should be a relatively low risk change.
This driver was pinpointed as part of a survey of top slowest initcalls
(i.e., are built in, and probing synchronously) on a lab of ChromeOS
systems.
Signed-off-by: Brian Norris <briannorris@chromium.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
Changes in v2:
- Add Alan's Ack
drivers/usb/host/ehci-pci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 17f8b6ea0c35..4b148fe5e43b 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -411,11 +411,12 @@ static struct pci_driver ehci_pci_driver = {
.remove = ehci_pci_remove,
.shutdown = usb_hcd_pci_shutdown,
-#ifdef CONFIG_PM
.driver = {
- .pm = &usb_hcd_pci_pm_ops
- },
+#ifdef CONFIG_PM
+ .pm = &usb_hcd_pci_pm_ops,
#endif
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
+ },
};
static int __init ehci_pci_init(void)
--
2.38.1.273.g43a17bfeac-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2 2/2] usb: xhci-pci: Set PROBE_PREFER_ASYNCHRONOUS
2022-10-29 1:45 [PATCH v2 1/2] usb: ehci-pci: Set PROBE_PREFER_ASYNCHRONOUS Brian Norris
@ 2022-10-29 1:45 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2022-10-29 1:45 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, Mathias Nyman
Cc: Brian Norris, linux-kernel, linux-usb
This driver often takes on the order of 10ms to start, but in some cases
takes more than 100ms. It shouldn't have many cross-device dependencies
to race with, nor racy access to shared state with other drivers, so
this should be a relatively low risk change.
This driver was pinpointed as part of a survey of top slowest initcalls
(i.e., are built in, and probing synchronously) on a lab of ChromeOS
systems.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
Changes in v2:
- Move outside #ifdef CONFIG_PM (oops; thanks Alan)
drivers/usb/host/xhci-pci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 40228a3d77a0..5bbb1fed32d2 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -687,11 +687,12 @@ static struct pci_driver xhci_pci_driver = {
/* suspend and resume implemented later */
.shutdown = usb_hcd_pci_shutdown,
-#ifdef CONFIG_PM
.driver = {
- .pm = &usb_hcd_pci_pm_ops
- },
+#ifdef CONFIG_PM
+ .pm = &usb_hcd_pci_pm_ops,
#endif
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
+ },
};
static int __init xhci_pci_init(void)
--
2.38.1.273.g43a17bfeac-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-29 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-29 1:45 [PATCH v2 1/2] usb: ehci-pci: Set PROBE_PREFER_ASYNCHRONOUS Brian Norris
2022-10-29 1:45 ` [PATCH v2 2/2] usb: xhci-pci: " Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).