* [PATCH] USBIP: add config dependency for SGL_ALLOC
@ 2019-11-12 15:49 Oliver Neukum
2019-11-12 16:11 ` Greg KH
2019-11-12 16:56 ` shuah
0 siblings, 2 replies; 3+ messages in thread
From: Oliver Neukum @ 2019-11-12 15:49 UTC (permalink / raw)
To: valentina.manea.m, shuah, gregkh, linux-usb; +Cc: Oliver Neukum
USBIP uses lib/scatterlist.h
Hence it needs to set CONFIG_SGL_ALLOC
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/usb/usbip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig
index 2f86b28fa3da..7bbae7a08642 100644
--- a/drivers/usb/usbip/Kconfig
+++ b/drivers/usb/usbip/Kconfig
@@ -4,6 +4,7 @@ config USBIP_CORE
tristate "USB/IP support"
depends on NET
select USB_COMMON
+ select SGL_ALLOC
---help---
This enables pushing USB packets over IP to allow remote
machines direct access to USB devices. It provides the
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] USBIP: add config dependency for SGL_ALLOC
2019-11-12 15:49 [PATCH] USBIP: add config dependency for SGL_ALLOC Oliver Neukum
@ 2019-11-12 16:11 ` Greg KH
2019-11-12 16:56 ` shuah
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-11-12 16:11 UTC (permalink / raw)
To: Oliver Neukum; +Cc: valentina.manea.m, shuah, linux-usb
On Tue, Nov 12, 2019 at 04:49:39PM +0100, Oliver Neukum wrote:
> USBIP uses lib/scatterlist.h
> Hence it needs to set CONFIG_SGL_ALLOC
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/usb/usbip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig
> index 2f86b28fa3da..7bbae7a08642 100644
> --- a/drivers/usb/usbip/Kconfig
> +++ b/drivers/usb/usbip/Kconfig
> @@ -4,6 +4,7 @@ config USBIP_CORE
> tristate "USB/IP support"
> depends on NET
> select USB_COMMON
> + select SGL_ALLOC
> ---help---
> This enables pushing USB packets over IP to allow remote
> machines direct access to USB devices. It provides the
> --
> 2.16.4
>
Heh, I had to do this as part of the backport patch, and I was wondering
why this wasn't triggering in Linus's tree as well...
I'll go queue this up now, thanks!
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USBIP: add config dependency for SGL_ALLOC
2019-11-12 15:49 [PATCH] USBIP: add config dependency for SGL_ALLOC Oliver Neukum
2019-11-12 16:11 ` Greg KH
@ 2019-11-12 16:56 ` shuah
1 sibling, 0 replies; 3+ messages in thread
From: shuah @ 2019-11-12 16:56 UTC (permalink / raw)
To: Oliver Neukum, valentina.manea.m, gregkh, linux-usb, shuah
On 11/12/19 8:49 AM, Oliver Neukum wrote:
> USBIP uses lib/scatterlist.h
> Hence it needs to set CONFIG_SGL_ALLOC
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/usb/usbip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig
> index 2f86b28fa3da..7bbae7a08642 100644
> --- a/drivers/usb/usbip/Kconfig
> +++ b/drivers/usb/usbip/Kconfig
> @@ -4,6 +4,7 @@ config USBIP_CORE
> tristate "USB/IP support"
> depends on NET
> select USB_COMMON
> + select SGL_ALLOC
> ---help---
> This enables pushing USB packets over IP to allow remote
> machines direct access to USB devices. It provides the
>
Thanks for catching this.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-12 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 15:49 [PATCH] USBIP: add config dependency for SGL_ALLOC Oliver Neukum
2019-11-12 16:11 ` Greg KH
2019-11-12 16:56 ` shuah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).