* [PATCH 0/3] Enable USB host for AST2600
@ 2020-09-30 4:08 Ryan Chen
2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen
` (3 more replies)
0 siblings, 4 replies; 26+ messages in thread
From: Ryan Chen @ 2020-09-30 4:08 UTC (permalink / raw)
To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed,
linux-kernel, linux-usb, bmc-sw
Cc: Ryan Chen
The patches enable UHCI driver in AST2600 and also enable
USB host in aspeed-ast2600-evb.dts.
Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
arch/arm/configs/aspeed_g5_defconfig | 1 +
drivers/usb/host/uhci-platform.c | 3 ++-
3 files changed, 11 insertions(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 26+ messages in thread* [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-09-30 4:08 [PATCH 0/3] Enable USB host for AST2600 Ryan Chen @ 2020-09-30 4:08 ` Ryan Chen 2020-09-30 16:50 ` Tao Ren 2020-10-07 11:22 ` Joel Stanley 2020-09-30 4:08 ` [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen ` (2 subsequent siblings) 3 siblings, 2 replies; 26+ messages in thread From: Ryan Chen @ 2020-09-30 4:08 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw Cc: Ryan Chen Enable UHCI driver in aspeed_g5_defconfig. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- arch/arm/configs/aspeed_g5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig index 2bacd8c90f4b..a57009d1a3b8 100644 --- a/arch/arm/configs/aspeed_g5_defconfig +++ b/arch/arm/configs/aspeed_g5_defconfig @@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_ROOT_HUB_TT=y CONFIG_USB_EHCI_HCD_PLATFORM=y +CONFIG_USB_UHCI_HCD=y CONFIG_USB_GADGET=y CONFIG_USB_ASPEED_VHUB=y CONFIG_USB_CONFIGFS=y -- 2.17.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen @ 2020-09-30 16:50 ` Tao Ren 2020-10-07 11:22 ` Joel Stanley 1 sibling, 0 replies; 26+ messages in thread From: Tao Ren @ 2020-09-30 16:50 UTC (permalink / raw) To: Ryan Chen Cc: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw On Wed, Sep 30, 2020 at 12:08:21PM +0800, Ryan Chen wrote: > Enable UHCI driver in aspeed_g5_defconfig. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Tao Ren <rentao.bupt@gmail.com> ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen 2020-09-30 16:50 ` Tao Ren @ 2020-10-07 11:22 ` Joel Stanley 1 sibling, 0 replies; 26+ messages in thread From: Joel Stanley @ 2020-10-07 11:22 UTC (permalink / raw) To: Ryan Chen Cc: Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, bmc-sw On Wed, 30 Sep 2020 at 04:08, Ryan Chen <ryan_chen@aspeedtech.com> wrote: > > Enable UHCI driver in aspeed_g5_defconfig. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Joel Stanley <Joel@jms.id.au> > --- > arch/arm/configs/aspeed_g5_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig > index 2bacd8c90f4b..a57009d1a3b8 100644 > --- a/arch/arm/configs/aspeed_g5_defconfig > +++ b/arch/arm/configs/aspeed_g5_defconfig > @@ -212,6 +212,7 @@ CONFIG_USB_DYNAMIC_MINORS=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_EHCI_ROOT_HUB_TT=y > CONFIG_USB_EHCI_HCD_PLATFORM=y > +CONFIG_USB_UHCI_HCD=y > CONFIG_USB_GADGET=y > CONFIG_USB_ASPEED_VHUB=y > CONFIG_USB_CONFIGFS=y > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci 2020-09-30 4:08 [PATCH 0/3] Enable USB host for AST2600 Ryan Chen 2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen @ 2020-09-30 4:08 ` Ryan Chen 2020-09-30 16:52 ` Tao Ren 2020-10-07 11:25 ` Joel Stanley 2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen 2020-10-07 5:45 ` [PATCH 0/3] Enable USB host for AST2600 Ryan Chen 3 siblings, 2 replies; 26+ messages in thread From: Ryan Chen @ 2020-09-30 4:08 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw Cc: Ryan Chen Add support for AST2600 SOC UHCI driver. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- drivers/usb/host/uhci-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c index 70dbd95c3f06..fa40fe125c2a 100644 --- a/drivers/usb/host/uhci-platform.c +++ b/drivers/usb/host/uhci-platform.c @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) num_ports); } if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || - of_device_is_compatible(np, "aspeed,ast2500-uhci")) { + of_device_is_compatible(np, "aspeed,ast2500-uhci") || + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { uhci->is_aspeed = 1; dev_info(&pdev->dev, "Enabled Aspeed implementation workarounds\n"); -- 2.17.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci 2020-09-30 4:08 ` [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen @ 2020-09-30 16:52 ` Tao Ren 2020-10-07 11:25 ` Joel Stanley 1 sibling, 0 replies; 26+ messages in thread From: Tao Ren @ 2020-09-30 16:52 UTC (permalink / raw) To: Ryan Chen Cc: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw On Wed, Sep 30, 2020 at 12:08:22PM +0800, Ryan Chen wrote: > Add support for AST2600 SOC UHCI driver. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Tao Ren <rentao.bupt@gmail.com> ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci 2020-09-30 4:08 ` [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen 2020-09-30 16:52 ` Tao Ren @ 2020-10-07 11:25 ` Joel Stanley 2020-10-07 14:58 ` Alan Stern 1 sibling, 1 reply; 26+ messages in thread From: Joel Stanley @ 2020-10-07 11:25 UTC (permalink / raw) To: Ryan Chen, Alan Stern Cc: Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, bmc-sw On Wed, 30 Sep 2020 at 04:08, Ryan Chen <ryan_chen@aspeedtech.com> wrote: > > Add support for AST2600 SOC UHCI driver. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Joel Stanley <joel@jms.id.au> USB maintainers, can you please take this patch (2/3)? I will take the others in this series through the aspeed tree. Cheers, Joel > --- > drivers/usb/host/uhci-platform.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c > index 70dbd95c3f06..fa40fe125c2a 100644 > --- a/drivers/usb/host/uhci-platform.c > +++ b/drivers/usb/host/uhci-platform.c > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) > num_ports); > } > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) { > + of_device_is_compatible(np, "aspeed,ast2500-uhci") || > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { > uhci->is_aspeed = 1; > dev_info(&pdev->dev, > "Enabled Aspeed implementation workarounds\n"); > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci 2020-10-07 11:25 ` Joel Stanley @ 2020-10-07 14:58 ` Alan Stern 0 siblings, 0 replies; 26+ messages in thread From: Alan Stern @ 2020-10-07 14:58 UTC (permalink / raw) To: Joel Stanley Cc: Ryan Chen, Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, bmc-sw On Wed, Oct 07, 2020 at 11:25:04AM +0000, Joel Stanley wrote: > On Wed, 30 Sep 2020 at 04:08, Ryan Chen <ryan_chen@aspeedtech.com> wrote: > > > > Add support for AST2600 SOC UHCI driver. > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > Reviewed-by: Joel Stanley <joel@jms.id.au> > > USB maintainers, can you please take this patch (2/3)? I will take the > others in this series through the aspeed tree. > > Cheers, > > Joel > > > > --- > > drivers/usb/host/uhci-platform.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c > > index 70dbd95c3f06..fa40fe125c2a 100644 > > --- a/drivers/usb/host/uhci-platform.c > > +++ b/drivers/usb/host/uhci-platform.c > > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) > > num_ports); > > } > > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || > > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) { > > + of_device_is_compatible(np, "aspeed,ast2500-uhci") || > > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { > > uhci->is_aspeed = 1; > > dev_info(&pdev->dev, > > "Enabled Aspeed implementation workarounds\n"); > > -- > > 2.17.1 > > The indentation of the continuation lines isn't good, because the continued parts are aligned with the lines in the conditional block. They should be visually distinct. Either align with the "of_device..." at the start or indent by two extra tab stops. Once this is fixed, you can add: Acked-by: Alan Stern <stern@rowland.harvard.edu> Alan Stern ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-09-30 4:08 [PATCH 0/3] Enable USB host for AST2600 Ryan Chen 2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen 2020-09-30 4:08 ` [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen @ 2020-09-30 4:08 ` Ryan Chen 2020-09-30 16:54 ` Tao Ren ` (2 more replies) 2020-10-07 5:45 ` [PATCH 0/3] Enable USB host for AST2600 Ryan Chen 3 siblings, 3 replies; 26+ messages in thread From: Ryan Chen @ 2020-09-30 4:08 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw Cc: Ryan Chen Add EHCI UHCI enable build in aspeed-ast2600-evb.dts Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts index 89be13197780..2772796e215e 100644 --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts @@ -237,3 +237,11 @@ &fsim0 { status = "okay"; }; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen @ 2020-09-30 16:54 ` Tao Ren 2020-10-07 11:27 ` Joel Stanley 2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen 2 siblings, 0 replies; 26+ messages in thread From: Tao Ren @ 2020-09-30 16:54 UTC (permalink / raw) To: Ryan Chen Cc: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw On Wed, Sep 30, 2020 at 12:08:23PM +0800, Ryan Chen wrote: > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Tao Ren <rentao.bupt@gmail.com> ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen 2020-09-30 16:54 ` Tao Ren @ 2020-10-07 11:27 ` Joel Stanley 2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen 2 siblings, 0 replies; 26+ messages in thread From: Joel Stanley @ 2020-10-07 11:27 UTC (permalink / raw) To: Ryan Chen Cc: Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, bmc-sw On Wed, 30 Sep 2020 at 04:08, Ryan Chen <ryan_chen@aspeedtech.com> wrote: > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > index 89be13197780..2772796e215e 100644 > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > @@ -237,3 +237,11 @@ > &fsim0 { > status = "okay"; > }; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&uhci { > + status = "okay"; > +}; > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 0/3] Enable USB host for AST2600 2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen 2020-09-30 16:54 ` Tao Ren 2020-10-07 11:27 ` Joel Stanley @ 2020-10-09 2:49 ` Ryan Chen 2020-10-09 2:49 ` [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen ` (2 more replies) 2 siblings, 3 replies; 26+ messages in thread From: Ryan Chen @ 2020-10-09 2:49 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw, Alan Stern Cc: Ryan Chen v2: -[1/3]: Add SCSI,BLK_DEV_SD,USB_STORAGE in defconfig. -[2/3]: Fix continuation lines. v1: -The patches enable UHCI driver in AST2600 and also enable USB host in aspeed-ast2600-evb.dts. Ryan Chen (3): configs: aspeed: enable UHCI driver in defconfig usb: host: add uhci compatible support for ast2600-uhci ARM: dts: add ehci uhci enable in evb dts arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ arch/arm/configs/aspeed_g5_defconfig | 4 ++++ drivers/usb/host/uhci-platform.c | 3 ++- 3 files changed, 14 insertions(+), 1 deletion(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen @ 2020-10-09 2:49 ` Ryan Chen 2020-10-09 4:45 ` Greg KH 2020-10-09 2:49 ` [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen 2020-10-09 2:49 ` [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen 2 siblings, 1 reply; 26+ messages in thread From: Ryan Chen @ 2020-10-09 2:49 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw, Alan Stern Cc: Ryan Chen v2: -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. v1: -Enable UHCI driver in aspeed_g5_defconfig. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- arch/arm/configs/aspeed_g5_defconfig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig index 2bacd8c90f4b..7a6b0b79be9f 100644 --- a/arch/arm/configs/aspeed_g5_defconfig +++ b/arch/arm/configs/aspeed_g5_defconfig @@ -90,6 +90,8 @@ CONFIG_BLK_DEV_NBD=y CONFIG_MCTP_LPC=y CONFIG_EEPROM_AT24=y CONFIG_EEPROM_AT25=y +CONFIG_SCSI=y +CONFIG_BLK_DEV_SD=y CONFIG_MD=y CONFIG_BLK_DEV_DM=y CONFIG_DM_VERITY=y @@ -212,6 +214,8 @@ CONFIG_USB_DYNAMIC_MINORS=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_ROOT_HUB_TT=y CONFIG_USB_EHCI_HCD_PLATFORM=y +CONFIG_USB_UHCI_HCD=y +CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_ASPEED_VHUB=y CONFIG_USB_CONFIGFS=y -- 2.17.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-10-09 2:49 ` [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen @ 2020-10-09 4:45 ` Greg KH 2020-10-09 4:55 ` Joel Stanley 0 siblings, 1 reply; 26+ messages in thread From: Greg KH @ 2020-10-09 4:45 UTC (permalink / raw) To: Ryan Chen Cc: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw, Alan Stern On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > v2: > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > v1: > -Enable UHCI driver in aspeed_g5_defconfig. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Why do you need this in a defconfig? ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-10-09 4:45 ` Greg KH @ 2020-10-09 4:55 ` Joel Stanley 2020-10-09 5:46 ` Greg KH 2020-10-09 6:01 ` Ryan Chen 0 siblings, 2 replies; 26+ messages in thread From: Joel Stanley @ 2020-10-09 4:55 UTC (permalink / raw) To: Greg KH Cc: Ryan Chen, Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, BMC-SW, Alan Stern On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > v2: > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > v1: > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > Why do you need this in a defconfig? I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change. Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it. Cheers, Joel ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-10-09 4:55 ` Joel Stanley @ 2020-10-09 5:46 ` Greg KH 2020-10-09 5:59 ` Ryan Chen 2020-10-09 6:01 ` Ryan Chen 1 sibling, 1 reply; 26+ messages in thread From: Greg KH @ 2020-10-09 5:46 UTC (permalink / raw) To: Joel Stanley Cc: Ryan Chen, Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, BMC-SW, Alan Stern On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote: > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the > defconfig so we can test it. I think this is a sensible change. Then it needs to be described in the changelog, otherwise we have no idea why this is happening :) thanks, greg k-h ^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-10-09 5:46 ` Greg KH @ 2020-10-09 5:59 ` Ryan Chen 0 siblings, 0 replies; 26+ messages in thread From: Ryan Chen @ 2020-10-09 5:59 UTC (permalink / raw) To: Greg KH, Joel Stanley Cc: Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, BMC-SW, Alan Stern > -----Original Message----- > From: Greg KH <greg@kroah.com> > Sent: Friday, October 9, 2020 1:47 PM > To: Joel Stanley <joel@jms.id.au> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>; Andrew Jeffery > <andrew@aj.id.au>; Linux ARM <linux-arm-kernel@lists.infradead.org>; > linux-aspeed <linux-aspeed@lists.ozlabs.org>; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig > > On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote: > > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > > v2: > > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > > v1: > > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > > > Why do you need this in a defconfig? > > > > I would prefer configurations that are being used to be present in the > > defconfig so we can test it. I think this is a sensible change. > > Then it needs to be described in the changelog, otherwise we have no idea > why this is happening :) > Ok, will send new version describe it. ^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig 2020-10-09 4:55 ` Joel Stanley 2020-10-09 5:46 ` Greg KH @ 2020-10-09 6:01 ` Ryan Chen 1 sibling, 0 replies; 26+ messages in thread From: Ryan Chen @ 2020-10-09 6:01 UTC (permalink / raw) To: Joel Stanley, Greg KH Cc: Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List, linux-usb, BMC-SW, Alan Stern > -----Original Message----- > From: Joel Stanley <joel@jms.id.au> > Sent: Friday, October 9, 2020 12:55 PM > To: Greg KH <greg@kroah.com> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>; Andrew Jeffery > <andrew@aj.id.au>; Linux ARM <linux-arm-kernel@lists.infradead.org>; > linux-aspeed <linux-aspeed@lists.ozlabs.org>; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig > > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the defconfig > so we can test it. I think this is a sensible change. > > Ryan, I gave you my Reviewed-by for the last version of the patch. As you did > not change the contents of this patch it is fine for you to leave my Reviewed-by > on it. Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch, am I right? ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci 2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen 2020-10-09 2:49 ` [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen @ 2020-10-09 2:49 ` Ryan Chen 2020-10-09 4:45 ` Greg KH 2020-10-09 2:49 ` [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen 2 siblings, 1 reply; 26+ messages in thread From: Ryan Chen @ 2020-10-09 2:49 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw, Alan Stern Cc: Ryan Chen v2: - Fix continuation lines, align with "of_device" v1: - Add support for AST2600 SOC UHCI driver. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- drivers/usb/host/uhci-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c index 70dbd95c3f06..be9e9db7cad1 100644 --- a/drivers/usb/host/uhci-platform.c +++ b/drivers/usb/host/uhci-platform.c @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) num_ports); } if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || - of_device_is_compatible(np, "aspeed,ast2500-uhci")) { + of_device_is_compatible(np, "aspeed,ast2500-uhci") || + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { uhci->is_aspeed = 1; dev_info(&pdev->dev, "Enabled Aspeed implementation workarounds\n"); -- 2.17.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci 2020-10-09 2:49 ` [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen @ 2020-10-09 4:45 ` Greg KH 0 siblings, 0 replies; 26+ messages in thread From: Greg KH @ 2020-10-09 4:45 UTC (permalink / raw) To: Ryan Chen Cc: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw, Alan Stern On Fri, Oct 09, 2020 at 10:49:36AM +0800, Ryan Chen wrote: > v2: > - Fix continuation lines, align with "of_device" > v1: > - Add support for AST2600 SOC UHCI driver. These all go below the --- line, as the kernel documentation asks for. > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> You have no changelog text here at all, and I can't take that, sorry. Please fix this up and resend with a proper changelog text. thanks, greg k-h ^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen 2020-10-09 2:49 ` [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen 2020-10-09 2:49 ` [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen @ 2020-10-09 2:49 ` Ryan Chen 2020-10-09 8:22 ` Sergei Shtylyov 2 siblings, 1 reply; 26+ messages in thread From: Ryan Chen @ 2020-10-09 2:49 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw, Alan Stern Cc: Ryan Chen Add EHCI UHCI enable build in aspeed-ast2600-evb.dts Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts index 89be13197780..2772796e215e 100644 --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts @@ -237,3 +237,11 @@ &fsim0 { status = "okay"; }; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-10-09 2:49 ` [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen @ 2020-10-09 8:22 ` Sergei Shtylyov 2020-10-12 0:43 ` Ryan Chen 0 siblings, 1 reply; 26+ messages in thread From: Sergei Shtylyov @ 2020-10-09 8:22 UTC (permalink / raw) To: Ryan Chen, Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, bmc-sw, Alan Stern HEllo! On 09.10.2020 5:49, Ryan Chen wrote: > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> [...] MBR, Sergei ^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-10-09 8:22 ` Sergei Shtylyov @ 2020-10-12 0:43 ` Ryan Chen 2020-10-21 23:44 ` Andrew Jeffery 0 siblings, 1 reply; 26+ messages in thread From: Ryan Chen @ 2020-10-12 0:43 UTC (permalink / raw) To: Sergei Shtylyov, Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, BMC-SW, Alan Stern Hello Segei, > -----Original Message----- > From: Sergei Shtylyov <sergei.shtylyov@gmail.com> > Sent: Friday, October 9, 2020 4:23 PM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>; > Andrew Jeffery <andrew@aj.id.au>; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan Stern > <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts > > HEllo! > > On 09.10.2020 5:49, Ryan Chen wrote: > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > Yes, it is enable for AST2600 EVB. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > [...] > > MBR, Sergei ^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-10-12 0:43 ` Ryan Chen @ 2020-10-21 23:44 ` Andrew Jeffery 2020-10-22 7:21 ` Ryan Chen 0 siblings, 1 reply; 26+ messages in thread From: Andrew Jeffery @ 2020-10-21 23:44 UTC (permalink / raw) To: Ryan Chen, Sergei Shtylyov, Joel Stanley, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, BMC-SW, Alan Stern Hi Ryan, On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote: > Hello Segei, > > > -----Original Message----- > > From: Sergei Shtylyov <sergei.shtylyov@gmail.com> > > Sent: Friday, October 9, 2020 4:23 PM > > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>; > > Andrew Jeffery <andrew@aj.id.au>; linux-arm-kernel@lists.infradead.org; > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan Stern > > <stern@rowland.harvard.edu> > > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts > > > > HEllo! > > > > On 09.10.2020 5:49, Ryan Chen wrote: > > > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > > > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > > > > Yes, it is enable for AST2600 EVB. I think Sergei was suggesting you change the wording of the commit message. Andrew ^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts 2020-10-21 23:44 ` Andrew Jeffery @ 2020-10-22 7:21 ` Ryan Chen 0 siblings, 0 replies; 26+ messages in thread From: Ryan Chen @ 2020-10-22 7:21 UTC (permalink / raw) To: Andrew Jeffery, Sergei Shtylyov, Joel Stanley, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, BMC-SW, Alan Stern > -----Original Message----- > From: Andrew Jeffery <andrew@aj.id.au> > Sent: Thursday, October 22, 2020 7:45 AM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Sergei Shtylyov > <sergei.shtylyov@gmail.com>; Joel Stanley <joel@jms.id.au>; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; > linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts > > Hi Ryan, > > On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote: > > Hello Segei, > > > > > -----Original Message----- > > > From: Sergei Shtylyov <sergei.shtylyov@gmail.com> > > > Sent: Friday, October 9, 2020 4:23 PM > > > To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley > > > <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; > > > linux-arm-kernel@lists.infradead.org; > > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > > > linux-usb@vger.kernel.org; BMC-SW <BMC-SW@aspeedtech.com>; Alan > > > Stern <stern@rowland.harvard.edu> > > > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb > > > dts > > > > > > HEllo! > > > > > > On 09.10.2020 5:49, Ryan Chen wrote: > > > > > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts > > > > > > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps? > > > > > > > Yes, it is enable for AST2600 EVB. > > I think Sergei was suggesting you change the wording of the commit message. > Thanks, will resend the patch with modification. ^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH 0/3] Enable USB host for AST2600 2020-09-30 4:08 [PATCH 0/3] Enable USB host for AST2600 Ryan Chen ` (2 preceding siblings ...) 2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen @ 2020-10-07 5:45 ` Ryan Chen 3 siblings, 0 replies; 26+ messages in thread From: Ryan Chen @ 2020-10-07 5:45 UTC (permalink / raw) To: Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed, linux-kernel, linux-usb, BMC-SW Hello Joel, Have you take time review this patches ? Ryan Chen Tel : 886-3-5751185 ext:8857 > -----Original Message----- > From: Ryan Chen <ryan_chen@aspeedtech.com> > Sent: Wednesday, September 30, 2020 12:08 PM > To: Joel Stanley <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; > linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com> > Cc: Ryan Chen <ryan_chen@aspeedtech.com> > Subject: [PATCH 0/3] Enable USB host for AST2600 > > The patches enable UHCI driver in AST2600 and also enable USB host in > aspeed-ast2600-evb.dts. > > Ryan Chen (3): > configs: aspeed: enable UHCI driver in defconfig > usb: host: add uhci compatible support for ast2600-uhci > ARM: dts: add ehci uhci enable in evb dts > > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++ > arch/arm/configs/aspeed_g5_defconfig | 1 + > drivers/usb/host/uhci-platform.c | 3 ++- > 3 files changed, 11 insertions(+), 1 deletion(-) > > -- > 2.17.1 ^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2020-10-22 7:21 UTC | newest] Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-30 4:08 [PATCH 0/3] Enable USB host for AST2600 Ryan Chen 2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen 2020-09-30 16:50 ` Tao Ren 2020-10-07 11:22 ` Joel Stanley 2020-09-30 4:08 ` [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen 2020-09-30 16:52 ` Tao Ren 2020-10-07 11:25 ` Joel Stanley 2020-10-07 14:58 ` Alan Stern 2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen 2020-09-30 16:54 ` Tao Ren 2020-10-07 11:27 ` Joel Stanley 2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen 2020-10-09 2:49 ` [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen 2020-10-09 4:45 ` Greg KH 2020-10-09 4:55 ` Joel Stanley 2020-10-09 5:46 ` Greg KH 2020-10-09 5:59 ` Ryan Chen 2020-10-09 6:01 ` Ryan Chen 2020-10-09 2:49 ` [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen 2020-10-09 4:45 ` Greg KH 2020-10-09 2:49 ` [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen 2020-10-09 8:22 ` Sergei Shtylyov 2020-10-12 0:43 ` Ryan Chen 2020-10-21 23:44 ` Andrew Jeffery 2020-10-22 7:21 ` Ryan Chen 2020-10-07 5:45 ` [PATCH 0/3] Enable USB host for AST2600 Ryan Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).