* [PATCH] phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq
@ 2019-10-01 18:11 Geert Uytterhoeven
2019-10-02 4:50 ` Yoshihiro Shimoda
2019-10-03 16:10 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-10-01 18:11 UTC (permalink / raw)
To: Yoshihiro Shimoda, Kishon Vijay Abraham I, Greg Kroah-Hartman
Cc: Stephen Boyd, linux-renesas-soc, linux-usb, linux-kernel,
Geert Uytterhoeven
As platform_get_irq() now prints an error when the interrupt does not
exist, a scary warning may be printed for an optional interrupt:
phy_rcar_gen3_usb2 ee0a0200.usb-phy: IRQ index 0 not found
Fix this by calling platform_get_irq_optional() instead.
Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This is a fix for v5.4-rc1.
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
index b7f6b132439521ea..49ec67d46ccc5a37 100644
--- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
@@ -614,7 +614,7 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
return PTR_ERR(channel->base);
/* call request_irq for OTG */
- irq = platform_get_irq(pdev, 0);
+ irq = platform_get_irq_optional(pdev, 0);
if (irq >= 0) {
INIT_WORK(&channel->work, rcar_gen3_phy_usb2_work);
irq = devm_request_irq(dev, irq, rcar_gen3_phy_usb2_irq,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq
2019-10-01 18:11 [PATCH] phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq Geert Uytterhoeven
@ 2019-10-02 4:50 ` Yoshihiro Shimoda
2019-10-03 16:10 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2019-10-02 4:50 UTC (permalink / raw)
To: Geert Uytterhoeven, Kishon Vijay Abraham I, Greg Kroah-Hartman
Cc: Stephen Boyd, linux-renesas-soc, linux-usb, linux-kernel
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, October 2, 2019 3:11 AM
>
> As platform_get_irq() now prints an error when the interrupt does not
> exist, a scary warning may be printed for an optional interrupt:
>
> phy_rcar_gen3_usb2 ee0a0200.usb-phy: IRQ index 0 not found
>
> Fix this by calling platform_get_irq_optional() instead.
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is a fix for v5.4-rc1.
> ---
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
And, I tested this patch on R-Car H3. So,
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq
2019-10-01 18:11 [PATCH] phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq Geert Uytterhoeven
2019-10-02 4:50 ` Yoshihiro Shimoda
@ 2019-10-03 16:10 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2019-10-03 16:10 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Kroah-Hartman, Kishon Vijay Abraham I,
Yoshihiro Shimoda
Cc: linux-renesas-soc, linux-usb, linux-kernel, Geert Uytterhoeven
Quoting Geert Uytterhoeven (2019-10-01 11:11:09)
> As platform_get_irq() now prints an error when the interrupt does not
> exist, a scary warning may be printed for an optional interrupt:
>
> phy_rcar_gen3_usb2 ee0a0200.usb-phy: IRQ index 0 not found
>
> Fix this by calling platform_get_irq_optional() instead.
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-03 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 18:11 [PATCH] phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq Geert Uytterhoeven
2019-10-02 4:50 ` Yoshihiro Shimoda
2019-10-03 16:10 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).