From: Oliver Neukum <oneukum@suse.com>
To: zhuyinbo <zhuyinbo@loongson.cn>, Oliver Neukum <oneukum@suse.com>,
Jiri Kosina <jikos@kernel.org>,
benjamin.tissoires@redhat.com, gregkh@linuxfoundation.org,
Thinh.Nguyen@synopsys.com, mathias.nyman@linux.intel.com,
stern@rowland.harvard.edu, rajatja@google.com,
chris.chiu@canonical.com, linux-usb@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device
Date: Tue, 14 Dec 2021 15:21:50 +0100 [thread overview]
Message-ID: <654e90fb-2f04-1f87-f56c-792757e140a0@suse.com> (raw)
In-Reply-To: <d2e4a97a-b89b-eaf4-5aaf-89af22227746@loongson.cn>
On 10.12.21 10:50, zhuyinbo wrote:
Hi,
> system ask that must it must be accped a acpi lid open event then
> system will always into resume state for laptop, otherwise, eventhough
> that system be wakeuped by other event then system will continue into
> suspend.
Lid events are necesarily for the whole system.
>
> and for laptop usb wakeup that as general ask bios to enable usb
> wakeup then if need do more things to enable usb wakeup I think this
> usb wakeup function isn't friendly and inconveient, so enable it by
> default.
> after add this patch, if want to use usb wakeup function it only need
> enable bios configure it think it is appropriate.
>
No. If you wish your laptop to be resumed by USB events, that is one thing.
You can alter the system settings. That must work. But it is a different
issue
from the default.
In general any HID device must have wakeup capability to be usable for
selective suspend. You cannot draw conclusions from that.
Regards
Oliver
next prev parent reply other threads:[~2021-12-14 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 9:39 [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device Yinbo Zhu
2021-12-08 9:39 ` [PATCH v1 2/2] usb: core: enable remote wakeup function for usb controller Yinbo Zhu
2021-12-08 14:10 ` kernel test robot
2021-12-08 22:04 ` Alan Stern
2021-12-10 9:27 ` zhuyinbo
2021-12-10 16:35 ` Alan Stern
2021-12-08 10:03 ` [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device Oliver Neukum
2021-12-10 9:50 ` zhuyinbo
2021-12-14 14:21 ` Oliver Neukum [this message]
2021-12-16 10:59 ` zhuyinbo
2021-12-16 12:42 ` Oliver Neukum
2022-01-04 11:44 ` zhuyinbo
2021-12-08 11:55 ` Greg Kroah-Hartman
2021-12-10 9:54 ` zhuyinbo
2021-12-10 10:45 ` Greg Kroah-Hartman
2021-12-16 11:40 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=654e90fb-2f04-1f87-f56c-792757e140a0@suse.com \
--to=oneukum@suse.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=benjamin.tissoires@redhat.com \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rajatja@google.com \
--cc=stern@rowland.harvard.edu \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).