From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: zhuyinbo <zhuyinbo@loongson.cn>
Cc: Jiri Kosina <jikos@kernel.org>,
benjamin.tissoires@redhat.com, Thinh.Nguyen@synopsys.com,
mathias.nyman@linux.intel.com, stern@rowland.harvard.edu,
rajatja@google.com, chris.chiu@canonical.com,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device
Date: Fri, 10 Dec 2021 11:45:28 +0100 [thread overview]
Message-ID: <YbMvyK111M/ZVRJG@kroah.com> (raw)
In-Reply-To: <cc535d3d-6dcd-e69c-24e7-df54ce63c381@loongson.cn>
On Fri, Dec 10, 2021 at 05:54:33PM +0800, zhuyinbo wrote:
>
>
> 在 2021/12/8 下午7:55, Greg Kroah-Hartman 写道:
> > On Wed, Dec 08, 2021 at 05:39:50PM +0800, Yinbo Zhu wrote:
> > > The remote wake-up function is a regular function on usb hid device
> > > and I think keeping it enabled by default will make usb application
> > > more convenient. This patch is to enable remote wakeup function for
> > > usb hid device.
> >
> > How many devices did you test this on?
> >
> > As Oliver said, this will cause problems, there's a reason no operating
> > system does this :(
> >
> > sorry,
> >
> > greg k-h
> Hi greg,
>
> About that oliver said that I had expained, and I add this change was
> according that usb device whether support remote wakeup and if it support
> wakeup then to enabled it so I think it should be okay for all hid device.
Again, what devices did you test this on?
And look at other operating systems, as I said, there is a reason that
no one does this.
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-10 10:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 9:39 [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device Yinbo Zhu
2021-12-08 9:39 ` [PATCH v1 2/2] usb: core: enable remote wakeup function for usb controller Yinbo Zhu
2021-12-08 14:10 ` kernel test robot
2021-12-08 22:04 ` Alan Stern
2021-12-10 9:27 ` zhuyinbo
2021-12-10 16:35 ` Alan Stern
2021-12-08 10:03 ` [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device Oliver Neukum
2021-12-10 9:50 ` zhuyinbo
2021-12-14 14:21 ` Oliver Neukum
2021-12-16 10:59 ` zhuyinbo
2021-12-16 12:42 ` Oliver Neukum
2022-01-04 11:44 ` zhuyinbo
2021-12-08 11:55 ` Greg Kroah-Hartman
2021-12-10 9:54 ` zhuyinbo
2021-12-10 10:45 ` Greg Kroah-Hartman [this message]
2021-12-16 11:40 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbMvyK111M/ZVRJG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=benjamin.tissoires@redhat.com \
--cc=chris.chiu@canonical.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rajatja@google.com \
--cc=stern@rowland.harvard.edu \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).