* [PATCH v2] usb: dwc2: gadget: Fix sending zero length packet in DDMA mode.
@ 2021-06-24 11:13 Minas Harutyunyan
0 siblings, 0 replies; only message in thread
From: Minas Harutyunyan @ 2021-06-24 11:13 UTC (permalink / raw)
To: linux-usb; +Cc: John.Youn, balbi, yousaf.kaukab
Sending zero length packet in DDMA mode perform by DMA descriptor
by setting SP (short packet) flag.
For DDMA in function dwc2_hsotg_complete_in() does not need to send
zlp.
Tested by USBCV MSC tests.
Fixes: f71b5e2533de ("usb: dwc2: gadget: fix zero length packet transfers")
Signed-off-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
---
Changes in v2:
- Minor typo correction in comments
drivers/usb/dwc2/gadget.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index c581ee41ac81..bf456b4e191f 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -2749,9 +2749,11 @@ static void dwc2_hsotg_complete_in(struct dwc2_hsotg *hsotg,
return;
}
- /* Zlp for all endpoints, for ep0 only in DATA IN stage */
+ /* Zlp for all endpoints in non DDMA, for ep0 only in DATA IN stage */
if (hs_ep->send_zlp) {
- dwc2_hsotg_program_zlp(hsotg, hs_ep);
+ if (!using_desc_dma(hsotg))
+ dwc2_hsotg_program_zlp(hsotg, hs_ep);
+
hs_ep->send_zlp = 0;
/* transfer will be completed on next complete interrupt */
return;
base-commit: 00a738b86ec0c88ad4745f658966f951cbe4c885
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-24 11:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 11:13 [PATCH v2] usb: dwc2: gadget: Fix sending zero length packet in DDMA mode Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).